JRuby

Test for embedded JRuby are not run by CI

Details

  • Type: Test Test
  • Status: Resolved Resolved
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: JRuby 1.7.0.pre1
  • Fix Version/s: JRuby 1.7.0.pre2
  • Component/s: Embedding
  • Labels:
    None
  • Number of attachments :
    0

Description

Tests for embedded JRuby, like org.jruby.embed.ScriptingContainerTest, are run by the ant macro "<run-junit-embed-all/>" which is run by the target "run-junit-embed" which is run by the target "test-extended".

Neither of these targets are run by JenkinsCI, only "test" and "test-all".

I propose we add "run-junit-embed" as a dependency to the "test" target". This will add about 30 seconds to the test run, but ensure that embedding JRuby works, at least as much as has been covered by the tests.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Charles Oliver Nutter added a comment -

Yeah, I had meant to get this added. The tests aren't very long, and if the "all" test is failing they may never run.

I will add this to travis, so that local "test" runs don't get longer.

Show
Charles Oliver Nutter added a comment - Yeah, I had meant to get this added. The tests aren't very long, and if the "all" test is failing they may never run. I will add this to travis, so that local "test" runs don't get longer.
Hide
Permalink
Charles Oliver Nutter added a comment - 
commit dd94f9046b5a0875005b3fd69f5611d2e7992d39
Author: Charles Oliver Nutter <headius@headius.com>
Date:   Mon Jul 23 09:07:15 2012 -0500

    Fix JRUBY-6789: Test for embedded JRuby are not run by CI
    
    I switched travis to running test-extended, which includes the
    embedding tests and now also includes a full interpreted test run.

:100644 100644 6b4c41c... 3370194... M	.travis.yml
:100644 100644 b50d193... 5bdbc09... M	antlib/test.xml
Show
Charles Oliver Nutter added a comment - commit dd94f9046b5a0875005b3fd69f5611d2e7992d39 Author: Charles Oliver Nutter <headius@headius.com> Date: Mon Jul 23 09:07:15 2012 -0500 Fix JRUBY-6789: Test for embedded JRuby are not run by CI I switched travis to running test-extended, which includes the embedding tests and now also includes a full interpreted test run. :100644 100644 6b4c41c... 3370194... M .travis.yml :100644 100644 b50d193... 5bdbc09... M antlib/test.xml

People

  • Assignee:
    Charles Oliver Nutter
    Reporter:
    Uwe Kubosch
Vote (0)
Watch (3)

Dates

  • Created:
    Updated:
    Resolved: