JRuby

Module#constants should maintain proper order

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Won't Fix
  • Affects Version/s: JRuby 1.6.7
  • Fix Version/s: None
  • Component/s: Core Classes/Modules
  • Labels:
    None
  • Environment:
    Linux 3.0.0-16-generic #29-Ubuntu SMP Tue Feb 14 12:48:51 UTC 2012 x86_64 x86_64 x86_64 GNU/Linux

    jruby 1.6.7 (ruby-1.9.2-p312) (2012-02-22 3e82bc8) (Java HotSpot(TM) 64-Bit Server VM 1.6.0_26) [linux-amd64-java]
  • Number of attachments :
    0

Description

The array returned by Module#constants should[1] have the most recently defined constant last but this is not the case.

module MyNamespace
    class First
    end

    class Second
    end

    class Third
    end
end

p MyNamespace.constants
# => [:Third, :Second, :First]

In this case they are in reverse order but that isn't always the case either.

[1] Not sure if I should be using the word "should", maybe this isn't behavior that one should rely on but that's how it has been on the standard interpreters for years.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Charles Oliver Nutter added a comment -

A survey of popular interpreters shows that MRI does indeed maintain ordering, but other implementations do not. I am somewhat inclined to mark this WONT FIX because I don't feel the ordering is part of the API. This might be something to confirm with Matz; if he says it's part of the API, we'll do it. If not, we won't.

system ~/projects/jruby $ jirb
>> module M
>> class A; end
>> class B; end
>> class C; end
>> class D; end
>> class E; end
>> class F; end
>> class G; end
>> class H; end
>> class I; end
>> class J; end
>> end
=> nil
>> M.constants
=> [:D, :E, :F, :G, :A, :B, :C, :H, :I, :J]
>> quit

system ~/projects/jruby $ irb1.9.3
>> module M
>> class A; end
>> class B; end
>> class C; end
>> class D; end
>> class E; end
>> class F; end
>> class G; end
>> class H; end
>> class I; end
>> class J; end
>> end
=> nil
>> M.constants
=> [:A, :B, :C, :D, :E, :F, :G, :H, :I, :J]
>> quit

system ~/projects/jruby $ ../rubinius/bin/rbx
>> module M
>> class A; end
>> class B; end
>> class C; end
>> class D; end
>> class E; end
>> class F; end
>> class G; end
>> class H; end
>> class I; end
>> class J; end
>> end
=> nil
>> M.constants
=> ["D", "E", "F", "G", "H", "I", "A", "J", "B", "C"]
>>
Show
Charles Oliver Nutter added a comment - A survey of popular interpreters shows that MRI does indeed maintain ordering, but other implementations do not. I am somewhat inclined to mark this WONT FIX because I don't feel the ordering is part of the API. This might be something to confirm with Matz; if he says it's part of the API, we'll do it. If not, we won't. system ~/projects/jruby $ jirb >> module M >> class A; end >> class B; end >> class C; end >> class D; end >> class E; end >> class F; end >> class G; end >> class H; end >> class I; end >> class J; end >> end => nil >> M.constants => [:D, :E, :F, :G, :A, :B, :C, :H, :I, :J] >> quit system ~/projects/jruby $ irb1.9.3 >> module M >> class A; end >> class B; end >> class C; end >> class D; end >> class E; end >> class F; end >> class G; end >> class H; end >> class I; end >> class J; end >> end => nil >> M.constants => [:A, :B, :C, :D, :E, :F, :G, :H, :I, :J] >> quit system ~/projects/jruby $ ../rubinius/bin/rbx >> module M >> class A; end >> class B; end >> class C; end >> class D; end >> class E; end >> class F; end >> class G; end >> class H; end >> class I; end >> class J; end >> end => nil >> M.constants => ["D", "E", "F", "G", "H", "I", "A", "J", "B", "C"] >>
Hide
Permalink
Hiro Asari added a comment -

http://bugs.ruby-lang.org/issues/6600

Show
Hiro Asari added a comment - http://bugs.ruby-lang.org/issues/6600
Hide
Permalink
Charles Oliver Nutter added a comment -

In the immortal words of nobu: "No."

Show
Charles Oliver Nutter added a comment - In the immortal words of nobu: "No."

People

  • Assignee:
    Charles Oliver Nutter
    Reporter:
    Tasos Laskos
Vote (0)
Watch (4)

Dates

  • Created:
    Updated:
    Resolved: