JRuby

Net::HTTP ignore JSE defined HTTP Proxy options

Details

  • Type: Bug Bug
  • Status: Resolved Resolved
  • Priority: Minor Minor
  • Resolution: Incomplete
  • Affects Version/s: JRuby 1.6.7, JRuby 1.7.0.pre1
  • Fix Version/s: JRuby 1.7.0.pre2
  • Component/s: Java Integration
  • Labels:
    None
  • Environment:

    jruby -J-Dhttp.proxyHost=localhost -J-Dhttp.proxyPort=8080
  • Number of attachments :
    0

Description

There is an accepted http_proxy setting as an environment variable or setting a JVM System property http.proxyHost. Net::HTTP seems to only register a proxy setting when explicitly declared with Net::HTTP::Proxy#start.

Net::HTTP should check at least the JVM system property when making requests. The doc does mention not using the ENVIRONMENT variable but I believe a special case should be made for a JVM setting.

https://github.com/jruby/jruby/pull/195

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Charles Oliver Nutter added a comment -

I am not opposed. Looking into the PR.

Show
Charles Oliver Nutter added a comment - I am not opposed. Looking into the PR.
Hide
Permalink
Charles Oliver Nutter added a comment -

Discussion is happening on the PR. Since the PR shows up as an issue I'm resolving this one.

Show
Charles Oliver Nutter added a comment - Discussion is happening on the PR. Since the PR shows up as an issue I'm resolving this one.

People

  • Assignee:
    Charles Oliver Nutter
    Reporter:
    Jacob Evans
Vote (0)
Watch (2)

Dates

  • Created:
    Updated:
    Resolved:

Time Tracking

Estimated:
1h
Original Estimate - 1 hour
Remaining:
1h
Remaining Estimate - 1 hour
Logged:
Not Specified
Time Spent - Not Specified