Details

    • Type: Bug Bug
    • Status: Resolved Resolved
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: JRuby 1.7.0.pre1
    • Fix Version/s: JRuby 1.7.0.pre2
    • Component/s: C Extensions
    • Labels:
      None
    • Environment:
      CC="ccache gcc"
    • Number of attachments :
      0

      Description

      after fail go to cext/src:

      CC="ccache gcc" make

      fails, but:

      CC=gcc make

      works as expected.

        Activity

        Hide
        Hiro Asari added a comment -

        Michal,

        To think, we take ccache into account if it is available. See https://github.com/jruby/jruby/blob/ab78ce9179fa13d2610cf9a04632d475651ddd35/cext/src/Makefile#L55

        It seems to me that my ccache fails differently from yours when ccache invokes a program that doesn't meet the expectations.

        Show
        Hiro Asari added a comment - Michal, To think, we take ccache into account if it is available. See https://github.com/jruby/jruby/blob/ab78ce9179fa13d2610cf9a04632d475651ddd35/cext/src/Makefile#L55 It seems to me that my ccache fails differently from yours when ccache invokes a program that doesn't meet the expectations.
        Hide
        Michal Papis added a comment -

        my ccache version is 3.1.7

        for me what happens is that
        https://github.com/jruby/jruby/blob/ab78ce9179fa13d2610cf9a04632d475651ddd35/cext/src/Makefile#L309

        uses CC with ccache inside,

        maybe $(CC) could be changed to:

        $(patsubst %ccache,,$(CC))

        which ensures there is no ccache duplication? - I have tested it on my machine and it worked.

        Show
        Michal Papis added a comment - my ccache version is 3.1.7 for me what happens is that https://github.com/jruby/jruby/blob/ab78ce9179fa13d2610cf9a04632d475651ddd35/cext/src/Makefile#L309 uses CC with ccache inside, maybe $(CC) could be changed to: $(patsubst %ccache,,$(CC)) which ensures there is no ccache duplication? - I have tested it on my machine and it worked.
        Hide
        Hiro Asari added a comment -

        Michal,

        Would you like to put a patch together, so we can give you credit for the fix?

        Show
        Hiro Asari added a comment - Michal, Would you like to put a patch together, so we can give you credit for the fix?
        Hide
        Michal Papis added a comment -

        done https://github.com/jruby/jruby/pull/180

        Right now the behavior changes depending on the platform, Makefile is vulnerable for existing user environment.

        I guess solution could be to reset environment on top and overwrite platform differences after.

        Show
        Michal Papis added a comment - done https://github.com/jruby/jruby/pull/180 Right now the behavior changes depending on the platform, Makefile is vulnerable for existing user environment. I guess solution could be to reset environment on top and overwrite platform differences after.
        Hide
        Hiro Asari added a comment -

        Merged.

        Show
        Hiro Asari added a comment - Merged.

          People

          • Assignee:
            Charles Oliver Nutter
            Reporter:
            Michal Papis
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: