Details

    • Type: Bug Bug
    • Status: Resolved Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: JRuby 1.7.0.pre1
    • Fix Version/s: JRuby 1.7.0.pre1
    • Component/s: C Extensions
    • Labels:
      None
    • Environment:
      jruby 1.7.0.dev (ruby-1.9.3-p203) (2012-05-12 ab6cb39) (OpenJDK 64-Bit Server VM 1.7.0_03) [linux-amd64-java]
    • Number of attachments :
      1

      Description

      Assume a file named 'depend', which has the following content, exists.

      foo.o: foo.c foo.h
      bar.o: bar.c bar.h
      

      The content is added to the end of Makefile generated by create_makefile.
      It works fine with jruby-1.6.7, but doesn't work with jruby trunk head.

      Here is a patch.

      --- a/lib/ruby/shared/mkmf.rb
      +++ b/lib/ruby/shared/mkmf.rb
      @@ -1737,7 +1737,7 @@ site-install-rb: install-rb
             mfile.print ".SUFFIXES: .", suffixes.uniq.join(" ."), "\n\n"
           end
           mfile.print "$(OBJS): $(RUBY_EXTCONF_H)\n\n" if $extconf_h
      -    mfile.print depout
      +    mfile.print *depout
         else
           headers = []
           if RULE_SUBST
      (
      

        Activity

        Hide
        Hiro Asari added a comment -

        Can you attach a git patch, so that we can give you credit for it?

        Show
        Hiro Asari added a comment - Can you attach a git patch, so that we can give you credit for it?
        Hide
        Kubo Takehiro added a comment -

        I made a git patch.
        Thanks.

        Show
        Kubo Takehiro added a comment - I made a git patch. Thanks.
        Hide
        Hiro Asari added a comment -

        Merged to master (5c58b21).

        Thanks, Kubo-san.

        Show
        Hiro Asari added a comment - Merged to master (5c58b21). Thanks, Kubo-san.

          People

          • Assignee:
            Hiro Asari
            Reporter:
            Kubo Takehiro
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: