JRuby

File#exists? cannot find file in JAR

Details

  • Type: Bug Bug
  • Status: Resolved Resolved
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: JRuby 1.7.0.pre1
  • Fix Version/s: JRuby 1.7.0.pre1
  • Component/s: Core Classes/Modules
  • Labels:
    None
  • Environment:
    OS X Lion
    jruby 1.7.0.dev (ruby-1.9.3-p139) (2012-04-21 694c0b9) (Java HotSpot(TM) 64-Bit Server VM 1.6.0_31) [darwin-x86_64-java]
  • Number of attachments :
    1

Description

The following test added to test/test_file.rb fails:

  def test_file_exists_uri_prefixes
    assert(!FileTest.exists?("file:test/dir with spaces/test_jar.jar!/abc/foo.rb"))
    assert(!FileTest.exists?("jar:file:test/dir with spaces/test_jar.jar!/abc/foo.rb"))
  end

Other tests work on files in jars.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Uwe Kubosch added a comment - - edited

Terribly sorry: I missed the '!', and the class used should be File, not FileTest. Without the '!' and using File instead of FileTest, the second assert fails, and it should succeed.

Show
Uwe Kubosch added a comment - - edited Terribly sorry: I missed the '!', and the class used should be File, not FileTest. Without the '!' and using File instead of FileTest, the second assert fails, and it should succeed.
Hide
Permalink
Uwe Kubosch added a comment -

Added patch with test and fix.

Please review.

Show
Uwe Kubosch added a comment - Added patch with test and fix. Please review.
Uwe Kubosch made changes -
Field Original Value New Value
Attachment 0001-JRUBY-6624-Strip-jar-prefix-when-searching-for-files.patch [ 59707 ]
Hide
Permalink
Hiro Asari added a comment -

Merged and pushed to master c5976ec.

Thanks, Uwe!

Show
Hiro Asari added a comment - Merged and pushed to master c5976ec. Thanks, Uwe!
Hiro Asari made changes -
Status Open [ 1 ] Resolved [ 5 ]
Assignee Hiro Asari [ asari ]
Resolution Fixed [ 1 ]

People

  • Assignee:
    Hiro Asari
    Reporter:
    Uwe Kubosch
Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved: