Details

    • Type: Bug Bug
    • Status: Closed Closed
    • Priority: Trivial Trivial
    • Resolution: Not A Bug
    • Affects Version/s: None
    • Fix Version/s: JRuby 1.x+
    • Component/s: Windows
    • Labels:
      None
    • Environment:
      The problem is platform independent, it occures when having \r\n as a line delimiter. Those usually appear when creating/editing files under Windows.
    • Number of attachments :
      1

      Description

      When working with a Ruby code file that contains \r\n as line delimiters, the position of ast-nodes at the end of a line have incorrect position information. Namely the position includes the \r which is in fact one character too much.

      The position error origins in the wrappedRead() method of the LexerSource. There the a \r with following \n is jumped and the position increased, which results in a position that exceeds the actual position by one.

      Proposed solution is not to skip the \r. Return it as result of wrappedRead() it then should be treated like a white space.

        Activity

        Hide
        Charles Oliver Nutter added a comment -

        We'll look at adding fixes for things like this, which is primarily an IDE bug, post 1.0.

        Show
        Charles Oliver Nutter added a comment - We'll look at adding fixes for things like this, which is primarily an IDE bug, post 1.0.
        Hide
        Charles Oliver Nutter added a comment -

        Fix for 1.1.

        Show
        Charles Oliver Nutter added a comment - Fix for 1.1.
        Hide
        Charles Oliver Nutter added a comment -

        Punting issues from 1.1 RC2 to 1.1 final.

        Show
        Charles Oliver Nutter added a comment - Punting issues from 1.1 RC2 to 1.1 final.
        Hide
        Thomas E Enebo added a comment -

        Bumping

        Show
        Thomas E Enebo added a comment - Bumping
        Hide
        Charles Oliver Nutter added a comment -

        Since we forked off our parser for IDE use (JRubyParser) we no longer maintain column/character offset data in JRuby. As a result, this bug is no longer valid, since line terminators can't set anything off.

        Show
        Charles Oliver Nutter added a comment - Since we forked off our parser for IDE use (JRubyParser) we no longer maintain column/character offset data in JRuby. As a result, this bug is no longer valid, since line terminators can't set anything off.

          People

          • Assignee:
            Charles Oliver Nutter
            Reporter:
            Thomas Corbat
          • Votes:
            1 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: