JRuby

GzipReader encodings still not right; breaks "gem install"

Details

  • Type: Bug Bug
  • Status: Resolved Resolved
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: JRuby 1.7.0.pre1
  • Fix Version/s: JRuby 1.7.0.pre1
  • Component/s: Extensions
  • Labels:
    None
  • Testcase included:
    yes
  • Number of attachments :
    0

Description

Currently "gem install" fails on master, due to issues with GzipReader, since https://github.com/jruby/jruby/commit/84e3e3fe. Note that GzipReader itself doesn't fail but does produce gobbledegook. See the gist for a test case.

https://gist.github.com/1725255

Issue Links

is duplicated by

Bug - A problem which impairs or prevents the functions of the product. JRUBY-6421 installing jruby-launcher fails with wrong filenames (zlib error apparently)

  • Major - Major loss of function.
  • Resolved - A resolution has been taken, and it is awaiting verification by reporter. From here issues are either reopened, or are closed.

Activity

Hide
Permalink
Hiroshi Nakamura added a comment -

Fixed at master.

commit 660145112c2f082d1c6db7be1910fe08ca4b5c97
Author: Hiroshi Nakamura <nahi@ruby-lang.org>
Date:   Fri Feb 3 11:33:22 2012 +0900

    JRUBY-6419: GzipReader encodings still not right; breaks "gem install"
    
    Having scanned zlib.c of CRuby again, I found that GzReader#read()
    (without size parameter) sets Encoding but GzReader#read(size) does
    not.  So make JRuby version do the same as CRuby.
    
    It could be a bug of CRuby. (It should not set Encoding for read() as
    well.)
Show
Hiroshi Nakamura added a comment - Fixed at master. commit 660145112c2f082d1c6db7be1910fe08ca4b5c97 Author: Hiroshi Nakamura <nahi@ruby-lang.org> Date: Fri Feb 3 11:33:22 2012 +0900 JRUBY-6419: GzipReader encodings still not right; breaks "gem install" Having scanned zlib.c of CRuby again, I found that GzReader#read() (without size parameter) sets Encoding but GzReader#read(size) does not. So make JRuby version do the same as CRuby. It could be a bug of CRuby. (It should not set Encoding for read() as well.)

People

  • Assignee:
    Hiroshi Nakamura
    Reporter:
    Nick Sieger
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: