JRuby

Should JRuby 1.7 set 1.9 compatibility as default?

Details

  • Type: Epic Epic
  • Status: Resolved Resolved
  • Priority: Critical Critical
  • Resolution: Fixed
  • Affects Version/s: None
  • Fix Version/s: JRuby 1.7.0.pre1
  • Component/s: None
  • Labels:
    None
  • Number of attachments :
    0

Description

We've heard some interest from the users that we should switch the default language mode to 1.9.

We should decide if 1.7 is the one to make the switch.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Ilya Grigorik added a comment -

Yes!

Show
Ilya Grigorik added a comment - Yes!
Hide
Permalink
Darrick Wiebe added a comment -

Yes, please!

Show
Darrick Wiebe added a comment - Yes, please!
Hide
Permalink
Paul Cowan added a comment -

Yes, for sure

Show
Paul Cowan added a comment - Yes, for sure
Hide
Permalink
Brandon Dennis added a comment -

Yes

Show
Brandon Dennis added a comment - Yes
Hide
Permalink
Tobias H. Michaelsen added a comment -

Yes, absolutely

Show
Tobias H. Michaelsen added a comment - Yes, absolutely
Hide
Permalink
tommy chheng added a comment -

+1, all of our apps are using ruby 1.9.

Show
tommy chheng added a comment - +1, all of our apps are using ruby 1.9.
Hide
Permalink
Vlad Gorodetsky added a comment -

+1, yes!

Show
Vlad Gorodetsky added a comment - +1, yes!
Hide
Permalink
Carl Hörberg added a comment - - edited

Yes, definitely! Is anybody still using 1.8 for new projects?

Show
Carl Hörberg added a comment - - edited Yes, definitely! Is anybody still using 1.8 for new projects?
Hide
Permalink
Richard BEN ALEYA added a comment -

Yes please, I use JRuby 1.6 with -Djruby.compat.version=1.9 in Production.

Show
Richard BEN ALEYA added a comment - Yes please, I use JRuby 1.6 with -Djruby.compat.version=1.9 in Production.
Hide
Permalink
Jonathan Simms added a comment -

YES! please!

Show
Jonathan Simms added a comment - YES! please!
Hide
Permalink
Erik Michaels-Ober added a comment -

NO! Just kidding...YES!

Show
Erik Michaels-Ober added a comment - NO! Just kidding...YES!
Hide
Permalink
Maxim Sokolovsky added a comment -

Yes please! There are no new projects still using 1.8!

Show
Maxim Sokolovsky added a comment - Yes please! There are no new projects still using 1.8!
Hide
Permalink
Marek Jelen added a comment -

Yes.

Show
Marek Jelen added a comment - Yes.
Hide
Permalink
Luca Simone added a comment -

Absolutely YES, the only thing that stop me to use it today in 1.9 mode was the .to_yaml error using warbler...

Show
Luca Simone added a comment - Absolutely YES, the only thing that stop me to use it today in 1.9 mode was the .to_yaml error using warbler...
Hide
Permalink
Theo Hultberg added a comment -

Yes please!

Sadly 1.8 mode still seems faster for the kind of things I use JRuby for – looks like the string encoding stuff in 1.9 mode has an impact on performance when you do lots of string manipulation, and there have been a few buts with block parameters and yield (JRUBY-6171, for example), but they seems fixed.

But yes! I still prefer programming in 1.9 so it's well worth it! I haven't used JRuby without the --1.9 flag since I switched to it.

Show
Theo Hultberg added a comment - Yes please! Sadly 1.8 mode still seems faster for the kind of things I use JRuby for – looks like the string encoding stuff in 1.9 mode has an impact on performance when you do lots of string manipulation, and there have been a few buts with block parameters and yield ( JRUBY-6171 , for example), but they seems fixed. But yes! I still prefer programming in 1.9 so it's well worth it! I haven't used JRuby without the --1.9 flag since I switched to it.
Hide
Permalink
Michael Klishin added a comment -

A resounding "yes".

Show
Michael Klishin added a comment - A resounding "yes".
Hide
Permalink
Dmytrii Nagirniak added a comment -

Yes! 1.8 is officially dead (not yet practically).
First Matz killed it then rails. It doesn't have 3rd life.

Show
Dmytrii Nagirniak added a comment - Yes! 1.8 is officially dead (not yet practically). First Matz killed it then rails. It doesn't have 3rd life.
Hide
Permalink
Chuck Remes added a comment -

Yes.

Show
Chuck Remes added a comment - Yes.
Hide
Permalink
Ollivier Robert added a comment -

Yes.

Show
Ollivier Robert added a comment - Yes.
Hide
Permalink
Alex Coles added a comment -

Yes!

Show
Alex Coles added a comment - Yes!
Hide
Permalink
Bill Dueber added a comment -

Yes!

Show
Bill Dueber added a comment - Yes!
Hide
Permalink
Douglas Campos added a comment -

Yes!

Show
Douglas Campos added a comment - Yes!
Hide
Permalink
Chris Samuel added a comment -

Yes please!

Show
Chris Samuel added a comment - Yes please!
Hide
Permalink
Shane Emmons added a comment -

Yes!

Show
Shane Emmons added a comment - Yes!
Hide
Permalink
Raphael Valyi added a comment -

Yes, JRuby adoption is driven by forward thinking persons. 1.9 by default please!

Show
Raphael Valyi added a comment - Yes, JRuby adoption is driven by forward thinking persons. 1.9 by default please!
Hide
Permalink
Hiro Asari added a comment -

It's an Epic!

Since Rails 4 will be 1.9-only, and we should have 1.7 released before then, I feel quite good about changing the default. It will be a minor nuisance for people running in 1.8 mode in production, so we should educate them well in advance.

Show
Hiro Asari added a comment - It's an Epic! Since Rails 4 will be 1.9-only, and we should have 1.7 released before then, I feel quite good about changing the default. It will be a minor nuisance for people running in 1.8 mode in production, so we should educate them well in advance.
Hide
Permalink
decentrality added a comment -

Yes! For some reason, with my torquebox configuration, even 1.8 compatible code isn't functioning unless I specify 1.9 anyway.

Show
decentrality added a comment - Yes! For some reason, with my torquebox configuration, even 1.8 compatible code isn't functioning unless I specify 1.9 anyway.
Hide
Permalink
McClain Looney added a comment -

yes

Show
McClain Looney added a comment - yes
Hide
Permalink
Alex Tambellini added a comment -

Yes!

Show
Alex Tambellini added a comment - Yes!
Hide
Permalink
Peter Fitzgibbons added a comment -

+1 Yes

Show
Peter Fitzgibbons added a comment - +1 Yes
Hide
Permalink
Cristian Molina added a comment -

Yes!, of course!

Show
Cristian Molina added a comment - Yes!, of course!
Hide
Permalink
Charles Oliver Nutter added a comment -

It is done.

commit 3163d6ca94ccc8fd33851896614a42c29b2e5ec6
Author: Charles Oliver Nutter <headius@headius.com>
Date:   Fri Jan 27 11:37:17 2012 -0600

    Switch default Ruby mode to 1.9.

diff --git a/default.build.properties b/default.build.properties
index fa4d03c..53f23a7 100644
--- a/default.build.properties
+++ b/default.build.properties
@@ -98,4 +98,4 @@ mac.dist=${build.dir}/jruby-${version.jruby}
 dist.zip=${dist.dir}/jruby-bin-${version.jruby}.zip
 gems.dist.dir=${build.dir}/gems_dist
 gems.defaults.dir=${mac.dist}/lib/ruby/shared/rubygems/defaults
-jruby.default.ruby.version=1.8
+jruby.default.ruby.version=1.9
Show
Charles Oliver Nutter added a comment - It is done. commit 3163d6ca94ccc8fd33851896614a42c29b2e5ec6 Author: Charles Oliver Nutter <headius@headius.com> Date: Fri Jan 27 11:37:17 2012 -0600 Switch default Ruby mode to 1.9. diff --git a/default.build.properties b/default.build.properties index fa4d03c..53f23a7 100644 --- a/default.build.properties +++ b/default.build.properties @@ -98,4 +98,4 @@ mac.dist=${build.dir}/jruby-${version.jruby} dist.zip=${dist.dir}/jruby-bin-${version.jruby}.zip gems.dist.dir=${build.dir}/gems_dist gems.defaults.dir=${mac.dist}/lib/ruby/shared/rubygems/defaults -jruby.default.ruby.version=1.8 +jruby.default.ruby.version=1.9
Hide
Permalink
Youhei Kondou added a comment -

I hope 1.9

Show
Youhei Kondou added a comment - I hope 1.9
Hide
Permalink
Darrick Wiebe added a comment -

Victory!!

Show
Darrick Wiebe added a comment - Victory!!

People

  • Assignee:
    Thomas E Enebo
    Reporter:
    Hiro Asari
Vote (20)
Watch (2)

Dates

  • Created:
    Updated:
    Resolved: