Details
-
Type:
Bug
-
Status:
Resolved
-
Priority:
Major
-
Resolution: Fixed
-
Affects Version/s: JRuby 1.6.6, JRuby 1.7.0.pre1
-
Fix Version/s: JRuby-OSSL 0.7.6
-
Component/s: OpenSSL
-
Labels:None
-
Number of attachments :
Description
Could be a symptom of something worse? We have had some recent issues with Digest not loading properly.
[junit] ------------- Standard Error -----------------
[junit] :1 warning: already initialized constant ARGV
[junit] ------------- ---------------- ---------------
[junit] Testcase: externals/ruby1.8/openssl/test_hmac(org.jruby.test.TestUnitTestSuite$ScriptTest): FAILED
[junit] Faults encountered running test/externals/ruby1.8/openssl/test_hmac, complete output follows:
[junit] Error:
[junit] test_dup(OpenSSL::TestHMAC):
[junit] NameError: uninitialized constant OpenSSL::Digest::MD5
[junit] org/jruby/RubyModule.java:2610:in `const_missing'
[junit] ./test/externals/ruby1.8/openssl/test_hmac.rb:11:in `setup'
[junit] org/jruby/RubyArray.java:1609:in `each'
[junit] Error:
[junit] test_hmac(OpenSSL::TestHMAC):
[junit] NameError: uninitialized constant OpenSSL::Digest::MD5
[junit] org/jruby/RubyModule.java:2610:in `const_missing'
[junit] ./test/externals/ruby1.8/openssl/test_hmac.rb:11:in `setup'
[junit] org/jruby/RubyArray.java:1609:in `each'
[junit]
[junit] junit.framework.AssertionFailedError: Faults encountered running test/externals/ruby1.8/openssl/test_hmac, complete output follows:
[junit] Error:
[junit] test_dup(OpenSSL::TestHMAC):
[junit] NameError: uninitialized constant OpenSSL::Digest::MD5
[junit] org/jruby/RubyModule.java:2610:in `const_missing'
[junit] ./test/externals/ruby1.8/openssl/test_hmac.rb:11:in `setup'
[junit] org/jruby/RubyArray.java:1609:in `each'
[junit] Error:
[junit] test_hmac(OpenSSL::TestHMAC):
[junit] NameError: uninitialized constant OpenSSL::Digest::MD5
[junit] org/jruby/RubyModule.java:2610:in `const_missing'
[junit] ./test/externals/ruby1.8/openssl/test_hmac.rb:11:in `setup'
[junit] org/jruby/RubyArray.java:1609:in `each'
[junit]
[junit] at org.jruby.test.TestUnitTestSuite$ScriptTest.runTest(TestUnitTestSuite.java:225)
Activity
Hide
Charles Oliver Nutter
added a comment -
This is the commit that breaks things:
commit d8f5711cf02eac787752a6a203cb1de39a618e42
Author: Hiroshi Nakamura <nahi@ruby-lang.org>
Date: Thu Dec 29 15:51:03 2011 +0900
Implement OpenSSL.errors, debug, and debug=
The failure is because it's calling setInstanceVariable("debug" ...), but "debug" is not a valid instance variable name. It should either be @debug, or it should be calling setInternalVariable.
It's a nitpicky assertion, but we have it in place to ensure Ruby-facing instance variable lists never have anything that can't be accessed from Ruby (as "debug" in this case).
Fixing.
Nahi: Anything stopping a release right to fix this up? It's driving me nuts doing test runs 
Show
Charles Oliver Nutter
added a comment - This is the commit that breaks things:
commit d8f5711cf02eac787752a6a203cb1de39a618e42
Author: Hiroshi Nakamura <nahi@ruby-lang.org>
Date: Thu Dec 29 15:51:03 2011 +0900
Implement OpenSSL.errors, debug, and debug=
The failure is because it's calling setInstanceVariable("debug" ...), but "debug" is not a valid instance variable name. It should either be @debug, or it should be calling setInternalVariable.
It's a nitpicky assertion, but we have it in place to ensure Ruby-facing instance variable lists never have anything that can't be accessed from Ruby (as "debug" in this case).
Fixing.
Nahi: Anything stopping a release right to fix this up? It's driving me nuts doing test runs
Show
Charles Oliver Nutter
added a comment - No problem I've broken my share of builds!
Charles, would you tell me the instruction you did? I cannot find the message in test-all-master and test-all-release in CI results. And test/externals/ruby1.?/openssl should not be tested against jruby-openssl. (JRuby-OSSL is using tests in its repository which is in sync with CRuby repo with some modifications)