JRuby

yaml broken for last 1.6.6 build?

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Blocker Blocker
  • Resolution: Fixed
  • Affects Version/s: JRuby 1.6.6
  • Fix Version/s: JRuby 1.6.6
  • Component/s: Ruby 1.9.2
  • Labels:
    None
  • Environment:
    arturas@zeus:~/work/spacegame/server$ jruby --1.9 -v
    jruby 1.6.6.dev (ruby-1.9.2-p312) (2012-01-26 333c503) (Java HotSpot(TM) Client VM 1.7.0) [linux-i386-java]
  • Number of attachments :
    0

Description

I've built jruby-head (1.6) this morning to see how autoload behaves and this is what I've got...

arturas@zeus:~/work/spacegame/server$ jruby --1.9 -S irb
jruby-head-n166 :001 > require 'yaml'
NameError: method 'to_yaml' not defined in Object
	from org/jruby/RubyModule.java:2316:in `remove_method'
	from /home/arturas/.rvm/rubies/jruby-head-n166/lib/ruby/1.9/yaml.rb:30:in `(eval)'
	from org/jruby/RubyModule.java:2289:in `module_eval'
	from /home/arturas/.rvm/rubies/jruby-head-n166/lib/ruby/1.9/yaml.rb:26:in `yamler='
	from /home/arturas/.rvm/rubies/jruby-head-n166/lib/ruby/1.9/yaml.rb:48:in `(root)'
	from org/jruby/RubyKernel.java:1036:in `require'
	from /home/arturas/.rvm/rubies/jruby-head-n166/lib/ruby/1.9/yaml.rb:36:in `require'
	from (irb):1:in `evaluate'
	from org/jruby/RubyKernel.java:1082:in `eval'
	from org/jruby/RubyKernel.java:1408:in `loop'
	from org/jruby/RubyKernel.java:1195:in `catch'
	from org/jruby/RubyKernel.java:1195:in `catch'
	from /home/arturas/.rvm/rubies/jruby-head-n166/bin/jirb:17:in `(root)'

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Hiro Asari added a comment - 
234ae0333441b2dc01eef50d40f0d0d0cfa3c720 is the first bad commit
commit 234ae0333441b2dc01eef50d40f0d0d0cfa3c720
Author: Charles Oliver Nutter <headius@headius.com>
Date:   Wed Jan 25 17:46:01 2012 -0600

    Fix my idiotic breakage of YAML in 1.9 mode.

:040000 040000 53deb96a010a1381169f42ff66271d27a21a7dd4 cfd6a557caaf58cf4b9c587103d324b04c2db5c7 M	lib
Show
Hiro Asari added a comment - 234ae0333441b2dc01eef50d40f0d0d0cfa3c720 is the first bad commit commit 234ae0333441b2dc01eef50d40f0d0d0cfa3c720 Author: Charles Oliver Nutter <headius@headius.com> Date: Wed Jan 25 17:46:01 2012 -0600 Fix my idiotic breakage of YAML in 1.9 mode. :040000 040000 53deb96a010a1381169f42ff66271d27a21a7dd4 cfd6a557caaf58cf4b9c587103d324b04c2db5c7 M lib
Hiro Asari made changes -
Field Original Value New Value
Assignee Thomas E Enebo [ enebo ] Charles Oliver Nutter [ headius ]
Hide
Permalink
Charles Oliver Nutter added a comment -

More unbreaking on jruby-1_6@6ff47b3. Sigh.

Show
Charles Oliver Nutter added a comment - More unbreaking on jruby-1_6@6ff47b3. Sigh.
Charles Oliver Nutter made changes -
Status Open [ 1 ] Resolved [ 5 ]
Fix Version/s JRuby 1.6.6 [ 18033 ]
Resolution Fixed [ 1 ]
Hide
Permalink
Charles Oliver Nutter added a comment -

Looks like it was this commit, and I simply botched it:

commit 834832787849d4baf3d5c98c9b4b007ac099ca9e
Author: Charles Oliver Nutter <headius@headius.com>
Date:   Wed Jan 25 09:09:38 2012 -0600

    Reinstate engine check.

diff --git a/lib/ruby/1.9/yaml.rb b/lib/ruby/1.9/yaml.rb
index 7c2aa00..1c268d1 100644
--- a/lib/ruby/1.9/yaml.rb
+++ b/lib/ruby/1.9/yaml.rb
@@ -11,16 +11,14 @@ module YAML
     end
 
     def yamler= engine
+      raise(ArgumentError, "bad engine") unless %w{syck psych}.include?(engine)
+
       # JRuby only supports psych, so we warn and ignore
       if engine != 'psych'
         warn "JRuby 1.9 mode only supports the `psych` YAML engine; ignoring `#{engine}`"
       end
       return
 
-      raise(ArgumentError, "bad engine") unless %w{syck psych}.include?(engine)
-
-      require engine
-
       Object.class_eval <<-eorb, __FILE__, __LINE__ + 1
         remove_const 'YAML'
         YAML = #{engine.capitalize}
Show
Charles Oliver Nutter added a comment - Looks like it was this commit, and I simply botched it: commit 834832787849d4baf3d5c98c9b4b007ac099ca9e Author: Charles Oliver Nutter <headius@headius.com> Date: Wed Jan 25 09:09:38 2012 -0600 Reinstate engine check. diff --git a/lib/ruby/1.9/yaml.rb b/lib/ruby/1.9/yaml.rb index 7c2aa00..1c268d1 100644 --- a/lib/ruby/1.9/yaml.rb +++ b/lib/ruby/1.9/yaml.rb @@ -11,16 +11,14 @@ module YAML end def yamler= engine + raise(ArgumentError, "bad engine") unless %w{syck psych}.include?(engine) + # JRuby only supports psych, so we warn and ignore if engine != 'psych' warn "JRuby 1.9 mode only supports the `psych` YAML engine; ignoring `#{engine}`" end return - raise(ArgumentError, "bad engine") unless %w{syck psych}.include?(engine) - - require engine - Object.class_eval <<-eorb, __FILE__, __LINE__ + 1 remove_const 'YAML' YAML = #{engine.capitalize}
Charles Oliver Nutter made changes -
Status Resolved [ 5 ] Closed [ 6 ]

People

  • Assignee:
    Charles Oliver Nutter
    Reporter:
    Arturas Slajus
Vote (1)
Watch (2)

Dates

  • Created:
    Updated:
    Resolved: