Wrong line numbers reported in stacktrace if using binding.eval

Details

Type: Bug
Status: Closed
Priority: Minor
Resolution: Not A Bug
Affects Version/s: JRuby 1.6.6
Fix Version/s: None
Component/s: Interpreter
Labels:
None

Number of attachments :
0

Description

If error is raised in evaled block which is bound to binding and it raises an error, wrong line numbers are reported in backtrace:

arturas@zeus:~/work/spacegame/server$ cat test.rb
def test
do_stuff(binding)
end

def do_stuff(binding) # line 5
binding.eval %Q

{ raise 'error' # error is actually raised here }

end

test
arturas@zeus:~/work/spacegame/server$ ruby test.rb
RuntimeError: error
do_stuff at test.rb:5 <------
eval at org/jruby/RubyKernel.java:1088
eval at org/jruby/RubyBinding.java:134
do_stuff at test.rb:6
test at test.rb:2
(root) at test.rb:14

If binding is not used, everything is ok.

arturas@zeus:~/work/spacegame/server$ cat test.rb
def test
do_stuff(binding)
end

def do_stuff(binding)
eval %Q

{ raise 'error' }

end

test
arturas@zeus:~/work/spacegame/server$ ruby test.rb
RuntimeError: error
do_stuff at (eval):5
eval at org/jruby/RubyKernel.java:1088
do_stuff at test.rb:6
test at test.rb:2
(root) at test.rb:14

Activity

Ascending order - Click to sort in descending order

Hide

Permalink

Arturas Slajus added a comment - 22/Jan/12 5:10 AM

JIRA ate my formatting

arturas@zeus:~/work/spacegame/server$ cat test.rb 
def test
  do_stuff(binding)
end

def do_stuff(binding) # line 5
  binding.eval %Q{



raise 'error' # error is actually raised here
}
end

test
arturas@zeus:~/work/spacegame/server$ ruby test.rb 
RuntimeError: error
  do_stuff at test.rb:5 <----------
      eval at org/jruby/RubyKernel.java:1088
      eval at org/jruby/RubyBinding.java:134
  do_stuff at test.rb:6
      test at test.rb:2
    (root) at test.rb:14

arturas@zeus:~/work/spacegame/server$ cat test.rb 
def test
  do_stuff(binding)
end

def do_stuff(binding)
  eval %Q{



raise 'error'
}
end

test
arturas@zeus:~/work/spacegame/server$ ruby test.rb 
RuntimeError: error
  do_stuff at (eval):5
      eval at org/jruby/RubyKernel.java:1088
  do_stuff at test.rb:6
      test at test.rb:2
    (root) at test.rb:14

Show

Arturas Slajus added a comment - 22/Jan/12 5:10 AM JIRA ate my formatting arturas@zeus:~/work/spacegame/server$ cat test.rb def test do_stuff(binding) end def do_stuff(binding) # line 5 binding.eval %Q{ raise 'error' # error is actually raised here } end test arturas@zeus:~/work/spacegame/server$ ruby test.rb RuntimeError: error do_stuff at test.rb:5 <---------- eval at org/jruby/RubyKernel.java:1088 eval at org/jruby/RubyBinding.java:134 do_stuff at test.rb:6 test at test.rb:2 (root) at test.rb:14 arturas@zeus:~/work/spacegame/server$ cat test.rb def test do_stuff(binding) end def do_stuff(binding) eval %Q{ raise 'error' } end test arturas@zeus:~/work/spacegame/server$ ruby test.rb RuntimeError: error do_stuff at (eval):5 eval at org/jruby/RubyKernel.java:1088 do_stuff at test.rb:6 test at test.rb:2 (root) at test.rb:14

Hide

Permalink

Charles Oliver Nutter added a comment - 15/Feb/12 1:40 AM

None of these make sense to me. JRuby seems the least wrong, since at least the line number corresponds to the line in the eval string.

system ~/projects/jruby $ jruby -e "b = binding
binding.eval <<EOF
# ovarall: 3, eval: 1
# overall: 4, eval: 2
# overall: 5, eval: 3
raise
EOF
"
RuntimeError: No current exception
         at -e:4
    eval at org/jruby/RubyBinding.java:134
  (root) at -e:2

system ~/projects/jruby $ ruby -v -e "b = binding
binding.eval <<EOF
# ovarall: 3, eval: 1
# overall: 4, eval: 2
# overall: 5, eval: 3
raise
EOF
"
ruby 1.8.7 (2010-01-10 patchlevel 249) [universal-darwin10.0]
-e:5: unhandled exception
	from -e:2

system ~/projects/jruby $ ruby1.9.2 -v -e "b = binding
binding.eval <<EOF
# ovarall: 3, eval: 1
# overall: 4, eval: 2
# overall: 5, eval: 3
raise
EOF
"
ruby 1.9.2p289 (2011-07-04 revision 32391) [x86_64-darwin10.8.0]
-e:5:in `<main>': unhandled exception
	from -e:2:in `eval'
	from -e:2:in `<main>'

system ~/projects/jruby $ rvm 1.9.3 do ruby -v -e "b = binding
binding.eval <<EOF
# ovarall: 3, eval: 1
# overall: 4, eval: 2
# overall: 5, eval: 3
raise
EOF
"
ruby 1.9.3p0 (2011-10-30 revision 33570) [x86_64-darwin10.8.0]
-e:5:in `<main>': unhandled exception
	from -e:2:in `eval'
	from -e:2:in `<main>'

Show

Charles Oliver Nutter added a comment - 15/Feb/12 1:40 AM None of these make sense to me. JRuby seems the least wrong, since at least the line number corresponds to the line in the eval string. system ~/projects/jruby $ jruby -e "b = binding binding.eval <<EOF # ovarall: 3, eval: 1 # overall: 4, eval: 2 # overall: 5, eval: 3 raise EOF " RuntimeError: No current exception at -e:4 eval at org/jruby/RubyBinding.java:134 (root) at -e:2 system ~/projects/jruby $ ruby -v -e "b = binding binding.eval <<EOF # ovarall: 3, eval: 1 # overall: 4, eval: 2 # overall: 5, eval: 3 raise EOF " ruby 1.8.7 (2010-01-10 patchlevel 249) [universal-darwin10.0] -e:5: unhandled exception from -e:2 system ~/projects/jruby $ ruby1.9.2 -v -e "b = binding binding.eval <<EOF # ovarall: 3, eval: 1 # overall: 4, eval: 2 # overall: 5, eval: 3 raise EOF " ruby 1.9.2p289 (2011-07-04 revision 32391) [x86_64-darwin10.8.0] -e:5:in `<main>': unhandled exception from -e:2:in `eval' from -e:2:in `<main>' system ~/projects/jruby $ rvm 1.9.3 do ruby -v -e "b = binding binding.eval <<EOF # ovarall: 3, eval: 1 # overall: 4, eval: 2 # overall: 5, eval: 3 raise EOF " ruby 1.9.3p0 (2011-10-30 revision 33570) [x86_64-darwin10.8.0] -e:5:in `<main>': unhandled exception from -e:2:in `eval' from -e:2:in `<main>'

Hide

Permalink

Charles Oliver Nutter added a comment - 15/Feb/12 1:41 AM

Also behaves this way for eval string, binding:

system ~/projects/jruby $ jruby -e "b = binding
eval <<EOF, binding
# ovarall: 3, eval: 1
# overall: 4, eval: 2
# overall: 5, eval: 3
raise
EOF
"
RuntimeError: No current exception
         at -e:4
    eval at org/jruby/RubyKernel.java:1016
  (root) at -e:2

Show

Charles Oliver Nutter added a comment - 15/Feb/12 1:41 AM Also behaves this way for eval string, binding: system ~/projects/jruby $ jruby -e "b = binding eval <<EOF, binding # ovarall: 3, eval: 1 # overall: 4, eval: 2 # overall: 5, eval: 3 raise EOF " RuntimeError: No current exception at -e:4 eval at org/jruby/RubyKernel.java:1016 (root) at -e:2

Hide

Permalink

Arturas Slajus added a comment - 15/Feb/12 1:48 AM

But that doesn't help in finding the error

Best behaviour would be to report correct line in file where evaled string was defined.

Show

Arturas Slajus added a comment - 15/Feb/12 1:48 AM But that doesn't help in finding the error Best behaviour would be to report correct line in file where evaled string was defined.

Hide

Permalink

Charles Oliver Nutter added a comment - 15/Feb/12 1:49 AM

Oddly enough, we appear to do this explicitly, and there are specs for the behavior:

  it "uses the filename of the binding if none is provided" do
    eval("__FILE__").should == "(eval)"
    eval("__FILE__", binding).should == __FILE__
    eval("__FILE__", binding, "success").should == "success"
    eval("eval '__FILE__', binding").should == "(eval)"
    eval("eval '__FILE__', binding", binding).should == __FILE__
    eval("eval '__FILE__', binding", binding, 'success').should == 'success'
  end

So basically, if you pass a binding, the file and line at the point where you called binding is used as the file and starting line number for any eval that uses it.

Binding#eval does take optional params for filename and line number, so if your code was binding.eval str, _FILE, __LINE_ it would reflect the actual file:line.

I agree the behavior is rather odd...and pretty much useless.

Show

Charles Oliver Nutter added a comment - 15/Feb/12 1:49 AM Oddly enough, we appear to do this explicitly, and there are specs for the behavior: it "uses the filename of the binding if none is provided" do eval("__FILE__").should == "(eval)" eval("__FILE__", binding).should == __FILE__ eval("__FILE__", binding, "success").should == "success" eval("eval '__FILE__', binding").should == "(eval)" eval("eval '__FILE__', binding", binding).should == __FILE__ eval("eval '__FILE__', binding", binding, 'success').should == 'success' end So basically, if you pass a binding, the file and line at the point where you called binding is used as the file and starting line number for any eval that uses it. Binding#eval does take optional params for filename and line number, so if your code was binding.eval str, _ FILE , __LINE _ it would reflect the actual file:line . I agree the behavior is rather odd...and pretty much useless.

Hide

Permalink

Charles Oliver Nutter added a comment - 15/Feb/12 1:51 AM

It's not possible to determine the file:line where a given string is created currently, which is why all Ruby eval calls take optional file and line params.

That workaround code above, this time without JIRA mangling:

binding.eval str, __FILE__, __LINE__

Show

Charles Oliver Nutter added a comment - 15/Feb/12 1:51 AM It's not possible to determine the file:line where a given string is created currently, which is why all Ruby eval calls take optional file and line params. That workaround code above, this time without JIRA mangling: binding.eval str, __FILE__, __LINE__

Hide

Permalink

Arturas Slajus added a comment - 15/Feb/12 1:57 AM

So you need to pass file and line around with string to eval to have correct line numbers when evaling it with the binding?

Show

Arturas Slajus added a comment - 15/Feb/12 1:57 AM So you need to pass file and line around with string to eval to have correct line numbers when evaling it with the binding?

Hide

Permalink

Arturas Slajus added a comment - 15/Feb/12 2:02 AM

Well, if str is defined somewhere else, i meant.

Makes sense, we can close this i suppose.

Although it would be fun if file and line would be used automatically if string is defined in same line. But probably hacky, non conforming to spec and not worgh implementing

Thanks for your time!

Show

Arturas Slajus added a comment - 15/Feb/12 2:02 AM Well, if str is defined somewhere else, i meant. Makes sense, we can close this i suppose. Although it would be fun if file and line would be used automatically if string is defined in same line. But probably hacky, non conforming to spec and not worgh implementing Thanks for your time!

People

Assignee:

Charles Oliver Nutter

Reporter:

Arturas Slajus

Vote (0)

Watch (1)

Dates

Created:

22/Jan/12 5:09 AM

Updated:

03/Aug/12 2:36 PM

Resolved:

15/Feb/12 4:30 PM