Details

    • Type: Bug Bug
    • Status: Resolved Resolved
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: JRuby 1.6.5
    • Fix Version/s: JRuby 1.7.0.pre1
    • Component/s: None
    • Labels:
      None
    • Number of attachments :
      2

      Description

      The ant task clean-all requires git to succeed:

      init:
      prepare-bin-jruby:
      clean:
      need-clean-ng:
      clean-ng:
      clean-tzdata:
           [echo] Reset joda-time jar
           [exec] Execute failed: java.io.IOException: Cannot run program "git": CreateProcess error=2, Das System kann die angegebene Datei nicht finden
      dist-clean:
      clear-specs:
      clean-all:
      BUILD SUCCESSFUL
      Total time: 578 milliseconds
      

      The same fix provided for JRUBY-5837 should be applied for running ant clean-all, i.e.:
      replace in build.xml, line 1783:

      <exec executable="git" failonerror="false" failifexecutionfails="false">
        <arg line="checkout -- ${build.lib.dir}/joda-time-${joda.time.version}.jar"/>
      </exec>
      

      by:

      <exec osfamily="unix" executable="/bin/sh" failonerror="false" failifexecutionfails="false">
        <arg line="-c 'git checkout -- ${build.lib.dir}/joda-time-${joda.time.version}.jar'"/>
      </exec>
      <exec osfamily="windows" executable="cmd" failonerror="false" failifexecutionfails="false">
        <arg line="/c git checkout -- ${build.lib.dir}/joda-time-${joda.time.version}.jar"/>
      </exec>
      
      1. JRUBY-6349.patch
        1 kB
        Jürgen Herzog
      2. JRUBY-6349.patch
        0.9 kB
        Jürgen Herzog

        Activity

        Hide
        Hiro Asari added a comment -

        Jürgen,

        Would you like to submit a git patch (ironic?) so that you can get the credit for the fix? Otherwise, I'll go ahead and make this change and credit you in the commit message.

        Show
        Hiro Asari added a comment - Jürgen, Would you like to submit a git patch (ironic?) so that you can get the credit for the fix? Otherwise, I'll go ahead and make this change and credit you in the commit message.
        Hide
        Jürgen Herzog added a comment -

        Hiro,

        this is the first time I'm reporting a bug, so I was looking for help on contributing to JRuby.
        The link "How to Contribute to JRuby Effectively" on https://github.com/jruby/jruby/wiki points to http://blog.emptyway.com/2008/03/27/how-to-contribute-to-jruby-effectively which is a page full of advertisement but no help!?

        Are there any instructions of how to submit a patch (I know how to produce the git patch itself).

        Jürgen

        Show
        Jürgen Herzog added a comment - Hiro, this is the first time I'm reporting a bug, so I was looking for help on contributing to JRuby. The link "How to Contribute to JRuby Effectively" on https://github.com/jruby/jruby/wiki points to http://blog.emptyway.com/2008/03/27/how-to-contribute-to-jruby-effectively which is a page full of advertisement but no help!? Are there any instructions of how to submit a patch (I know how to produce the git patch itself). Jürgen
        Hide
        Hiro Asari added a comment -

        Interesting. It looks like Vladimir's domain registration expired. I'll let him know.

        In the meantime, look http://blog.headius.com/2009/05/help-jruby-by-fixing-rubyspecs.html for some hints.

        Show
        Hiro Asari added a comment - Interesting. It looks like Vladimir's domain registration expired. I'll let him know. In the meantime, look http://blog.headius.com/2009/05/help-jruby-by-fixing-rubyspecs.html for some hints.
        Hide
        Jürgen Herzog added a comment - - edited

        Attached patch file for fixing JRUBY-6349

        Tested under Windows XP, but not under *nix.

        Show
        Jürgen Herzog added a comment - - edited Attached patch file for fixing JRUBY-6349 Tested under Windows XP, but not under *nix.
        Hide
        Hiro Asari added a comment -

        Jürgen,

        The attached patch doesn't have email address in it, so I can't merge it.

        Show
        Hiro Asari added a comment - Jürgen, The attached patch doesn't have email address in it, so I can't merge it.
        Hide
        Jürgen Herzog added a comment -

        I'm sorry:
        I followed the adive in http://blog.headius.com/2009/05/help-jruby-by-fixing-rubyspecs.html where Charles said "git diff" could be used to create a patch - which I did, ending up with no email address in it.
        I've attached a new version of the patch file created with "git format-patch -1".

        Show
        Jürgen Herzog added a comment - I'm sorry: I followed the adive in http://blog.headius.com/2009/05/help-jruby-by-fixing-rubyspecs.html where Charles said "git diff" could be used to create a patch - which I did, ending up with no email address in it. I've attached a new version of the patch file created with "git format-patch -1".
        Hide
        Hiro Asari added a comment - - edited

        Jürgen,

        Sorry about the trouble. I merged and pushed your fix to the master branch: 7e358cc

        Show
        Hiro Asari added a comment - - edited Jürgen, Sorry about the trouble. I merged and pushed your fix to the master branch: 7e358cc

          People

          • Assignee:
            Hiro Asari
            Reporter:
            Jürgen Herzog
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: