Details

    • Type: Bug Bug
    • Status: Resolved Resolved
    • Priority: Blocker Blocker
    • Resolution: Fixed
    • Affects Version/s: JRuby 1.6.5
    • Fix Version/s: JRuby 1.7.0.pre2
    • Component/s: Windows
    • Labels:
      None
    • Number of attachments :
      0

      Description

      WindowsHelpers.isBatch in jnr-posix has an off-by-one substring bug that's causing it to always return false. I ran across this when doing some debugging for JRUBY-5908. I marked the bug as minor priority because I haven't run across a Windows exec call that's impacted by this bug.

        Activity

        Hide
        Ben Browning added a comment -

        Pull request with fix and test - https://github.com/jnr/jnr-posix/pull/1

        Show
        Ben Browning added a comment - Pull request with fix and test - https://github.com/jnr/jnr-posix/pull/1
        Hide
        Charles Oliver Nutter added a comment -

        I pulled in the request, but we'll need to merge over to the version of jnr-posix that 1.6 uses and get releases of both. Leaving open and marking as blocker for 1.7 and 1.6.6.

        Show
        Charles Oliver Nutter added a comment - I pulled in the request, but we'll need to merge over to the version of jnr-posix that 1.6 uses and get releases of both. Leaving open and marking as blocker for 1.7 and 1.6.6.
        Hide
        Charles Oliver Nutter added a comment -

        I updated jruby/jnr-posix with the same patch in 6d4807f and updated jruby-1_6 jar in 6a85dd0. We still need releases of both, but patching is done.

        Show
        Charles Oliver Nutter added a comment - I updated jruby/jnr-posix with the same patch in 6d4807f and updated jruby-1_6 jar in 6a85dd0. We still need releases of both, but patching is done.
        Hide
        Thomas E Enebo added a comment -

        The code in question is currently not used by exec logic, so while it is good to correct it...it is not important for jruby release. Since this will end up in next jnr-posix release since it landed I am going to resolve.

        Show
        Thomas E Enebo added a comment - The code in question is currently not used by exec logic, so while it is good to correct it...it is not important for jruby release. Since this will end up in next jnr-posix release since it landed I am going to resolve.

          People

          • Assignee:
            Thomas E Enebo
            Reporter:
            Ben Browning
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: