JRuby

Colon is not allowed in a file name on Windows

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Blocker Blocker
  • Resolution: Fixed
  • Affects Version/s: None
  • Fix Version/s: JRuby 1.6.6, JRuby 1.7.0.pre1
  • Component/s: Windows
  • Labels:
    None
  • Environment:
    Windows
  • Number of attachments :
    0

Description

MRI 1.9 tests are added recently. Some files are skipped via excludes files in test/externals/ruby1.9/excludes, but those under Psych contain colons, which is problematic on Windows. (This prevents proper git operations on Windows.)

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Hiro Asari added a comment -

It appears to me that the problem lies with Psych's test structure. The test cases are inside Psych module, so in order for minitest to exclude them properly, the file name must contain colons.

I believe that we need to have Psych's tests restructured.

Show
Hiro Asari added a comment - It appears to me that the problem lies with Psych's test structure. The test cases are inside Psych module, so in order for minitest to exclude them properly, the file name must contain colons. I believe that we need to have Psych's tests restructured.
Hide
Permalink
Charles Oliver Nutter added a comment -

I think this actually needs to be fixed in minitest, since it prevents using excludes on nested test case classes when on Windows.

Added to my "excludes fixes" pull request (http://t.co/qaIQnVeF) and pushed a temporary fix to JRuby (http://t.co/1n6idoU1).

Show
Charles Oliver Nutter added a comment - I think this actually needs to be fixed in minitest, since it prevents using excludes on nested test case classes when on Windows. Added to my "excludes fixes" pull request ( http://t.co/qaIQnVeF ) and pushed a temporary fix to JRuby ( http://t.co/1n6idoU1 ).
Hide
Permalink
Nick Klauer added a comment -

Checking out jruby/master works for me with this patched, so hopefully this (or something like it) makes it into minitest.

Show
Nick Klauer added a comment - Checking out jruby/master works for me with this patched, so hopefully this (or something like it) makes it into minitest.
Hide
Permalink
Hiro Asari added a comment -

Charlie, looks like minitest settled on / as the separator. What's left to do?

Show
Hiro Asari added a comment - Charlie, looks like minitest settled on / as the separator. What's left to do?
Hide
Permalink
Hiro Asari added a comment -

This was fixed with 7f33fe4 on master.

Show
Hiro Asari added a comment - This was fixed with 7f33fe4 on master.

People

  • Assignee:
    Charles Oliver Nutter
    Reporter:
    Hiro Asari
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: