JRuby

IBM JVM rejects class/method names with #, as in our JIT recently.

Details

  • Type: Bug Bug
  • Status: Resolved Resolved
  • Priority: Blocker Blocker
  • Resolution: Fixed
  • Affects Version/s: JRuby 1.6.5
  • Fix Version/s: JRuby 1.7.0.pre2
  • Component/s: Compiler
  • Labels:
    None
  • Number of attachments :
    0

Description

A recent change to both master and 1.6 branches modified the jitted class name to be of the form class#method, to provide better information in stack traces. Unfortunately, on IBM JVMs, the # method among others are rejected. This means that since this change, our JIT has been unable to load any jitted methods' classes.

This must be addressed before any 1.6.6 or 1.7 release.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Charles Oliver Nutter added a comment -

Remarking for 1.7. I'm not comfortable trying to change around jitted methods' class names this late into 1.6.6, and since we have only a handful of IBM users this is probably not worth the risk. We'll do it in 1.7.

Show
Charles Oliver Nutter added a comment - Remarking for 1.7. I'm not comfortable trying to change around jitted methods' class names this late into 1.6.6, and since we have only a handful of IBM users this is probably not worth the risk. We'll do it in 1.7.
Hide
Permalink
Matt Hauck added a comment -

Add one more to the list of IBM JRE users =)

Show
Matt Hauck added a comment - Add one more to the list of IBM JRE users =)
Hide
Permalink
Charles Oliver Nutter added a comment -

My sincerest apologies I'll fix it before 1.7 final.

Show
Charles Oliver Nutter added a comment - My sincerest apologies I'll fix it before 1.7 final.
Hide
Permalink
Charles Oliver Nutter added a comment - 
commit 1ead6fa04d93cd8d96667cedc16e7928c7de34a6
Author: Charles Oliver Nutter <headius@headius.com>
Date:   Thu Aug 2 23:21:42 2012 -0500

    Fix JRUBY-6253
    
    IBM JVM rejects class/method names with #, as in our JIT recently.
    
    Use $$ instead of # to delimit class name from method name.

:100644 100644 28f750e... 7b3e4e0... M	src/org/jruby/compiler/JITCompiler.java
:100644 100644 38fac67... e7e8bd0... M	src/org/jruby/runtime/backtrace/BacktraceData.java
Show
Charles Oliver Nutter added a comment - commit 1ead6fa04d93cd8d96667cedc16e7928c7de34a6 Author: Charles Oliver Nutter <headius@headius.com> Date: Thu Aug 2 23:21:42 2012 -0500 Fix JRUBY-6253 IBM JVM rejects class/method names with #, as in our JIT recently. Use $$ instead of # to delimit class name from method name. :100644 100644 28f750e... 7b3e4e0... M src/org/jruby/compiler/JITCompiler.java :100644 100644 38fac67... e7e8bd0... M src/org/jruby/runtime/backtrace/BacktraceData.java
Hide
Permalink
Matt Hauck added a comment -

Sweet! =)

Show
Matt Hauck added a comment - Sweet! =)

People

  • Assignee:
    Charles Oliver Nutter
    Reporter:
    Charles Oliver Nutter
Vote (2)
Watch (4)

Dates

  • Created:
    Updated:
    Resolved: