Details
-
Type:
Bug
-
Status:
Closed
-
Priority:
Major
-
Resolution: Fixed
-
Affects Version/s: None
-
Fix Version/s: JRuby 1.6.6, JRuby 1.7.0.pre1
-
Component/s: None
-
Labels:None
-
Patch Submitted:Yes
-
Number of attachments :
Description
Hello,
This is my first patch to JRuby, so please be teach me where I'm wrong.
I noticed Struct.members return an Array of Strings, even in 1.9.
A patch is attached, it removes the RubySpec tag which was "hiding" this issue.
I'm unsure if the duplication between members18 and members19 is fine, but as it is mostly a loop, it's probably fine.
I used the members18 method in unmarshalFrom(), maybe using the 19 version would be faster since it does not require to convert members to ruby Strings?
Hope it helps,
Benoit Daloze
Benoit,
Thanks for the patch. In general, we don't put the suffix '18' for methods in the 1.8 mode. This is making your patch noisier than necessary, I believe.