JRuby

bad gem file creation using mode --1.9

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Critical Critical
  • Resolution: Fixed
  • Affects Version/s: JRuby 1.6.5
  • Fix Version/s: JRuby 1.6.6, JRuby 1.6.7
  • Component/s: Ruby 1.9.2
  • Labels:
    None
  • Environment:
    ubuntu 10.4
  • Number of attachments :
    0

Description

With JRuby 1.6.5 using mode --1.9 (rake I've found that, when building my gems, the execution of the rake task gem creates a bad file where the data.tar.gz component is corrupted.
The same problem is present in other gems like net-ssh:

$ cd net-ssh-2.2.1

$ rake gem

$ gem unpack pkg/net-ssh-2.2.1.gem
ERROR:  While executing gem ... (Errno::EISDIR)
    Is a directory - Is a directory

$ tar xf pkg/net-ssh-2.2.1.gem
tar: data.tar.gz: implausibly old time stamp 1970-01-01 01:00:00
tar: metadata.gz: implausibly old time stamp 1970-01-01 01:00:00

$ tar tvfz data.tar.gz 
-rw-r--r-- wheel/wheel    8455 1970-01-01 01:00 CHANGELOG.rdoc
tar: Skipping to next header
tar: Exiting with failure status due to previous errors

Using --1.8 mode or JRuby 1.6.4 (any mode) the gem file produced is correct.
I'm using rake 0.9.2.2 but I've tried with 0.8.7 and got the same error.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Peter Lane added a comment -

This seems the same as a problem I am having building gems in --1.9 mode.

The problem arises when I include a jar file within my gem.

Building in 1.9 mode is fine, but installation gives the same error as in the report above. (Within the gem file, data.tar.gz is corrupted, as reported above.) The gem builds and installs fine in 1.8 mode.

$ jruby --1.9 -S gem build svm_toolkit.gemspec
Successfully built RubyGem
Name: svm_toolkit
Version: 0.0.5
File: svm_toolkit-0.0.5-universal-java-1.6.gem

$ jruby --1.9 -S gem install svm_toolkit-0.0.5-universal-java-1.6.gem
ERROR: While executing gem ... (Errno::EISDIR)
Is a directory - Is a directory

(jruby 1.6.5, ubuntu 11.04, java 6)

Show
Peter Lane added a comment - This seems the same as a problem I am having building gems in --1.9 mode. The problem arises when I include a jar file within my gem. Building in 1.9 mode is fine, but installation gives the same error as in the report above. (Within the gem file, data.tar.gz is corrupted, as reported above.) The gem builds and installs fine in 1.8 mode. $ jruby --1.9 -S gem build svm_toolkit.gemspec Successfully built RubyGem Name: svm_toolkit Version: 0.0.5 File: svm_toolkit-0.0.5-universal-java-1.6.gem $ jruby --1.9 -S gem install svm_toolkit-0.0.5-universal-java-1.6.gem ERROR: While executing gem ... (Errno::EISDIR) Is a directory - Is a directory (jruby 1.6.5, ubuntu 11.04, java 6)
Hide
Permalink
Charles Oliver Nutter added a comment -

Confirmed on jruby-1_6 branch with my "weakling" gem:

system ~/projects/weakling $ jruby --1.9 -S gem build weakling.gemspec 
WARNING:  description and summary are identical
  Successfully built RubyGem
  Name: weakling
  Version: 0.0.4
  File: weakling-0.0.4-java.gem

system ~/projects/weakling $ gem install weakling-0.0.4-java.gem 
ERROR:  While executing gem ... (Errno::EISDIR)
    Is a directory - Is a directory
Show
Charles Oliver Nutter added a comment - Confirmed on jruby-1_6 branch with my "weakling" gem: system ~/projects/weakling $ jruby --1.9 -S gem build weakling.gemspec WARNING: description and summary are identical Successfully built RubyGem Name: weakling Version: 0.0.4 File: weakling-0.0.4-java.gem system ~/projects/weakling $ gem install weakling-0.0.4-java.gem ERROR: While executing gem ... (Errno::EISDIR) Is a directory - Is a directory
Hide
Permalink
Charles Oliver Nutter added a comment -

This appears to be a regression from 1.6.4 to 1.6.5. I suspect it is related to Nahi's changes to support streaming gzip. Nahi, can you look into this?

Show
Charles Oliver Nutter added a comment - This appears to be a regression from 1.6.4 to 1.6.5. I suspect it is related to Nahi's changes to support streaming gzip. Nahi, can you look into this?
Hide
Permalink
Hiroshi Nakamura added a comment -

I'll investigate it. Give me 12 hours or so.

Show
Hiroshi Nakamura added a comment - I'll investigate it. Give me 12 hours or so.
Hide
Permalink
Hiroshi Nakamura added a comment -

I confirmed the problem, too. JRuby 1.6.5 + 1.9 mode creates corrupted tarball. Still investigating...

Show
Hiroshi Nakamura added a comment - I confirmed the problem, too. JRuby 1.6.5 + 1.9 mode creates corrupted tarball. Still investigating...
Hide
Permalink
Hiroshi Nakamura added a comment -

GzipWriter created corrupted gzip stream for binary data.

commit 80a11b9a0078e364b81057836c588b5021f03e7a
Author: Hiroshi Nakamura <nahi@ruby-lang.org>
Date:   Fri Nov 18 13:49:25 2011 +0900

    JRUBY-6208: GzipWriter creates corrupted gzip stream for binary data
    
    default_external for GzipWriter IO stream is not specified by default.

Fixed master at 80a11b9a0078e364b81057836c588b5021f03e7a and jruby-1_6 at 8a582fe2fed9a30f2cd64e05b2cecb5a247187ea.

Guys, would you please confirm this fix solves your problem? Charles' weakling gem including Jar file now properly untar-ed for me.

Show
Hiroshi Nakamura added a comment - GzipWriter created corrupted gzip stream for binary data. commit 80a11b9a0078e364b81057836c588b5021f03e7a Author: Hiroshi Nakamura <nahi@ruby-lang.org> Date: Fri Nov 18 13:49:25 2011 +0900 JRUBY-6208: GzipWriter creates corrupted gzip stream for binary data default_external for GzipWriter IO stream is not specified by default. Fixed master at 80a11b9a0078e364b81057836c588b5021f03e7a and jruby-1_6 at 8a582fe2fed9a30f2cd64e05b2cecb5a247187ea. Guys, would you please confirm this fix solves your problem? Charles' weakling gem including Jar file now properly untar-ed for me.
Hide
Permalink
Peter Lane added a comment -

Thank you, this has fixed the problem for me. Gems building and installing correctly in both 1.8 and 1.9 mode.

Show
Peter Lane added a comment - Thank you, this has fixed the problem for me. Gems building and installing correctly in both 1.8 and 1.9 mode.
Hide
Permalink
Hiroshi Nakamura added a comment -

Thanks for confirmation. Closing as 'Resolved'.

I'm sorry but I cannot find a workaround for 1.6.5. Please use self build version of jruby-1_6 until 1.6.6 will be released...

Show
Hiroshi Nakamura added a comment - Thanks for confirmation. Closing as 'Resolved'. I'm sorry but I cannot find a workaround for 1.6.5. Please use self build version of jruby-1_6 until 1.6.6 will be released...
Hide
Permalink
Hiroshi Nakamura added a comment -

Current master/jruby-1_6 have this bug again. The fix could be reverted somewhere.

See how spec/regression/JRUBY-6208_gzip_bin_write_spec.rb fails.

Show
Hiroshi Nakamura added a comment - Current master/jruby-1_6 have this bug again. The fix could be reverted somewhere. See how spec/regression/ JRUBY-6208 _gzip_bin_write_spec.rb fails.
Hide
Permalink
Hiroshi Nakamura added a comment -

I was wrong. This test is wrong but the bug in master/jruby-1_6 seems to be different issue.

I'll keep this bug open to fix the test.

Show
Hiroshi Nakamura added a comment - I was wrong. This test is wrong but the bug in master/jruby-1_6 seems to be different issue. I'll keep this bug open to fix the test.
Hide
Permalink
Hiroshi Nakamura added a comment - 
commit d3f71e89b42a3bfaf7b76896a93cf9c42cd67fa7
Author: Hiroshi Nakamura <nahi@ruby-lang.org>
Date:   Mon Feb 20 18:02:47 2012 +0900

    Refix JRUBY-6208: GzipWriter#write should honor writeEncoding, not readEncoding
    
    Title says all.  The regression spec I added before wrongly used
    GzipReader#read() without size parameter.  GzipReader#read() uses the
    specified read encoding (it is Encoding.default_external if not
    specified) and it hides this bug.
Show
Hiroshi Nakamura added a comment - commit d3f71e89b42a3bfaf7b76896a93cf9c42cd67fa7 Author: Hiroshi Nakamura <nahi@ruby-lang.org> Date: Mon Feb 20 18:02:47 2012 +0900 Refix JRUBY-6208: GzipWriter#write should honor writeEncoding, not readEncoding Title says all. The regression spec I added before wrongly used GzipReader#read() without size parameter. GzipReader#read() uses the specified read encoding (it is Encoding.default_external if not specified) and it hides this bug.
Hide
Permalink
Hiroshi Nakamura added a comment -

Cherry-picked to jruby-1_6. 1.6.7 should work fine as well as 1.6.6.

Show
Hiroshi Nakamura added a comment - Cherry-picked to jruby-1_6. 1.6.7 should work fine as well as 1.6.6.

People

  • Assignee:
    Hiroshi Nakamura
    Reporter:
    Giovanni Cristelli
Vote (0)
Watch (3)

Dates

  • Created:
    Updated:
    Resolved: