JRuby

SSH Agent forwarding does not work with jRuby (which lets capistrano ssh-deployments fail)

Details

  • Type: Bug Bug
  • Status: Resolved Resolved
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: None
  • Fix Version/s: JRuby 1.7.0.pre2
  • Component/s: OpenSSL
  • Labels:
    None
  • Environment:
    Jruby-1.6.5
  • Testcase included:
    yes
  • Number of attachments :
    4

Description

Unfortunately, the agent forwarding option seems to fail using jRuby.
Capistrano deployments won't work if you're using ssh transport for git in combination with agent forwarding.
The connection simply hangs.

Attached you'll find a simple case which works in MRI and hangs in jRuby.

Best,

Tobias

  1. File
    jruby_1_7_pre2_dev_net_ssh_test.dump
    26/Jul/12 2:34 PM
    17 kB
    Frazer
  2. Text File
    jruby-6181-trace.txt
    05/May/12 11:31 AM
    330 kB
    Kevin Menard
  3. File
    test.rb
    05/Nov/11 1:24 PM
    0.2 kB
    Tobias Schlottke
  4. File
    threaddump-1320528062126.tdump
    05/Nov/11 7:02 PM
    25 kB
    Hiro Asari

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Hiro Asari added a comment -

Thread dump of the hung process.

Show
Hiro Asari added a comment - Thread dump of the hung process.
Hide
Permalink
Tobias Schlottke added a comment -

IMHO this bug is even critical because it makes deploying git apps via capistrano almost impossible.
How are you guys doing this and why did nobody ever realize it?

Show
Tobias Schlottke added a comment - IMHO this bug is even critical because it makes deploying git apps via capistrano almost impossible. How are you guys doing this and why did nobody ever realize it?
Hide
Permalink
Nicholas Cancelliere added a comment -

I've encountered this issue as well. Deploying with the ssh_forward option turned on for Capistrano causes the deployment to hang. Using a non-JRuby (1.9.2 MRI) it works fine. Turning off ssh_forward doesn't hang, but then doesn't really do what I need to for deployments (since we rely on the ssh_forward stuff).

Show
Nicholas Cancelliere added a comment - I've encountered this issue as well. Deploying with the ssh_forward option turned on for Capistrano causes the deployment to hang. Using a non-JRuby (1.9.2 MRI) it works fine. Turning off ssh_forward doesn't hang, but then doesn't really do what I need to for deployments (since we rely on the ssh_forward stuff).
Hide
Permalink
Hiroshi Nakamura added a comment -

Thanks for the dump. The net/ssh client seems to be waiting for a response from the server.

Can someone run JRuby with -d and -Xbacktrace.style=raw to see more detail about what's happening inside?

Show
Hiroshi Nakamura added a comment - Thanks for the dump. The net/ssh client seems to be waiting for a response from the server. Can someone run JRuby with -d and -Xbacktrace.style=raw to see more detail about what's happening inside?
Hide
Permalink
Hiroshi Nakamura added a comment -

Removing me from Assignee because I don't have an environment now. I would be able to take this again when logs/traces are provided.

Show
Hiroshi Nakamura added a comment - Removing me from Assignee because I don't have an environment now. I would be able to take this again when logs/traces are provided.
Hide
Permalink
Kevin Menard added a comment -

Here's a trace running JRuby 1.6.7 in 1.9 mode with Capistrano 2.12.0. I have the same problem with using 1.7.0-dev.

Show
Kevin Menard added a comment - Here's a trace running JRuby 1.6.7 in 1.9 mode with Capistrano 2.12.0. I have the same problem with using 1.7.0-dev.
Hide
Permalink
Kevin Menard added a comment -

I think JRUBY-5868 may be related as well.

Show
Kevin Menard added a comment - I think JRUBY-5868 may be related as well.
Hide
Permalink
Frazer added a comment -

Wondering if there is enough information (logs/traces) for this now to move forward and get this resolved?

Show
Frazer added a comment - Wondering if there is enough information (logs/traces) for this now to move forward and get this resolved?
Hide
Permalink
Charles Oliver Nutter added a comment -

Poking this with a stick today.

Show
Charles Oliver Nutter added a comment - Poking this with a stick today.
Hide
Permalink
Charles Oliver Nutter added a comment -

The thread dump by Hiro seems to involve UNIXSocket, not SSLSocket.

The trace by Kevin Menard does not show a lot of information. Can you re-run it and then use Ctrl+\ to get a thread dump?

I attempted to run the posted test.rb script and it gets to the point of prompting me for my private key passcode and is unable to proceed further. Does this mean I've gotten past the problem or does it mean I never reached it?

Can someone try with a JRuby 1.7 nightly? http://ci.jruby.org/snapshots/master

I have no way to reproduce or investigate this. I don't know how to set up SSH forwarding.

Show
Charles Oliver Nutter added a comment - The thread dump by Hiro seems to involve UNIXSocket, not SSLSocket. The trace by Kevin Menard does not show a lot of information. Can you re-run it and then use Ctrl+\ to get a thread dump? I attempted to run the posted test.rb script and it gets to the point of prompting me for my private key passcode and is unable to proceed further. Does this mean I've gotten past the problem or does it mean I never reached it? Can someone try with a JRuby 1.7 nightly? http://ci.jruby.org/snapshots/master I have no way to reproduce or investigate this. I don't know how to set up SSH forwarding.
Hide
Permalink
Kevin Menard added a comment -

I'm unable to reproduce the issue with the latest 1.7 nightly (2012-07-26 16d6869).

Show
Kevin Menard added a comment - I'm unable to reproduce the issue with the latest 1.7 nightly (2012-07-26 16d6869).
Hide
Permalink
Charles Oliver Nutter added a comment -

Huzzah!

Show
Charles Oliver Nutter added a comment - Huzzah!
Hide
Permalink
Frazer added a comment -

Hmm, Im still having an issue. Maybe I'm missing something. Attached dump.

Show
Frazer added a comment - Hmm, Im still having an issue. Maybe I'm missing something. Attached dump.
Hide
Permalink
Kevin Menard added a comment -

Frazer, I wonder if your issue might be JDK 6 vs JDK 7. I've run into weird issues with JDK 6 blocking indefinitely in PKCS stuff outside of JRuby.

Show
Kevin Menard added a comment - Frazer, I wonder if your issue might be JDK 6 vs JDK 7. I've run into weird issues with JDK 6 blocking indefinitely in PKCS stuff outside of JRuby.
Hide
Permalink
Frazer added a comment -

Ah, thanks Kevin, I wouldn't mind betting thats it. I'll give 7 a shot.

Show
Frazer added a comment - Ah, thanks Kevin, I wouldn't mind betting thats it. I'll give 7 a shot.

People

  • Assignee:
    Charles Oliver Nutter
    Reporter:
    Tobias Schlottke
Vote (7)
Watch (9)

Dates

  • Created:
    Updated:
    Resolved: