JRuby

Requiring a file from a JAR that has a path inside the JAR that coincides with a path on the file system that includes a symlink fails

Details

  • Number of attachments :
    2

Description

It all boils down to org.jruby.runtime.load.LoadService#expandRelativeJarPath using File#getCanonicalPath to expand the JAR entry path. A quick fix is to change expandRelativeJarPath like this:

    private String expandRelativeJarPath(String path) {
        return path.replaceAll("/[^/]+/\\.\\.|[^/]+/\\.\\./|\\./","").replace("^\\\\","/");
    }

This passes all existing tests and fixes the problem. I can add a test and submit a patch if desired.

Activity

Ascending order - Click to sort in descending order
Uwe Kubosch made changes -
Field Original Value New Value
Attachment 0001-JRUBY-6172-Avoid-using-getCanonicalPath-to-expand-JA.patch [ 57536 ]
Uwe Kubosch made changes -
Attachment 0001-JRUBY-6172-Avoid-using-getCanonicalPath-to-expand-JA.patch [ 57536 ]
Uwe Kubosch made changes -
Attachment 0001-JRUBY-6172-Avoid-using-getCanonicalPath-to-expand-JA.patch [ 57541 ]
Hiro Asari made changes -
Assignee Hiro Asari [ asari ]
Uwe Kubosch made changes -
Attachment 0001-JRUBY-6172-Test.patch [ 57572 ]
Uwe Kubosch made changes -
Attachment 0001-JRUBY-6172-Test.patch [ 57572 ]
Uwe Kubosch made changes -
Attachment 0001-JRUBY-6172-Test.patch [ 57585 ]
Hiro Asari made changes -
Status Open [ 1 ] Resolved [ 5 ]
Resolution Fixed [ 1 ]
Uwe Kubosch made changes -
Resolution Fixed [ 1 ]
Status Resolved [ 5 ] Reopened [ 4 ]
Hiro Asari made changes -
Status Reopened [ 4 ] Resolved [ 5 ]
Resolution Fixed [ 1 ]
Charles Oliver Nutter made changes -
Status Resolved [ 5 ] Closed [ 6 ]

People

  • Assignee:
    Hiro Asari
    Reporter:
    Uwe Kubosch
Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved: