Errors on String#lines

I see the same error with Capistrano 2.8.0 and 2.9.0 using jruby-1.6.4 (ruby-1.9.2-p136) and jruby-1.6.5.dev (ruby-1.9.2-p136).

I see the same error with Capistrano 2.8.0 and 2.9.0 using jruby-1.6.4 (ruby-1.9.2-p136) and jruby-1.6.5.dev (ruby-1.9.2-p136).

I've built off of jruby-1_6 latest and still have this error. If anyone has any suggestions on avenues of investigation please let me know (I've never debugged jruby)

What does message look like when JRuby throws AIOOBE?

So I stepped through the code and this is what I found...

in each_lineCommon19(ThreadContext context, IRubyObject sep, Block block)...

 if (sepStr == runtime.getGlobalVariables().getDefaultSeparator()) {
            enc = val.getEncoding();
            while (p < end) {
                if (bytes[p] == (byte)'\n') {
                    int p0 = enc.leftAdjustCharHead(bytes, s, p, end);
                    if (enc.isNewLine(bytes, p0, end)) {
                        p = p0 + StringSupport.length(enc, bytes, p0, end);
                        block.yield(context, makeShared19(runtime, val, s, p - s).infectBy(this));
                        s = p;
                        continue;
                    }
                }
                p++;
            }
        } else {

At the start of this method my string is correct. The value bytelist has a length of about 50, begin is 14 and length is 22, and I can confirm that the byte array from 14-35 matches my expected string.

That call to makeshared19 is going to end up calling ByteList.makeShared, which uses the index value as an offset, which ends up giving me a string with a 'begin' value that is way too high and causes an array out of bounds exception.

Hope this helps. Let me know if there is anything else I can do. Not sure how to recreate a simple test case since this looks like it depends on the 'value' ByteArray in RubyString, and not the ruby String its representing.

I was able to create a very simple test case. This script will fail

message = "something%sh: gimme: not found\r\n"
message = message.split('%')[1]

message.lines do |line|
  puts line # fails
  # puts line.strip # also fails
end

Also worth noting that this can cause problems other than crashing.

https://gist.github.com/1279334

I've attached a patch (off jruby-1_6) with what I'm currently using to resolve it however I can't get the tests to run on windows for 1.6.4 or 1.6.latest. (I also think there is a more elegant solution but it would involve rewriting more of each_lineCommon19). The examples in this ticket should serve as a basis for some tests.

I'm curious if any other string functions break when bytelist.begin isn't 0. I may look into this if I have time.

Applied your patch in 6e7fb9c on master and 00a9a6b on jruby-1_6. If you have any desire cleaning up this ugly method then please go for it! Thanks for the patch too.