JRuby

Fix for JRUBY-5965 breaks Mirah macro compilation

Details

  • Type: Bug Bug
  • Status: Resolved Resolved
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: JRuby 1.6.4
  • Fix Version/s: JRuby 1.7.0.pre1
  • Component/s: None
  • Labels:
    None
  • Number of attachments :
    0

Description

3c6a6a2a12daed2023a3701cface860cf35d6c29 changed JavaClass#handleScalaSingletons() in such a way that mirah Macros no longer compile correctly.

Cross-reference: https://github.com/mirah/mirah/issues/144

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Nick Howard added a comment -

It may also be related to this issue with 1.6.4 on Google Appengine. http://groups.google.com/group/appengine-jruby/browse_thread/thread/9dae8ddbe1d1a403?hl=en

Show
Nick Howard added a comment - It may also be related to this issue with 1.6.4 on Google Appengine. http://groups.google.com/group/appengine-jruby/browse_thread/thread/9dae8ddbe1d1a403?hl=en
Hide
Permalink
Nick Howard added a comment - - edited

from doing some poking around, it looks like when JavaClass gets the ClassNotFoundException, it's wrapped with a RaiseException.

Show
Nick Howard added a comment - - edited from doing some poking around, it looks like when JavaClass gets the ClassNotFoundException, it's wrapped with a RaiseException.
Hide
Permalink
Brendan Ribera added a comment -

Handling RaiseException fixes the Mirah issues. Pull request: https://github.com/jruby/jruby/pull/72

Show
Brendan Ribera added a comment - Handling RaiseException fixes the Mirah issues. Pull request: https://github.com/jruby/jruby/pull/72
Hide
Permalink
Tobias Crawley added a comment -

I submitted a pull request that restores blanket catching, since that should resolve the issue in JRUBY-6058 as well. https://github.com/jruby/jruby/pull/89

Show
Tobias Crawley added a comment - I submitted a pull request that restores blanket catching, since that should resolve the issue in JRUBY-6058 as well. https://github.com/jruby/jruby/pull/89
Hide
Permalink
Hiro Asari added a comment -

I merged Toby's patch in https://github.com/jruby/jruby/commit/d2f2686

Show
Hiro Asari added a comment - I merged Toby's patch in https://github.com/jruby/jruby/commit/d2f2686

People

  • Assignee:
    Hiro Asari
    Reporter:
    Brendan Ribera
Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved: