Details

    • Type: Bug Bug
    • Status: Resolved Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: JRuby 1.6.4
    • Fix Version/s: JRuby 1.7.0.RC1
    • Component/s: None
    • Labels:
      None
    • Environment:
      OSX Lion
    • Number of attachments :
      0

      Description

      In the postfligh script the lines added in the tcsh shell case has a syntax error
      the syntax should be one of

      set path = ($path /usr/X11R6/bin /Library/Frameworks/JRuby.framework/Versions/Current/bin
      

      or

      setenv PATH ${PATH}:/Library/Frameworks/JRuby.framework/Versions/Current/bin
      

      Also it could be possible to have a login shell different from the one used by Terminal (as a default)
      in that case the shell detection doesn't patch the proper profile (should it patch all founded shell under user ~. directory?)

      in my case to make it work I added the proper line to the .bash/path according to postflight script
      and added a line into the .login loaded by tcsh
      and jruby work in both shell.

      Edit (headius): The file in question is at https://github.com/jruby/jruby-mac-installer/blob/master/scripts/installer.postflight.erb

        Activity

        Hide
        Charles Oliver Nutter added a comment -

        Is there a patch you can provide that will solve this? I'm not quite clear on what we need to change...

        Show
        Charles Oliver Nutter added a comment - Is there a patch you can provide that will solve this? I'm not quite clear on what we need to change...
        Hide
        Vincent Nonnenmacher added a comment - - edited

        I have no patch as I'm not confident on the various shell.
        But you should check not to use bash only instructions as
        the old tcsh default shell is still there for people that
        don't switched to the default bash shell.

        In my case, I need to explicitly specify that I want bash
        shell as during the upgrade my login was kept to default tsch.

        I also know some mac programers who prefer zsh, so you'd
        better keep your global path setting using only sh instructions
        or check the current shell and add the JRuby path accordingly.

        Show
        Vincent Nonnenmacher added a comment - - edited I have no patch as I'm not confident on the various shell. But you should check not to use bash only instructions as the old tcsh default shell is still there for people that don't switched to the default bash shell. In my case, I need to explicitly specify that I want bash shell as during the upgrade my login was kept to default tsch. I also know some mac programers who prefer zsh, so you'd better keep your global path setting using only sh instructions or check the current shell and add the JRuby path accordingly.
        Show
        Charles Oliver Nutter added a comment - What do you think of this patch: https://github.com/larzconwell/jruby-mac-installer/commit/f42bba6f8ee3ea330f33a72d2559a28af37236b5
        Show
        Charles Oliver Nutter added a comment - Pull Request: https://github.com/jruby/jruby-mac-installer/pull/1
        Hide
        Vincent Nonnenmacher added a comment -

        sound fine to me, however (and I admit I hate shell scripting, so I'm not an expert at any length)
        my .tcshrc don't contain path patchs, they are all contained in the ~/.login file

        (here is a link that explain the sourcing of .login before .cshrc : http://www.acm.uiuc.edu/workshops/cool_unix/tcsh-startup.html)

        But your patch should work (beside it would path also other shells like .zsh)

        Show
        Vincent Nonnenmacher added a comment - sound fine to me, however (and I admit I hate shell scripting, so I'm not an expert at any length) my .tcshrc don't contain path patchs, they are all contained in the ~/.login file (here is a link that explain the sourcing of .login before .cshrc : http://www.acm.uiuc.edu/workshops/cool_unix/tcsh-startup.html ) But your patch should work (beside it would path also other shells like .zsh)
        Hide
        Charles Oliver Nutter added a comment -

        PR merged; the installer will incorporate it for 1.7RC1.

        Show
        Charles Oliver Nutter added a comment - PR merged; the installer will incorporate it for 1.7RC1.

          People

          • Assignee:
            Charles Oliver Nutter
            Reporter:
            Vincent Nonnenmacher
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: