JRuby (please use github issues at http://bugs.jruby.org)
  1. JRuby (please use github issues at http://bugs.jruby.org)
  2. JRUBY-5965

JavaClass#handleScalaSingletons() raises & catches hundreds of unnecessary NPEs

    Details

    • Type: Improvement Improvement
    • Status: Closed Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: JRuby 1.6.3
    • Fix Version/s: JRuby 1.6.4
    • Component/s: None
    • Labels:
      None
    • Patch Submitted:
      Yes
    • Number of attachments :
      0

      Description

      It assumes every class has a classloader, which isn't the case for core Java classes on all VMs. Since it catches and ignores any exception in an effort to blanket catch introspection exceptions, the NPEs were not noticed.

      I'll submit a pull request.

        Activity

        Hide
        Tobias Crawley added a comment -
        Show
        Tobias Crawley added a comment - Pull request submitted: https://github.com/jruby/jruby/pull/55
        Hide
        Charles Oliver Nutter added a comment -

        Merged into master at 3524733 and into jruby-1_6 at 3c6a6a2. Great find!

        Show
        Charles Oliver Nutter added a comment - Merged into master at 3524733 and into jruby-1_6 at 3c6a6a2. Great find!

          People

          • Assignee:
            Charles Oliver Nutter
            Reporter:
            Tobias Crawley
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: