JRuby

make JAVA_VM to be set from environment

Details

  • Type: Improvement Improvement
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: None
  • Fix Version/s: JRuby 1.6.3, JRuby 1.7.0.pre1
  • Component/s: None
  • Labels:
    None
  • Environment:
    $ java -version
    java version "1.6.0_22"
    OpenJDK Runtime Environment (IcedTea6 1.10.1) (6b22-1.10.1-0ubuntu1)
    OpenJDK 64-Bit Server VM (build 20.0-b11, mixed mode)
  • Number of attachments :
    0

Description

ubuntu 11.04 comes with IcedTea6 which allows to choose between -client -cacao and -jamvm runtime environment and I found jamvm gives a second better startup which is a lot for these small commandline tools.

a little patch in the jruby executable would allow me to configure it for my user account:

— jruby~ 2010-04-03 17:32:00.000000000 +0530
+++ jruby 2011-05-27 00:13:51.088072014 +0530
@@ -155,5 +155,8 @@
fi

-JAVA_VM=-client
+if [ -z "$JAVA_VM" ] ; then
+ JAVA_VM=-client
+fi
+
JAVA_ENCODING=""

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Hiro Asari added a comment -

How did you get the line number so high? I'm guessing that the line you want is https://github.com/jruby/jruby/blob/217fc9b11588d6d10cc01d6b518ec4622043b4cc/bin/jruby.bash#L23 but the context doesn't match up.

Am I missing something?

Show
Hiro Asari added a comment - How did you get the line number so high? I'm guessing that the line you want is https://github.com/jruby/jruby/blob/217fc9b11588d6d10cc01d6b518ec4622043b4cc/bin/jruby.bash#L23 but the context doesn't match up. Am I missing something?
Hide
Permalink
kristian meier added a comment -

indeed the jruby.bash looks quite different from the jruby have in my bin. did not realize that jruby is not in git.

L23 is the place to change. sorry for the confusion.

Show
kristian meier added a comment - indeed the jruby.bash looks quite different from the jruby have in my bin. did not realize that jruby is not in git. L23 is the place to change. sorry for the confusion.
Hide
Permalink
Hiro Asari added a comment -

Pushed the fix to master (a21339a) and 1.6 branch (509564f).

Show
Hiro Asari added a comment - Pushed the fix to master (a21339a) and 1.6 branch (509564f).

People

  • Assignee:
    Hiro Asari
    Reporter:
    kristian meier
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: