JRuby

RubySpec: String#scan failures

Details

  • Number of attachments :
    1
  1. Text File
    fix_5665.patch
    19/May/11 10:45 AM
    0.9 kB
    Brian Browning

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Charles Oliver Nutter added a comment - 
1)
String#scan taints the results if the String argument is tainted FAILED
Expected false to be true
/Users/headius/projects/jruby/spec/ruby/core/string/scan_spec.rb:80:in `(root)'
org/jruby/RubyArray.java:1572:in `each'
/Users/headius/projects/jruby/spec/ruby/core/string/scan_spec.rb:80:in `(root)'
org/jruby/RubyKernel.java:2007:in `instance_eval'
org/jruby/RubyEnumerable.java:1262:in `all?'
org/jruby/RubyArray.java:1572:in `each'
/Users/headius/projects/jruby/spec/ruby/core/string/scan_spec.rb:5:in `(root)'
org/jruby/RubyKernel.java:1062:in `load'
/Users/headius/projects/jruby/spec/ruby/core/string/scan_spec.rb:56:in `files'
org/jruby/RubyKernel.java:2007:in `instance_eval'
org/jruby/RubyArray.java:1572:in `each'

2)
String#scan with pattern and block taints the results if the String argument is tainted FAILED
Expected false to be true
/Users/headius/projects/jruby/spec/ruby/core/string/scan_spec.rb:182:in `(root)'
org/jruby/RubyArray.java:1572:in `each'
/Users/headius/projects/jruby/spec/ruby/core/string/scan_spec.rb:182:in `(root)'
org/jruby/RubyKernel.java:2007:in `instance_eval'
org/jruby/RubyEnumerable.java:1262:in `all?'
org/jruby/RubyArray.java:1572:in `each'
/Users/headius/projects/jruby/spec/ruby/core/string/scan_spec.rb:100:in `(root)'
org/jruby/RubyKernel.java:1062:in `load'
/Users/headius/projects/jruby/spec/ruby/core/string/scan_spec.rb:56:in `files'
org/jruby/RubyKernel.java:2007:in `instance_eval'
org/jruby/RubyArray.java:1572:in `each'
Show
Charles Oliver Nutter added a comment - 1) String#scan taints the results if the String argument is tainted FAILED Expected false to be true /Users/headius/projects/jruby/spec/ruby/core/string/scan_spec.rb:80:in `(root)' org/jruby/RubyArray.java:1572:in `each' /Users/headius/projects/jruby/spec/ruby/core/string/scan_spec.rb:80:in `(root)' org/jruby/RubyKernel.java:2007:in `instance_eval' org/jruby/RubyEnumerable.java:1262:in `all?' org/jruby/RubyArray.java:1572:in `each' /Users/headius/projects/jruby/spec/ruby/core/string/scan_spec.rb:5:in `(root)' org/jruby/RubyKernel.java:1062:in `load' /Users/headius/projects/jruby/spec/ruby/core/string/scan_spec.rb:56:in `files' org/jruby/RubyKernel.java:2007:in `instance_eval' org/jruby/RubyArray.java:1572:in `each' 2) String#scan with pattern and block taints the results if the String argument is tainted FAILED Expected false to be true /Users/headius/projects/jruby/spec/ruby/core/string/scan_spec.rb:182:in `(root)' org/jruby/RubyArray.java:1572:in `each' /Users/headius/projects/jruby/spec/ruby/core/string/scan_spec.rb:182:in `(root)' org/jruby/RubyKernel.java:2007:in `instance_eval' org/jruby/RubyEnumerable.java:1262:in `all?' org/jruby/RubyArray.java:1572:in `each' /Users/headius/projects/jruby/spec/ruby/core/string/scan_spec.rb:100:in `(root)' org/jruby/RubyKernel.java:1062:in `load' /Users/headius/projects/jruby/spec/ruby/core/string/scan_spec.rb:56:in `files' org/jruby/RubyKernel.java:2007:in `instance_eval' org/jruby/RubyArray.java:1572:in `each'
Hide
Permalink
Brian Browning added a comment -

I'm attaching a patch that makes mspec core/string/scan_spec.rb clear all tests

Show
Brian Browning added a comment - I'm attaching a patch that makes mspec core/string/scan_spec.rb clear all tests
Hide
Permalink
Hiro Asari added a comment -

Applied to master (https://github.com/jruby/jruby/commit/aa4348057f1c2bab3c1958f53d78a9b1d5c8a80f) and 1.6 branch (https://github.com/jruby/jruby/commit/929f5d989d8c811d574e4e9f3eba0ab485b22092)

Show
Hiro Asari added a comment - Applied to master ( https://github.com/jruby/jruby/commit/aa4348057f1c2bab3c1958f53d78a9b1d5c8a80f ) and 1.6 branch ( https://github.com/jruby/jruby/commit/929f5d989d8c811d574e4e9f3eba0ab485b22092 )

People

  • Assignee:
    Hiro Asari
    Reporter:
    Charles Oliver Nutter
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: