JRuby

Seeing ConnectionPendingException in my code

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: JRuby 1.6
  • Fix Version/s: JRuby 1.6.1
  • Component/s: None
  • Labels:
    None
  • Number of attachments :
    0

Description

This ruby code appears to be leaking a native java exception?

      def self.open(host, port, options = {})
        # All this ugly code to ensure proper Socket connect timeout
        addr = Socket.getaddrinfo(host, nil)
        sock = new(Socket.const_get(addr[0][0]), Socket::SOCK_STREAM, 0)
        sock.options = { :host => host, :port => port }.merge(options)
        begin
          sock.connect_nonblock(Socket.pack_sockaddr_in(port, addr[0][3]))
        rescue Errno::EINPROGRESS
          resp = IO.select(nil, [sock], nil, options[:timeout])
          begin
            sock.connect_nonblock(Socket.pack_sockaddr_in(port, addr[0][3]))
          rescue Errno::EISCONN
          end
        end
        sock
      end

java.nio.channels.ConnectionPendingException
	at sun.nio.ch.SocketChannelImpl.ensureOpenAndUnconnected(SocketChannelImpl.java:469)
	at sun.nio.ch.SocketChannelImpl.connect(SocketChannelImpl.java:479)
	at org.jruby.ext.socket.RubySocket.connect(RubySocket.java:388)
	at org.jruby.ext.socket.RubySocket.connect_nonblock(RubySocket.java:353)
	at org.jruby.ext.socket.RubySocket$i$1$0$connect_nonblock.call(RubySocket$i$1$0$connect_nonblock.gen:65535)
	at org.jruby.runtime.callsite.CachingCallSite.call(CachingCallSite.java:137)
	at rubyjit.open_9FF8DD58E409A6A12D778FF27EEFA8B7D8A04FF8.chained_2_rescue_2$RUBY$SYNTHETIC__file__(/Users/mperham/src/git/dalli/lib/dalli/socket.rb:66)
	at rubyjit.open_9FF8DD58E409A6A12D778FF27EEFA8B7D8A04FF8.chained_1_rescue_line_62(/Users/mperham/src/git/dalli/lib/dalli/socket.rb:65)

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Mike Perham added a comment -

I guess I need formatting help.

Show
Mike Perham added a comment - I guess I need formatting help.
Hide
Permalink
Mike Perham added a comment -

BTW I would assume this exception should be mapped to Errno::EINPROGRESS.

Show
Mike Perham added a comment - BTW I would assume this exception should be mapped to Errno::EINPROGRESS.
Hiro Asari made changes -
Field Original Value New Value
Description This ruby code appears to be leaking a native java exception?

{{
      def self.open(host, port, options = {})
        # All this ugly code to ensure proper Socket connect timeout
        addr = Socket.getaddrinfo(host, nil)
        sock = new(Socket.const_get(addr[0][0]), Socket::SOCK_STREAM, 0)
        sock.options = { :host => host, :port => port }.merge(options)
        begin
          sock.connect_nonblock(Socket.pack_sockaddr_in(port, addr[0][3]))
        rescue Errno::EINPROGRESS
          resp = IO.select(nil, [sock], nil, options[:timeout])
          begin
            sock.connect_nonblock(Socket.pack_sockaddr_in(port, addr[0][3]))
          rescue Errno::EISCONN
          end
        end
        sock
      end
}}

java.nio.channels.ConnectionPendingException
at sun.nio.ch.SocketChannelImpl.ensureOpenAndUnconnected(SocketChannelImpl.java:469)
at sun.nio.ch.SocketChannelImpl.connect(SocketChannelImpl.java:479)
at org.jruby.ext.socket.RubySocket.connect(RubySocket.java:388)
at org.jruby.ext.socket.RubySocket.connect_nonblock(RubySocket.java:353)
at org.jruby.ext.socket.RubySocket$i$1$0$connect_nonblock.call(RubySocket$i$1$0$connect_nonblock.gen:65535)
at org.jruby.runtime.callsite.CachingCallSite.call(CachingCallSite.java:137)
at rubyjit.open_9FF8DD58E409A6A12D778FF27EEFA8B7D8A04FF8.chained_2_rescue_2$RUBY$SYNTHETIC__file__(/Users/mperham/src/git/dalli/lib/dalli/socket.rb:66)
at rubyjit.open_9FF8DD58E409A6A12D778FF27EEFA8B7D8A04FF8.chained_1_rescue_line_62(/Users/mperham/src/git/dalli/lib/dalli/socket.rb:65) 		This ruby code appears to be leaking a native java exception?

{noformat}
      def self.open(host, port, options = {})
        # All this ugly code to ensure proper Socket connect timeout
        addr = Socket.getaddrinfo(host, nil)
        sock = new(Socket.const_get(addr[0][0]), Socket::SOCK_STREAM, 0)
        sock.options = { :host => host, :port => port }.merge(options)
        begin
          sock.connect_nonblock(Socket.pack_sockaddr_in(port, addr[0][3]))
        rescue Errno::EINPROGRESS
          resp = IO.select(nil, [sock], nil, options[:timeout])
          begin
            sock.connect_nonblock(Socket.pack_sockaddr_in(port, addr[0][3]))
          rescue Errno::EISCONN
          end
        end
        sock
      end
{noformat}

{noformat}
java.nio.channels.ConnectionPendingException
at sun.nio.ch.SocketChannelImpl.ensureOpenAndUnconnected(SocketChannelImpl.java:469)
at sun.nio.ch.SocketChannelImpl.connect(SocketChannelImpl.java:479)
at org.jruby.ext.socket.RubySocket.connect(RubySocket.java:388)
at org.jruby.ext.socket.RubySocket.connect_nonblock(RubySocket.java:353)
at org.jruby.ext.socket.RubySocket$i$1$0$connect_nonblock.call(RubySocket$i$1$0$connect_nonblock.gen:65535)
at org.jruby.runtime.callsite.CachingCallSite.call(CachingCallSite.java:137)
at rubyjit.open_9FF8DD58E409A6A12D778FF27EEFA8B7D8A04FF8.chained_2_rescue_2$RUBY$SYNTHETIC__file__(/Users/mperham/src/git/dalli/lib/dalli/socket.rb:66)
at rubyjit.open_9FF8DD58E409A6A12D778FF27EEFA8B7D8A04FF8.chained_1_rescue_line_62(/Users/mperham/src/git/dalli/lib/dalli/socket.rb:65)
{noformat}
Hide
Permalink
Charles Oliver Nutter added a comment -

This is very odd. The logic in question, in RubySocket.java, already does catch ConnectionPendingException and raise it as EINPROGRESS.

Show
Charles Oliver Nutter added a comment - This is very odd. The logic in question, in RubySocket.java, already does catch ConnectionPendingException and raise it as EINPROGRESS.
Hide
Permalink
Charles Oliver Nutter added a comment -

Easy one...we were logging the exception backtrace but then doing the right thing anyway.

commit 56c1fb34da48a15c6e36330a19add2ae32ea519f
Author: Charles Oliver Nutter <headius@headius.com>
Date: Fri Mar 25 14:06:47 2011 -0500

Fix JRUBY-5594: Seeing ConnectionPendingException in my code

  • Remove rogue printStackTrace calls from RubySocket.
Show
Charles Oliver Nutter added a comment - Easy one...we were logging the exception backtrace but then doing the right thing anyway. commit 56c1fb34da48a15c6e36330a19add2ae32ea519f Author: Charles Oliver Nutter <headius@headius.com> Date: Fri Mar 25 14:06:47 2011 -0500 Fix JRUBY-5594 : Seeing ConnectionPendingException in my code Remove rogue printStackTrace calls from RubySocket.
Charles Oliver Nutter made changes -
Status Open [ 1 ] Resolved [ 5 ]
Assignee Thomas E Enebo [ enebo ] Charles Oliver Nutter [ headius ]
Fix Version/s JRuby 1.6.1 [ 17085 ]
Resolution Fixed [ 1 ]
Charles Oliver Nutter made changes -
Status Resolved [ 5 ] Closed [ 6 ]

People

  • Assignee:
    Charles Oliver Nutter
    Reporter:
    Mike Perham
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: