JRuby

Provide option to treat decimal literals as precise decimal values

Details

  • Type: Improvement Improvement
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Won't Fix
  • Affects Version/s: None
  • Fix Version/s: None
  • Component/s: Extensions, Parser
  • Labels:
    None
  • Number of attachments :
    0

Description

Prompted by: http://twitter.com/antonarhipov/status/40197610262237184

Under this scenario, RubyFloat will be backed by BigDecimal.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Hiro Asari added a comment -

Additional input: http://www.ruby-forum.com/topic/199139

Show
Hiro Asari added a comment - Additional input: http://www.ruby-forum.com/topic/199139
Hide
Permalink
Charles Oliver Nutter added a comment -

As interesting an idea as this may be, I think we need to close this as wontfix. In Ruby, a Float is a float is a float, so we obviously can't unilaterally make it a BigDecimal. In addition, using BigDecimal by default would heavily impact Float performance.

I'd be willing to look over a patch to add this feature in even a brute-force way, just to see how it looks and feels. It would require extensive changes in RubyFloat (obviously) along with changes in the interpreter and compiler where we construct literal floats and in the parser where it parses them. It's a non-trivial amount of work for something we could never have enabled by default.

Show
Charles Oliver Nutter added a comment - As interesting an idea as this may be, I think we need to close this as wontfix. In Ruby, a Float is a float is a float, so we obviously can't unilaterally make it a BigDecimal. In addition, using BigDecimal by default would heavily impact Float performance. I'd be willing to look over a patch to add this feature in even a brute-force way, just to see how it looks and feels. It would require extensive changes in RubyFloat (obviously) along with changes in the interpreter and compiler where we construct literal floats and in the parser where it parses them. It's a non-trivial amount of work for something we could never have enabled by default.

People

  • Assignee:
    Charles Oliver Nutter
    Reporter:
    Hiro Asari
Vote (1)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved: