JRuby

Add native Date implementation to match switch_hitter being added to MRI

Details

  • Number of attachments :
    0

Description

As per this bug, a new native implementation of some Date logic is being incorporated into C Ruby:

http://redmine.ruby-lang.org/issues/show/4257

If this lands in the next few months, it will be part of 1.9.3. We should move to implement a native version as well, to maintain at least performance parity.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Douglas Campos added a comment -

I started working on it
track progress here => https://github.com/qmx/jruby/tree/native_date

suggestions are more than welcome

Show
Douglas Campos added a comment - I started working on it track progress here => https://github.com/qmx/jruby/tree/native_date suggestions are more than welcome
Hide
Permalink
Charles Oliver Nutter added a comment -

Awesome, thanks Douglas Maybe I'll have a look at it this weekend.

Show
Charles Oliver Nutter added a comment - Awesome, thanks Douglas Maybe I'll have a look at it this weekend.
Hide
Permalink
Charles Oliver Nutter added a comment -

Poking at it a little this evening.

This may warrant us adding a 1.9.3 mode, so we can have this be conditionally turned on. We've been meaning to do that for a while since there's a good chance we'll have 1.9.3 stuff (and maybe even 2.0 stuff) in flight before 1.8.7 mode can be removed.

So far it looks like you're doing it right

Show
Charles Oliver Nutter added a comment - Poking at it a little this evening. This may warrant us adding a 1.9.3 mode, so we can have this be conditionally turned on. We've been meaning to do that for a while since there's a good chance we'll have 1.9.3 stuff (and maybe even 2.0 stuff) in flight before 1.8.7 mode can be removed. So far it looks like you're doing it right
Hide
Permalink
Charles Oliver Nutter added a comment -

Filed JRUBY-5679 for making version management finer-grained.

Show
Charles Oliver Nutter added a comment - Filed JRUBY-5679 for making version management finer-grained.
Hide
Permalink
Charles Oliver Nutter added a comment -

Actually, is this only in 1.9.3, or is it also being added to a future 1.9.2 patchlevel?

Show
Charles Oliver Nutter added a comment - Actually, is this only in 1.9.3, or is it also being added to a future 1.9.2 patchlevel?
Hide
Permalink
Charles Oliver Nutter added a comment -

Charles: This is only in 1.9.3, so it would only go on master.

Show
Charles Oliver Nutter added a comment - Charles: This is only in 1.9.3, so it would only go on master.

People

  • Assignee:
    Unassigned
    Reporter:
    Charles Oliver Nutter
Vote (0)
Watch (1)

Dates

  • Created:
    Updated: