bfts test_file_test failures

Details

Type: Sub-task
Status: Closed
Priority: Major
Resolution: Fixed
Affects Version/s: None
Fix Version/s: JRuby 1.2
Component/s: Core Classes/Modules
Labels:
None

Description

There's actually a whole bunch of these, but it seems that test_file_test depends on symlink always working, among other things. This prevents most tests from even running.

  1) Error:
test_class_blockdev_eh(TestFileTest):
NoMethodError: undefined method `symlink' for File:Class
    test/externals/bfts/test_file_test.rb:19:in `method_missing'
    test/externals/bfts/test_file_test.rb:19:in `setup'

  2) Error:
test_class_blockdev_eh(TestFileTest):
NoMethodError: undefined method `path' for :NilClass
    test/externals/bfts/test_file_test.rb:39:in `method_missing'
    test/externals/bfts/test_file_test.rb:39:in `teardown'
...

Activity

Ascending order - Click to sort in descending order

Hide

Permalink

Charles Oliver Nutter added a comment - 30/Sep/07 10:37 AM

Look at using JNA in 1.1 to resolve these.

Show

Charles Oliver Nutter added a comment - 30/Sep/07 10:37 AM Look at using JNA in 1.1 to resolve these.

Hide

Permalink

Charles Oliver Nutter added a comment - 20/Dec/07 3:02 PM

It seems all the remaining failures are because we don't support UNIXServer.

Show

Charles Oliver Nutter added a comment - 20/Dec/07 3:02 PM It seems all the remaining failures are because we don't support UNIXServer.

Hide

Permalink

Daniel Berger added a comment - 21/Dec/07 9:49 AM

UNIXServer? Did you mean symlinks?

Another issue with bfts is that those tests wouldn't pass on MS Windows anyway, unless it's Vista or later. Even then I'm not sure, since I haven't tried them yet.

Another alternative for pre-Vista systems is to make symlinks create a junction. It would only work on directories, but it might be better than nothing.

Both will require JNA.

Show

Daniel Berger added a comment - 21/Dec/07 9:49 AM UNIXServer? Did you mean symlinks? Another issue with bfts is that those tests wouldn't pass on MS Windows anyway, unless it's Vista or later. Even then I'm not sure, since I haven't tried them yet. Another alternative for pre-Vista systems is to make symlinks create a junction. It would only work on directories, but it might be better than nothing. Both will require JNA.

Hide

Permalink

Charles Oliver Nutter added a comment - 21/Dec/07 3:08 PM

Yes, the UNIXServer comment was for another bug...misfired.

At this point I think we're usually concerned first with non-Windows systems, and then concerned with hacking around Windows deficiencies later. We can get symlinks working with JNA, but unless MRI does some magic with junctions on Windows, we should just bail out and do whatever MRI does.

Show

Charles Oliver Nutter added a comment - 21/Dec/07 3:08 PM Yes, the UNIXServer comment was for another bug...misfired. At this point I think we're usually concerned first with non-Windows systems, and then concerned with hacking around Windows deficiencies later. We can get symlinks working with JNA, but unless MRI does some magic with junctions on Windows, we should just bail out and do whatever MRI does.

Hide

Permalink

Charles Oliver Nutter added a comment - 15/Feb/08 12:55 PM

Removing target release from issues that fit any of the following criteria:

No known way to fix them
Java integration enhancements out of scope for 1.1 release
Other out of scope issues for 1.1

Show

Charles Oliver Nutter added a comment - 15/Feb/08 12:55 PM Removing target release from issues that fit any of the following criteria:

No known way to fix them
Java integration enhancements out of scope for 1.1 release
Other out of scope issues for 1.1

Hide

Permalink

Charles Oliver Nutter added a comment - 17/Mar/08 9:01 PM

These are actually a lot better now since JNA supports most of the missing methods. But we still fail a few of these. Here's the full output:

  1) Failure:
test_class_exist_eh(TestFileTest)
    [test/externals/bfts/test_file_test.rb:69:in `util_test'
     test/externals/bfts/test_file_test.rb:63:in `each'
     test/externals/bfts/test_file_test.rb:63:in `util_test'
     test/externals/bfts/test_file_test.rb:133:in `test_class_exist_eh']:
Mismatch for :pipe calling :exist?.
<true> expected but was
<false>.

  2) Failure:
test_class_exists_eh(TestFileTest)
    [test/externals/bfts/test_file_test.rb:69:in `util_test'
     test/externals/bfts/test_file_test.rb:63:in `each'
     test/externals/bfts/test_file_test.rb:63:in `util_test'
     test/externals/bfts/test_file_test.rb:148:in `test_class_exists_eh']:
Mismatch for :pipe calling :exists?.
<true> expected but was
<false>.

  3) Failure:
test_class_pipe_eh(TestFileTest)
    [test/externals/bfts/test_file_test.rb:69:in `util_test'
     test/externals/bfts/test_file_test.rb:63:in `each'
     test/externals/bfts/test_file_test.rb:63:in `util_test'
     test/externals/bfts/test_file_test.rb:194:in `test_class_pipe_eh']:
Mismatch for :pipe calling :pipe?.
<true> expected but was
<false>.

  4) Error:
test_class_size(TestFileTest):
Errno::ENOENT: No such file or directory - No such file or directory - /var/folders/qM/qMVwu0heGoWE4rGPnEgAYk+++TI/-Tmp-/97ebc4c3b5652d0c4c12546deead41fa_pipe.33050.85
    test/externals/bfts/test_file_test.rb:372

  5) Failure:
test_class_sticky_eh(TestFileTest)
    [test/externals/bfts/test_file_test.rb:69:in `util_test'
     test/externals/bfts/test_file_test.rb:63:in `each'
     test/externals/bfts/test_file_test.rb:63:in `util_test'
     test/externals/bfts/test_file_test.rb:312:in `test_class_sticky_eh']:
Mismatch for :sticky_dir calling :sticky?.
<true> expected but was
<false>.

  6) Failure:
test_class_zero_eh(TestFileTest)
    [test/externals/bfts/test_file_test.rb:69:in `util_test'
     test/externals/bfts/test_file_test.rb:63:in `each'
     test/externals/bfts/test_file_test.rb:63:in `util_test'
     test/externals/bfts/test_file_test.rb:356:in `test_class_zero_eh']:
Mismatch for :pipe calling :zero?.
<true> expected but was
<false>.

26 tests, 160 assertions, 5 failures, 1 errors

Show

Charles Oliver Nutter added a comment - 17/Mar/08 9:01 PM These are actually a lot better now since JNA supports most of the missing methods. But we still fail a few of these. Here's the full output:

  1) Failure:
test_class_exist_eh(TestFileTest)
    [test/externals/bfts/test_file_test.rb:69:in `util_test'
     test/externals/bfts/test_file_test.rb:63:in `each'
     test/externals/bfts/test_file_test.rb:63:in `util_test'
     test/externals/bfts/test_file_test.rb:133:in `test_class_exist_eh']:
Mismatch for :pipe calling :exist?.
<true> expected but was
<false>.

  2) Failure:
test_class_exists_eh(TestFileTest)
    [test/externals/bfts/test_file_test.rb:69:in `util_test'
     test/externals/bfts/test_file_test.rb:63:in `each'
     test/externals/bfts/test_file_test.rb:63:in `util_test'
     test/externals/bfts/test_file_test.rb:148:in `test_class_exists_eh']:
Mismatch for :pipe calling :exists?.
<true> expected but was
<false>.

  3) Failure:
test_class_pipe_eh(TestFileTest)
    [test/externals/bfts/test_file_test.rb:69:in `util_test'
     test/externals/bfts/test_file_test.rb:63:in `each'
     test/externals/bfts/test_file_test.rb:63:in `util_test'
     test/externals/bfts/test_file_test.rb:194:in `test_class_pipe_eh']:
Mismatch for :pipe calling :pipe?.
<true> expected but was
<false>.

  4) Error:
test_class_size(TestFileTest):
Errno::ENOENT: No such file or directory - No such file or directory - /var/folders/qM/qMVwu0heGoWE4rGPnEgAYk+++TI/-Tmp-/97ebc4c3b5652d0c4c12546deead41fa_pipe.33050.85
    test/externals/bfts/test_file_test.rb:372

  5) Failure:
test_class_sticky_eh(TestFileTest)
    [test/externals/bfts/test_file_test.rb:69:in `util_test'
     test/externals/bfts/test_file_test.rb:63:in `each'
     test/externals/bfts/test_file_test.rb:63:in `util_test'
     test/externals/bfts/test_file_test.rb:312:in `test_class_sticky_eh']:
Mismatch for :sticky_dir calling :sticky?.
<true> expected but was
<false>.

  6) Failure:
test_class_zero_eh(TestFileTest)
    [test/externals/bfts/test_file_test.rb:69:in `util_test'
     test/externals/bfts/test_file_test.rb:63:in `each'
     test/externals/bfts/test_file_test.rb:63:in `util_test'
     test/externals/bfts/test_file_test.rb:356:in `test_class_zero_eh']:
Mismatch for :pipe calling :zero?.
<true> expected but was
<false>.

26 tests, 160 assertions, 5 failures, 1 errors

Hide

Permalink

Charles Oliver Nutter added a comment - 12/Feb/09 5:54 PM

Down to one failure. Looking at it now.

  1) Failure:
test_class_sticky_eh(TestFileTest)
    [test/externals/bfts/test_file_test.rb:69:in `util_test'
     test/externals/bfts/test_file_test.rb:63:in `each'
     test/externals/bfts/test_file_test.rb:63:in `util_test'
     test/externals/bfts/test_file_test.rb:312:in `test_class_sticky_eh']:
Mismatch for :sticky_dir calling :sticky?.
<true> expected but was
<false>.

Show

Charles Oliver Nutter added a comment - 12/Feb/09 5:54 PM Down to one failure. Looking at it now.

  1) Failure:
test_class_sticky_eh(TestFileTest)
    [test/externals/bfts/test_file_test.rb:69:in `util_test'
     test/externals/bfts/test_file_test.rb:63:in `each'
     test/externals/bfts/test_file_test.rb:63:in `util_test'
     test/externals/bfts/test_file_test.rb:312:in `test_class_sticky_eh']:
Mismatch for :sticky_dir calling :sticky?.
<true> expected but was
<false>.

Hide

Permalink

Charles Oliver Nutter added a comment - 12/Feb/09 6:09 PM

It turns out the last remaining test also failed in MRI, so I commented it out. Hopefully these will make their way into rubyspec some day, but for now I've enabled it in our bfts suite. Committed in r9126.

Show

Charles Oliver Nutter added a comment - 12/Feb/09 6:09 PM It turns out the last remaining test also failed in MRI, so I commented it out. Hopefully these will make their way into rubyspec some day, but for now I've enabled it in our bfts suite. Committed in r9126.

People

Assignee:

Charles Oliver Nutter

Reporter:

Charles Oliver Nutter

Vote (0)

Watch (1)

Dates

Created:

03/Feb/07 5:21 PM

Updated:

21/Mar/09 1:13 PM

Resolved:

12/Feb/09 6:09 PM