JRuby

Eliminate Iter and Block stacks within JRuby

Details

  • Type: Task Task
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: JRuby 0.9.0
  • Fix Version/s: JRuby 0.9.8
  • Component/s: Projects
  • Labels:
    None
  • Number of attachments :
    0

Description

As of 0.9.0 and current TRUNK, JRuby still uses the same iter stack/block stack method of managing blocks that C Ruby does. This method, however, has considerable overhead. For making a call, there are as many as three pushes and three pops on each stack, when all that's necessary is passing the block to the method that actually needs it.

The most promising way to fix this would be to pass the block directly to the frame in which it will be called. Some of this work has already started on the cnutter branch.

This task should track the reduction and eventual elimination of the Iter and Block stacks.

Activity

Ascending order - Click to sort in descending order
Thomas E Enebo made changes -
Field Original Value New Value
Assignee Thomas E Enebo [ enebo ] Charles Oliver Nutter [ headius ]
Charles Oliver Nutter made changes -
Component/s Projects [ 12310 ]
Charles Oliver Nutter made changes -
Status Open [ 1 ] In Progress [ 3 ]
Hide
Permalink
Charles Oliver Nutter added a comment -

Recent work has been able to eliminate the blockstack. Next targets:

  • move the remaining block linked list management into the frame, or eliminate it entirely by reordering how block AST nodes are encountered and handled
  • move into Frame or eliminate the management of the "iter" stack
Show
Charles Oliver Nutter added a comment - Recent work has been able to eliminate the blockstack. Next targets: move the remaining block linked list management into the frame, or eliminate it entirely by reordering how block AST nodes are encountered and handled move into Frame or eliminate the management of the "iter" stack
Charles Oliver Nutter made changes -
Affects Version/s JRuby 0.9.0 [ 12840 ]
Hide
Permalink
Miguel Covarrubias added a comment -

I think this should be closeable now that Tom's block-passing branch is merged to trunk?

Show
Miguel Covarrubias added a comment - I think this should be closeable now that Tom's block-passing branch is merged to trunk?
Hide
Permalink
Thomas E Enebo added a comment -

Indeed!

Show
Thomas E Enebo added a comment - Indeed!
Thomas E Enebo made changes -
Fix Version/s JRuby 0.9.3 [ 13069 ]
Status In Progress [ 3 ] Resolved [ 5 ]
Resolution Fixed [ 1 ]
Charles Oliver Nutter made changes -
Status Resolved [ 5 ] Closed [ 6 ]

People

  • Assignee:
    Charles Oliver Nutter
    Reporter:
    Charles Oliver Nutter
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: