JRuby

Marshal specs failing in 1.8 mode

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Critical Critical
  • Resolution: Fixed
  • Affects Version/s: JRuby 1.6RC2
  • Fix Version/s: JRuby 1.6RC3
  • Component/s: None
  • Labels:
    None
  • Number of attachments :
    0

Description

1.8 CI has been failing for a few days. See, for example: http://ci.jruby.org/job/spec-ci/testtype=spec-ci_precompiled_18/261/console

The problem was introduced by

$ git bisect good
ebfd468d5a0d665885b835185811ea9e97aea3ad is the first bad commit
commit ebfd468d5a0d665885b835185811ea9e97aea3ad
Author: Charles Oliver Nutter <headius@headius.com>
Date:   Fri Feb 4 14:58:32 2011 -0600

    [1.9] Fix almost all remaining Marshal.load specs
    
    * Symbols *should* get yielded to the provided proc
    * Symbols used for internal structure should *not* get yielded
    * Non-symbol objects from link cache *should* be yielded
    * Symbols from link cache should *not* be yielded

:040000 040000 d993619b4e433ec580613ea2101175b9a72a9260 785c9e8c6fe19aeb208ff42ae4b0e256a754996a M	spec
:040000 040000 d6bd6a64ef3e8907b38329254339678486fb8fed 631b90a9f38d7722d3276371953e36dbde860414 M	src

Activity

Hide
Permalink
Charles Oliver Nutter added a comment -

commit da2f4f21ff36a26be254445c0e88fbc12f3f6045
Author: Charles Oliver Nutter <headius@headius.com>
Date: Wed Feb 16 11:21:24 2011 -0600

Fix 5481: Marshal specs failing in 1.8 mode

  • The fixes for 1.9 should be isolated to 1.9.
Show
Charles Oliver Nutter added a comment - commit da2f4f21ff36a26be254445c0e88fbc12f3f6045 Author: Charles Oliver Nutter <headius@headius.com> Date: Wed Feb 16 11:21:24 2011 -0600 Fix 5481: Marshal specs failing in 1.8 mode The fixes for 1.9 should be isolated to 1.9.

People

  • Assignee:
    Charles Oliver Nutter
    Reporter:
    Hiro Asari
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: