JRuby

rb_time_new prototype doesn't match definition

Details

  • Number of attachments :
    2

Description

The prototype for rb_time_new doesn't match the definition. The prototype is:

RUBY_DLLSPEC VALUE rb_time_new(long sec, long usec);

https://github.com/jruby/jruby/blob/master/cext/src/include/ruby/ruby.h#L1003

the definition is:

extern "C" VALUE
rb_time_new(time_t sec, long usec)

https://github.com/jruby/jruby/blob/master/cext/src/time.cpp#L23

On OpenBSD i386, the compiler errors out because time_t is int and and not long. Changing the prototype to time_t fixes the issue. Patch attached.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Hiro Asari added a comment -

Jeremy,

Can you provide a git patch, so that we can give you credit?

Thanks.

Show
Hiro Asari added a comment - Jeremy, Can you provide a git patch, so that we can give you credit? Thanks.
Hide
Permalink
Jeremy Evans added a comment -

Here's a git patch.

Show
Jeremy Evans added a comment - Here's a git patch.
Hide
Permalink
Hiro Asari added a comment -

Pushed Jeremy's fix in https://github.com/jruby/jruby/commit/09e87fd7dcec1487731a56111ed4c4a6b48b1ba7

Thanks, Jeremy!

Show
Hiro Asari added a comment - Pushed Jeremy's fix in https://github.com/jruby/jruby/commit/09e87fd7dcec1487731a56111ed4c4a6b48b1ba7 Thanks, Jeremy!

People

  • Assignee:
    Hiro Asari
    Reporter:
    Jeremy Evans
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: