Details
-
Type:
Sub-task
-
Status:
Closed
-
Priority:
Major
-
Resolution: Won't Fix
-
Affects Version/s: None
-
Fix Version/s: None
-
Component/s: None
-
Labels:None
-
Number of attachments :
Description
We have other bugs for trace problems, but I am recording this one here since it's a subtask of the "MRI tests" task.
1) Failure: test_event(TestSetTraceFunc) [test_settracefunc.rb:43]: <["call", 4, :foo, #<Class:0x4bb523>]> expected but was <["call", 20, :foo, #<Class:0x4bb523>]>.
Attachments
Issue Links
| This issue depends upon: | ||||
| JRUBY-971 | Make it clear which Java method maps to each equality method |
|
|
|
Activity
Whoops, didn't realize my file description would be attached as a comment. 
I've added method_equality_test.rb to define the expected behaviour of the missing == methods. I hit the issue when switching a Rails project from Ruby 1.8.5 to JRuby 1.0.1. There is no way to implement these in user code as the internals of all three classes are hidden in both implementations.
Also, I found it frustrating in Ruby that == is defined on these three classes in terms of having the same body (which is preserved under method aliasing), and yet eql? and hash are not defined in a similar way so none of them can be used effectively as Hash keys, which is my target usage.
I am currently working around this in Ruby by defining UnboundMethod#=hash to be a fixed number, which works but means my Hashes degenerate to associative lists. I will log this as a feature request on the appropriate Ruby issue tracker, but I just wanted to mention it here for interest's sake.
I've added method_equality_test.rb to define the expected behaviour of the missing == methods. I hit the issue when switching a Rails project from Ruby 1.8.5 to JRuby 1.0.1. There is no way to implement these in user code as the internals of all three classes are hidden in both implementations.
Also, I found it frustrating in Ruby that == is defined on these three classes in terms of having the same body (which is preserved under method aliasing), and yet eql? and hash are not defined in a similar way so none of them can be used effectively as Hash keys, which is my target usage.
I am currently working around this in Ruby by defining UnboundMethod#=hash to be a fixed number, which works but means my Hashes degenerate to associative lists. I will log this as a feature request on the appropriate Ruby issue tracker, but I just wanted to mention it here for interest's sake.
Here's a few fixes to get us farther in this file. See also
JRUBY-971, which is the cause of the failure it gets to now (basically, the default === impl needs to always invoke ==, and Fixnum needs to map to the right methods).JRUBY-971, which is the cause of the failure it gets to now (basically, the default === impl needs to always invoke ==, and Fixnum needs to map to the right methods).