become_java! / RubyClass.reify regression

This appears to occur when you call become_java! upon a Ruby class that subclasses another Ruby class.

If become_java! is called on the hierarchy from the root to the subclass leaf, it succeeds. If the first become_java! invocation occurs on a leaf before being called on the superclass, the above exception occurs.

require 'jruby/core_ext'
require 'java'

class MyBaseThing
end

#MyBaseThing.become_java!

class MySubThing < MyBaseThing

  def self.static_method()
  end

  class << self
    add_method_signature( "static_method", [java.util.HashMap] )
    add_method_annotation( "static_method", java.lang.Deprecated=> {} )
  end

end

MySubThing.become_java!

The last line of the code above will fail while line 7 (MyBaseThing.become_java!) is commented out. Uncomment that line, and MySubThing.become_java! will succeed.

It would see RubyClass.reify should work its way down from the root of the hierachy to the leaf.

Output from the above code run with MyBaseThing.become_java! commented-out:

leonard:integration-tests bob$ jruby deify.rb 
RubyClass.java:1169:in `reify': java.lang.NullPointerException
        from RubyClass.java:1146:in `reify'
        from RubyJRuby.java:488:in `become_java_bang'
        from org/jruby/RubyJRuby$JRubyClassExtensions$s_method_0_1$RUBYINVOKER$become_java_bang.gen:65535:in `call'
        from JavaMethod.java:626:in `call'
        from DynamicMethod.java:196:in `call'
        from CachingCallSite.java:262:in `cacheAndCall'
        from CachingCallSite.java:105:in `call'
        from deify.rb:22:in `__file__'
        from deify.rb:-1:in `load'
        from Ruby.java:702:in `runScript'
        from Ruby.java:587:in `runNormally'
        from Ruby.java:421:in `runFromMain'
        from Main.java:304:in `run'
        from Main.java:144:in `run'
        from Main.java:113:in `main'

Here's a quick pass at a fix. JI specs don't pass with it, but it basically tries to cascade reification up the hierarchy like for reify.classes=true.

https://gist.github.com/783686

commit 1852918db083a08f9b5410523b02023881f5adde
Author: Charles Oliver Nutter <headius@headius.com>
Date: Mon Jan 31 15:20:06 2011 -0600

Fix JRUBY-5364: become_java! / RubyClass.reify regression

• Cascade requests to reify (become_java!) up class hiearachy, so they all reify
• Add an error to RubyClass.reify if the parent has not yet been reified

Logic to determine whether reification is possible is a bit weak (just checks if real superclass == Object or is unreified), but no weaker than previously.

commit 39477403a16805225cffb1da90f31d4a6f3192b2
Author: Bob McWhirter <bob@mcwhirter.org>
Date: Sat Jan 22 11:34:15 2011 -0500

Spec testing JRUBY-5364 - become_java! with a deep hierarchy.
Spec testing JRUBY-5407 - become_java! and add_method_signature interactions when defining parameter types.

Signed-off-by: Charles Oliver Nutter <headius@headius.com>