JRuby

1.9 String#% support

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: None
  • Fix Version/s: JRuby 1.6.6
  • Component/s: Ruby 1.9.2
  • Labels:
    None
  • Number of attachments :
    0

Description

String#% should accept hashes
"%

{foo}

" %

{foo: "bar"}

=> "bar"

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Charles Oliver Nutter added a comment -

Wanna mock up a Ruby impl of this? It might be the shipping impl, if it works well.

Show
Charles Oliver Nutter added a comment - Wanna mock up a Ruby impl of this? It might be the shipping impl, if it works well.
Hide
Permalink
Charles Oliver Nutter added a comment -

OR RATHER...anyone watching this could whip up a Ruby impl

Show
Charles Oliver Nutter added a comment - OR RATHER...anyone watching this could whip up a Ruby impl
Hide
Permalink
Anthony Juckel added a comment -

I've got a quick (quick to write, not performant) implementation at https://gist.github.com/1229071. I wasn't sure where to put something like this in the source tree (I don't see any other String methods being added in Ruby code), nor how to make it require Ruby 1.9 mode, but it's a start and seems to work for the few test cases I threw at it.

Show
Anthony Juckel added a comment - I've got a quick (quick to write, not performant) implementation at https://gist.github.com/1229071 . I wasn't sure where to put something like this in the source tree (I don't see any other String methods being added in Ruby code), nor how to make it require Ruby 1.9 mode, but it's a start and seems to work for the few test cases I threw at it.
Hide
Permalink
Charles Oliver Nutter added a comment -

That's awesome Anthony. I'm going to have a look and see if it can be incorporated as-is. We may end up porting the logic from the C code to our Java-based sprintf, but if this is working it can be our interim solution.

For the record, the place this would go for 1.9 mode is in src/builtin/prelude.rb, which includes a bunch of Ruby-based pieces of 1.9 stuff we've implemented over the past few months.

Show
Charles Oliver Nutter added a comment - That's awesome Anthony. I'm going to have a look and see if it can be incorporated as-is. We may end up porting the logic from the C code to our Java-based sprintf, but if this is working it can be our interim solution. For the record, the place this would go for 1.9 mode is in src/builtin/prelude.rb, which includes a bunch of Ruby-based pieces of 1.9 stuff we've implemented over the past few months.
Hide
Permalink
Charles Oliver Nutter added a comment -

Thanks Anthony! Your fix was pushed to master@fc6ccff and jruby-1_6@22b92a0.

Show
Charles Oliver Nutter added a comment - Thanks Anthony! Your fix was pushed to master@fc6ccff and jruby-1_6@22b92a0.

People

  • Assignee:
    Charles Oliver Nutter
    Reporter:
    Marcin Mielzynski
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: