[#JRUBY-5306] EOF while parsing identifier in $KCODE="s" raises ArrayIndexOutOfBoundsException - jira.codehaus.org

Details

Type: Bug
Status: Closed
Priority: Major
Resolution: Fixed
Affects Version/s: JRuby 1.5.6
Fix Version/s: JRuby 1.6RC1
Component/s: Parser
Labels:
None
Environment:
jruby 1.5.6 (ruby 1.8.7 patchlevel 249) (2010-12-03 9cf97c3) (OpenJDK 64-Bit Server VM 1.6.0_20) [amd64-java]

Number of attachments :
0

Description

0% jruby15 -Ks -ve 'eval("$a")'
jruby 1.5.6 (ruby 1.8.7 patchlevel 249) (2010-12-03 9cf97c3) (OpenJDK 64-Bit Server VM 1.6.0_20) [amd64-java]
BaseSJISEncoding.java:47:in `codeToMbcLength': java.lang.ArrayIndexOutOfBoundsException: -1
	from RubyYaccLexer.java:466:in `isMultiByteChar'
	from RubyYaccLexer.java:456:in `isIdentifierChar'
	from RubyYaccLexer.java:1062:in `getIdentifier'
	from RubyYaccLexer.java:1351:in `dollar'
	from RubyYaccLexer.java:1023:in `yylex'
	from RubyYaccLexer.java:293:in `advance'
	from DefaultRubyParser.java:1380:in `yyparse'
	from DefaultRubyParser.java:1332:in `yyparse'
	from DefaultRubyParser.java:3986:in `parse'
	from Parser.java:111:in `parse'
	from Parser.java:82:in `parse'
	from Parser.java:74:in `parse'
	from Ruby.java:2301:in `parseEval'
	from ASTInterpreter.java:96:in `evalWithBinding'
	from RubyKernel.java:1045:in `eval'
	from org/jruby/RubyKernel$s_method_0_3$RUBYFRAMEDINVOKER$eval.gen:65535:in `call'
	from DynamicMethod.java:190:in `call'
	from DynamicMethod.java:186:in `call'
	from CachingCallSite.java:309:in `cacheAndCall'
	from CachingCallSite.java:148:in `call'
	from -e:1:in `__file__'
	from -e:-1:in `load'
	from Ruby.java:690:in `runScript'
	from Ruby.java:573:in `runNormally'
	from Ruby.java:416:in `runFromMain'
	from Main.java:286:in `run'
	from Main.java:128:in `run'
	from Main.java:97:in `main'

Typically, "jruby -S irb" then "$KCODE='s'" raises the exception.

Activity

Ascending order - Click to sort in descending order

Hide

Permalink

Hiroshi Nakamura added a comment - 05/Jan/11 10:45 AM

commit 10c9d3bb022a639b11a77bb93efa9f672e42e95b
Author: Hiroshi Nakamura <nahi@ruby-lang.org>
Date: Thu Jan 6 01:38:37 2011 +0900

~~JRUBY-5306~~: EOF while parsing identifier under $KCODE="s" raised an ArrayIndexOutOfBoundsException

diff --git a/src/org/jruby/lexer/yacc/RubyYaccLexer.java b/src/org/jruby/lexer/yacc/RubyYaccLexer.java
index f3fcbda..42f1a9a 100644
--- a/src/org/jruby/lexer/yacc/RubyYaccLexer.java
+++ b/src/org/jruby/lexer/yacc/RubyYaccLexer.java
@@ -1183,7 +1183,7 @@ public class RubyYaccLexer {
                 }
             }*/
             c = src.read();
-        } while (isIdentifierChar(c));
+        } while (c != EOF && isIdentifierChar(c));
         
         return c;
     }

Show

Hiroshi Nakamura added a comment - 05/Jan/11 10:45 AM commit 10c9d3bb022a639b11a77bb93efa9f672e42e95b Author: Hiroshi Nakamura <nahi@ruby-lang.org> Date: Thu Jan 6 01:38:37 2011 +0900 JRUBY-5306 : EOF while parsing identifier under $KCODE="s" raised an ArrayIndexOutOfBoundsException diff --git a/src/org/jruby/lexer/yacc/RubyYaccLexer.java b/src/org/jruby/lexer/yacc/RubyYaccLexer.java index f3fcbda..42f1a9a 100644 --- a/src/org/jruby/lexer/yacc/RubyYaccLexer.java +++ b/src/org/jruby/lexer/yacc/RubyYaccLexer.java @@ -1183,7 +1183,7 @@ public class RubyYaccLexer { } }*/ c = src.read(); - } while (isIdentifierChar(c)); + } while (c != EOF && isIdentifierChar(c)); return c; }

Hide

Permalink

Hiroshi Nakamura added a comment - 12/Jan/11 4:20 AM

Confirmed the fix at 1.6.0.RC1.

% jruby -S irb
$KCirb(main):001:0> $KCODE = "s"
=> "s"

Show

Hiroshi Nakamura added a comment - 12/Jan/11 4:20 AM Confirmed the fix at 1.6.0.RC1. % jruby -S irb $KCirb(main):001:0> $KCODE = "s" => "s"

EOF while parsing identifier in $KCODE="s" raises ArrayIndexOutOfBoundsException

Details

Description

Activity

People

Dates