Details
-
Type:
Bug
-
Status:
Closed
-
Priority:
Major
-
Resolution: Fixed
-
Affects Version/s: None
-
Fix Version/s: JRuby 1.6RC3
-
Component/s: None
-
Labels:None
-
Number of attachments :
Description
This is a regression. Previous versions of jruby-complete.jar didn't percent-escape spaces in the paths.
$ pwd
/tmp
$ java -jar jruby-complete.jar -v
jruby 1.6.0.dev (ruby 1.8.7 patchlevel 249) (2010-12-29 ab3899a) (Java HotSpot(TM) 64-Bit Server VM 1.6.0_22) [darwin-x86_64-java]
$ java -jar jruby-complete.jar -r set -e 'p $LOAD_PATH'
["file:/private/tmp/jruby-complete.jar!/META-INF/jruby.home/lib/ruby/site_ruby/1.8", "file:/private/tmp/jruby-complete.jar!/META-INF/jruby.home/lib/ruby/site_ruby/shared", "file:/private/tmp/jruby-complete.jar!/META-INF/jruby.home/lib/ruby/1.8", "."]
$ mkdir "path with spaces"
$ mv jruby-complete.jar path\ with\ spaces
$ java -jar path\ with\ spaces/jruby-complete.jar -r set -e 'p $LOAD_PATH'
org.jruby.exceptions.RaiseException: (LoadError) no such file to load – set
$ java -jar path\ with\ spaces/jruby-complete.jar -e 'p $LOAD_PATH'
["file:/private/tmp/path%20with%20spaces/jruby-complete.jar!/META-INF/jruby.home/lib/ruby/site_ruby/1.8", "file:/private/tmp/path%20with%20spaces/jruby-complete.jar!/META-INF/jruby.home/lib/ruby/site_ruby/shared", "file:/private/tmp/path%20with%20spaces/jruby-complete.jar!/META-INF/jruby.home/lib/ruby/1.8", "."]
$
Issue Links
- is duplicated by
-
JRUBY-5337
No such file to load -- rack when booting JRuby 1.6.0RC1 Rails app in Tomcat
-
- is related to
-
JRUBY-5287
With spaces in it's path, jruby-complete can't find rubygems.rb
-
- relates to
-
JRUBY-5345
require 'ffi' breaks in windows jar when the path to the jar contains spaces/special chars
-
Activity
Still broken for me with jruby-jars 1.6.0.rc2 and jruby-rack 1.6.0.rc1 
If we change require_relative in kernel.rb to decode the uri before passing it to the File methods my case seems to work fine. I am not sure if it is a good idea that
the Kernel module depends on the URI class though, but it seems to me that either:
- the RubyFile methods must support URI encoded uri's
- require_relative must decode the uri's before passing them onward
- the uri string that we get from caller.first at kernel.rb:14 should not contain an uri encoded value
java -jar jruby-complete.jar -e "require 'krypt'; puts 'success'"
success
I wasn't able to attach anything to this issue so the patch is inline. (should I have cloned this issue or created another issue instead)
– PATCH –
From bbcc653bb47850171158776f15388a53858f04e5 Mon Sep 17 00:00:00 2001
From: Syver Enstad <syver.enstad@cisco.com>
Date: Wed, 24 Apr 2013 19:29:07 +0200
Subject: [PATCH] Fix the require_relative issue
—
src/jruby/kernel19/kernel.rb | 3 +++
1 file changed, 3 insertions
diff --git a/src/jruby/kernel19/kernel.rb b/src/jruby/kernel19/kernel.rb
index ae2cbdf..ee8efe7 100644
— a/src/jruby/kernel19/kernel.rb
+++ b/src/jruby/kernel19/kernel.rb
@@ -1,3 +1,5 @@
+require 'uri'
+
module Kernel
module_function
def require_relative(relative_feature)
@@ -15,6 +17,7 @@ module Kernel
if /\A((.*))/ =~ file # eval, etc.
raise LoadError, "cannot infer basepath"
end
+ file = URI.decode(file)
absolute_feature = File.expand_path(relative_feature, File.dirname(file))
require absolute_feature
end
–
1.7.10.4
pushed in d4a6279