RubyGems Maven doesn't like alphanumeric versions

Details

Type: Bug
Status: Resolved
Priority: Major
Resolution: Won't Fix
Affects Version/s: None
Fix Version/s: None
Component/s: Extensions
Labels:
None
Environment:
Mac OS X 10.6.5, RVM 1.1.1, jruby-head installed

Number of attachments :
0

Description

I'm trying out the Maven Gemify plugin (very excited about this, btw) on 1.6-head and I am having some troubles getting things to work just right. One issue is version numbers.

klauer@klauer-imac ~/Programming/Ruby/jruby
$ gem install com.google.guava.guava -v r07
ERROR:  While executing gem ... (ArgumentError)
    Illformed requirement ["r07"]

I'm not sure if this is expected or not, but I would wager that eventually this should work.

I'm using RVM to install jruby-head.

Issue Links

is related to

JRUBY-5292 Consider RubyGems 1.4.1 for JRuby 1.6.0

relates to

JRUBY-5207 RubyGems Maven support does not handle missing/bad poms/versions/artifacts gracefully

JRUBY-5730 can't update to rubygems 1.7.2: undefined method `version' for nil:NilClass

Activity

Ascending order - Click to sort in descending order

Hide

Permalink

Nick Klauer added a comment - 26/Nov/10 11:25 PM

Also, while trying without specifying a version at all

klauer@klauer-imac ~/Programming/Ruby/jruby
$ gem install com.google.guava.guava
Installing from Maven using install at /Users/klauer/Programming/Java/maven/bin
ERROR:  Could not find a valid gem 'com.google.guava.guava' (>= 0) in any repository

Show

Nick Klauer added a comment - 26/Nov/10 11:25 PM Also, while trying without specifying a version at all klauer@klauer-imac ~/Programming/Ruby/jruby $ gem install com.google.guava.guava Installing from Maven using install at /Users/klauer/Programming/Java/maven/bin ERROR: Could not find a valid gem 'com.google.guava.guava' (>= 0) in any repository

Hide

Permalink

kristian meier added a comment - 27/Nov/10 2:59 AM

$ gem install com.google.guava.guava -v 0.0.0.r.07

should install the jar.

gem-version can not start with a letter so 0.0.0. gets prepended. then gem-version "0.0.0.r.07" >= "0" gives false.

Show

kristian meier added a comment - 27/Nov/10 2:59 AM $ gem install com.google.guava.guava -v 0.0.0.r.07 should install the jar. gem-version can not start with a letter so 0.0.0. gets prepended. then gem-version "0.0.0.r.07" >= "0" gives false.

Hide

Permalink

kristian meier added a comment - 27/Nov/10 8:10 AM

pushed an fix onto https://github.com/mkristian/jruby/commit/8a991cc8448afe24b4fb616ae6b8391843c2fc0a

Show

kristian meier added a comment - 27/Nov/10 8:10 AM pushed an fix onto https://github.com/mkristian/jruby/commit/8a991cc8448afe24b4fb616ae6b8391843c2fc0a

Hide

Permalink

Hiro Asari added a comment - 05/Dec/10 8:04 PM

Kristian,

I pulled in your commit to the github master in https://github.com/jruby/jruby/commit/9d884767473784982ccb6c28cce84d0d574952af.

(and then merged in 1bd56c1 to the real thing)

However, the version matching doesn't seem quite right.

We can install it if no version number is specified.
We cannot uninstall it because gem can't find (or list) it.
It can still be used.

[system]:jruby[git:master] $ jruby -S gem install com.google.guava.guava -v 0.0.0.r.07
Using Maven install at /Users/asari/Development/src/jruby/lib/ruby/gems/1.8/gems/ruby-maven-0.8.pre.3-java/bin
ERROR:  Could not find a valid gem 'com.google.guava.guava' (= 0.0.0.r.07) in any repository
[system]:jruby[git:master] $ jruby -S gem install com.google.guava.guava 
Using Maven install at /Users/asari/Development/src/jruby/lib/ruby/gems/1.8/gems/ruby-maven-0.8.pre.3-java/bin
Successfully installed com.google.guava.guava-0.0.0.r.07-java
1 gem installed
[system]:jruby[git:master] $ jruby -S gem uninstall com.google.guava.guava
ERROR:  While executing gem ... (Gem::InstallError)
    cannot uninstall, check `gem list -d com.google.guava.guava`
[system]:jruby[git:master] $ jruby -S gem list -d com.google.guava.guava

*** LOCAL GEMS ***


[system]:jruby[git:master] $ jruby -S irb
irb(main):001:0> require 'rubygems'
=> true
irb(main):002:0> require 'maven/com.google.guava/guava'
=> true
irb(main):003:0> exit

Also, could you attach a git patch to the JIRA ticket, rather than pointing to the commit in your fork? It is much easier to work if we had a patch.

Thanks!

Show

Hiro Asari added a comment - 05/Dec/10 8:04 PM Kristian, I pulled in your commit to the github master in https://github.com/jruby/jruby/commit/9d884767473784982ccb6c28cce84d0d574952af . (and then merged in 1bd56c1 to the real thing) However, the version matching doesn't seem quite right. We can install it if no version number is specified. We cannot uninstall it because gem can't find (or list) it. It can still be used. [system]:jruby[git:master] $ jruby -S gem install com.google.guava.guava -v 0.0.0.r.07 Using Maven install at /Users/asari/Development/src/jruby/lib/ruby/gems/1.8/gems/ruby-maven-0.8.pre.3-java/bin ERROR: Could not find a valid gem 'com.google.guava.guava' (= 0.0.0.r.07) in any repository [system]:jruby[git:master] $ jruby -S gem install com.google.guava.guava Using Maven install at /Users/asari/Development/src/jruby/lib/ruby/gems/1.8/gems/ruby-maven-0.8.pre.3-java/bin Successfully installed com.google.guava.guava-0.0.0.r.07-java 1 gem installed [system]:jruby[git:master] $ jruby -S gem uninstall com.google.guava.guava ERROR: While executing gem ... (Gem::InstallError) cannot uninstall, check `gem list -d com.google.guava.guava` [system]:jruby[git:master] $ jruby -S gem list -d com.google.guava.guava *** LOCAL GEMS *** [system]:jruby[git:master] $ jruby -S irb irb(main):001:0> require 'rubygems' => true irb(main):002:0> require 'maven/com.google.guava/guava' => true irb(main):003:0> exit Also, could you attach a git patch to the JIRA ticket, rather than pointing to the commit in your fork? It is much easier to work if we had a patch. Thanks!

Hide

Permalink

kristian meier added a comment - 05/Dec/10 8:52 PM

OK, let's get back to root. maven version is "r07" which gets 'translated' to 0.0.0.r.07 since it is not a valid gems version (which needs start with a number)
rubgems uses ">0" as default all over the place and 0.0.0.r.07 < 0 so it can not 'find' that version anywhere.

so we could use '0.0.1.' as prefix or '1.' or something else ?

Show

kristian meier added a comment - 05/Dec/10 8:52 PM OK, let's get back to root. maven version is "r07" which gets 'translated' to 0.0.0.r.07 since it is not a valid gems version (which needs start with a number) rubgems uses ">0" as default all over the place and 0.0.0.r.07 < 0 so it can not 'find' that version anywhere. so we could use '0.0.1.' as prefix or '1.' or something else ?

Hide

Permalink

Charles Oliver Nutter added a comment - 30/Dec/10 4:44 PM

Hmm, this is an interesting one. The other problem with alphanumeric gems is that RubyGems will always treat them as "prerelease" versions (I think). So Maven artifacts with alphanumeric version numbers could have problems...

I think going with 0.0.1.[alphanumeric version number] is the best we can do for the moment. The differences in the version numbering scheme might be irreconcilable.

Show

Charles Oliver Nutter added a comment - 30/Dec/10 4:44 PM Hmm, this is an interesting one. The other problem with alphanumeric gems is that RubyGems will always treat them as "prerelease" versions (I think). So Maven artifacts with alphanumeric version numbers could have problems... I think going with 0.0.1. [alphanumeric version number] is the best we can do for the moment. The differences in the version numbering scheme might be irreconcilable.

Hide

Permalink

Hiro Asari added a comment - 31/Dec/10 9:46 PM

RubyGems 1.4.1 breaks this.

[system]:jruby[git:master] $ jruby -v -S gem install com.google.guava.guava 
jruby 1.6.0.dev (ruby 1.8.7 patchlevel 249) (2010-12-31 f573207) (Java HotSpot(TM) 64-Bit Server VM 1.6.0_22) [darwin-x86_64-java]
Successfully installed com.google.guava.guava-0.0.0.r.07-java
1 gem installed
[system]:jruby[git:master] $ jruby -v -S gem --version
jruby 1.6.0.dev (ruby 1.8.7 patchlevel 249) (2010-12-31 f573207) (Java HotSpot(TM) 64-Bit Server VM 1.6.0_22) [darwin-x86_64-java]
1.3.7

[system]:jruby[git:master] $ jruby -v -S gem update --system
jruby 1.6.0.dev (ruby 1.8.7 patchlevel 249) (2010-12-31 f573207) (Java HotSpot(TM) 64-Bit Server VM 1.6.0_22) [darwin-x86_64-java]
Updating RubyGems
Updating rubygems-update
Successfully installed rubygems-update-1.4.1
Updating RubyGems to 1.4.1
Installing RubyGems 1.4.1
RubyGems 1.4.1 installed

&#65279;=== 1.4.1 / 2010-12-31

Since apparently nobody reads my emails, blog posts or the README:

DO NOT UPDATE RUBYGEMS ON RUBY 1.9! See UPGRADING.rdoc for details.

Bug fix:

* Specification#load was untainting a frozen string (via `gem build *.spec`)


------------------------------------------------------------------------------

RubyGems installed the following executables:
	/Users/asari/Development/src/jruby/bin/jgem

[system]:jruby[git:master] $ jruby -v -S gem install com.google.guava.guava 
jruby 1.6.0.dev (ruby 1.8.7 patchlevel 249) (2010-12-31 f573207) (Java HotSpot(TM) 64-Bit Server VM 1.6.0_22) [darwin-x86_64-java]
ERROR:  Could not find a valid gem 'com.google.guava.guava' (>= 0) in any repository

Show

Hiro Asari added a comment - 31/Dec/10 9:46 PM RubyGems 1.4.1 breaks this. [system]:jruby[git:master] $ jruby -v -S gem install com.google.guava.guava jruby 1.6.0.dev (ruby 1.8.7 patchlevel 249) (2010-12-31 f573207) (Java HotSpot(TM) 64-Bit Server VM 1.6.0_22) [darwin-x86_64-java] Successfully installed com.google.guava.guava-0.0.0.r.07-java 1 gem installed [system]:jruby[git:master] $ jruby -v -S gem --version jruby 1.6.0.dev (ruby 1.8.7 patchlevel 249) (2010-12-31 f573207) (Java HotSpot(TM) 64-Bit Server VM 1.6.0_22) [darwin-x86_64-java] 1.3.7 [system]:jruby[git:master] $ jruby -v -S gem update --system jruby 1.6.0.dev (ruby 1.8.7 patchlevel 249) (2010-12-31 f573207) (Java HotSpot(TM) 64-Bit Server VM 1.6.0_22) [darwin-x86_64-java] Updating RubyGems Updating rubygems-update Successfully installed rubygems-update-1.4.1 Updating RubyGems to 1.4.1 Installing RubyGems 1.4.1 RubyGems 1.4.1 installed === 1.4.1 / 2010-12-31 Since apparently nobody reads my emails, blog posts or the README: DO NOT UPDATE RUBYGEMS ON RUBY 1.9! See UPGRADING.rdoc for details. Bug fix: * Specification#load was untainting a frozen string (via `gem build *.spec`) ------------------------------------------------------------------------------ RubyGems installed the following executables: /Users/asari/Development/src/jruby/bin/jgem [system]:jruby[git:master] $ jruby -v -S gem install com.google.guava.guava jruby 1.6.0.dev (ruby 1.8.7 patchlevel 249) (2010-12-31 f573207) (Java HotSpot(TM) 64-Bit Server VM 1.6.0_22) [darwin-x86_64-java] ERROR: Could not find a valid gem 'com.google.guava.guava' (>= 0) in any repository

Hide

Permalink

Hiro Asari added a comment - 31/Dec/10 11:51 PM

Strange, but it appears that rubygems-update that's causing problems. maven gems seem to work fine on the master now.

Show

Hiro Asari added a comment - 31/Dec/10 11:51 PM Strange, but it appears that rubygems-update that's causing problems. maven gems seem to work fine on the master now.

Hide

Permalink

Charles Oliver Nutter added a comment - 03/Jan/11 9:10 AM

Hiro: rubygems-update just overwrites all the standard rubygems files, which means the maven logic gets wiped out. When I updated, I went line-by-line to make sure the maven pieces weren't killed. Anyone else doing a manual update would see maven support break, so we'll probably need to consider an alternative change for RubyGems that won't be susceptible to system updating.

Show

Charles Oliver Nutter added a comment - 03/Jan/11 9:10 AM Hiro: rubygems-update just overwrites all the standard rubygems files, which means the maven logic gets wiped out. When I updated, I went line-by-line to make sure the maven pieces weren't killed. Anyone else doing a manual update would see maven support break, so we'll probably need to consider an alternative change for RubyGems that won't be susceptible to system updating.

Hide

Permalink

kristian meier added a comment - 05/Jan/11 11:37 PM

just my two cents: debian does not allow gem update --system and forces the user to use debian way of updating packages. maybe something like this is suitable for jruby as well though I do not know if there is a jruby way of updating things.

Show

kristian meier added a comment - 05/Jan/11 11:37 PM just my two cents: debian does not allow gem update --system and forces the user to use debian way of updating packages. maybe something like this is suitable for jruby as well though I do not know if there is a jruby way of updating things.

Hide

Permalink

Charles Oliver Nutter added a comment - 06/Oct/12 1:58 PM

RubyGems maven support has been removed in 1.7.

Show

Charles Oliver Nutter added a comment - 06/Oct/12 1:58 PM RubyGems maven support has been removed in 1.7.

People

Assignee:

Charles Oliver Nutter

Reporter:

Nick Klauer

Vote (0)

Watch (2)

Dates

Created:

26/Nov/10 11:21 PM

Updated:

06/Oct/12 1:58 PM

Resolved:

06/Oct/12 1:58 PM