JRuby

"5E".to_f behaves differently than MRI

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Critical Critical
  • Resolution: Fixed
  • Affects Version/s: JRuby 1.5.1
  • Fix Version/s: JRuby 1.6RC1
  • Component/s: Core Classes/Modules, Intro
  • Labels:
    None
  • Environment:
    jruby 1.5.1 (ruby 1.8.7 patchlevel 249) (2010-06-06 f3a3480) (Java HotSpot(TM) 64-Bit Server VM 1.6.0_22) [x86_64-java]
  • Number of attachments :
    2

Description

macbeth:~ uwe$ irb
>> "5E".to_f
=> 5.0
>> exit
macbeth:~ uwe$ jirb
>> "5E".to_f
=> 0.0
>> exit
macbeth:~ uwe$

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Hiro Asari added a comment - - edited

Ouch. And "5e".to_f results in NPE.

Show
Hiro Asari added a comment - - edited Ouch. And "5e".to_f results in NPE.
Hide
Permalink
Hiro Asari added a comment -

Marking as "Intro". I have a fix, but I decided to solicit some contribution from the community.

Show
Hiro Asari added a comment - Marking as "Intro". I have a fix, but I decided to solicit some contribution from the community.
Hide
Permalink
Thomas E Enebo added a comment -

Even though I introduced this bug in converting ConvertDouble to a simple descent parser, it still warms my heart that fixing a bug in the code is marked "intro". It tells me the pain of rewriting the original was worth it

Getting off my emotional soap-box....We should probably add two specs to rubyspec for these new to_f discoveries.

Show
Thomas E Enebo added a comment - Even though I introduced this bug in converting ConvertDouble to a simple descent parser, it still warms my heart that fixing a bug in the code is marked "intro". It tells me the pain of rewriting the original was worth it Getting off my emotional soap-box....We should probably add two specs to rubyspec for these new to_f discoveries.
Hide
Permalink
Michael Kohl added a comment -

This patch seems to fix it for me and also makes "5e" and "5E" behave the same way. I don't usually do Java, so am not sure if this is the best way to do this.

This was fun

Show
Michael Kohl added a comment - This patch seems to fix it for me and also makes "5e" and "5E" behave the same way. I don't usually do Java, so am not sure if this is the best way to do this. This was fun
Hide
Permalink
Douglas Campos added a comment -

rubyspec tests

Show
Douglas Campos added a comment - rubyspec tests
Hide
Permalink
Douglas Campos added a comment -

I messed up, this belongs to String.to_f

patch updated

Show
Douglas Campos added a comment - I messed up, this belongs to String.to_f patch updated
Hide
Permalink
Hiro Asari added a comment -

Pushed Michael's fix to master in 1867d81. Douglas' specs were merge to RubySpec master in 0b4ac77.

Thanks, guys!

Show
Hiro Asari added a comment - Pushed Michael's fix to master in 1867d81 . Douglas' specs were merge to RubySpec master in 0b4ac77 . Thanks, guys!

People

  • Assignee:
    Hiro Asari
    Reporter:
    Uwe Kubosch
Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved: