JRuby

File.expand_path doesn't handle classpath paths correctly

Details

  • Type: Bug Bug
  • Status: Resolved Resolved
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: None
  • Fix Version/s: None
  • Component/s: None
  • Labels:
    None
  • Number of attachments :
    0

Description

If doing a File.expand_path on a path beginning with "classpath:" it won't do the "right" thing.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Ola Bini added a comment -

The classpath thing also means things like globbing in Jar-files, that used to work, no longer works.

Show
Ola Bini added a comment - The classpath thing also means things like globbing in Jar-files, that used to work, no longer works.
Hide
Permalink
Charles Oliver Nutter added a comment -

We need a better abstraction of the URL forms we will glob against. Right now we have various combinations of "file:" and "jar:" URLs sprinkled all over the codebase, and adding "classpath:" now fails to trigger the file/jar URL logic.

I'm curious why none of our jar globbing tests are failing as a result of this. Do you have a simple example that breaks now?

Show
Charles Oliver Nutter added a comment - We need a better abstraction of the URL forms we will glob against. Right now we have various combinations of "file:" and "jar:" URLs sprinkled all over the codebase, and adding "classpath:" now fails to trigger the file/jar URL logic. I'm curious why none of our jar globbing tests are failing as a result of this. Do you have a simple example that breaks now?
Hide
Permalink
Charles Oliver Nutter added a comment -

Fixed at some point.

system ~/projects/jruby $ jruby -e "p File.expand_path('classpath:jruby/jruby.rb')"
"/Users/headius/projects/jruby/classpath:jruby/jruby.rb"
Show
Charles Oliver Nutter added a comment - Fixed at some point. system ~/projects/jruby $ jruby -e "p File.expand_path('classpath:jruby/jruby.rb')" "/Users/headius/projects/jruby/classpath:jruby/jruby.rb"

People

  • Assignee:
    Charles Oliver Nutter
    Reporter:
    Ola Bini
Vote (1)
Watch (2)

Dates

  • Created:
    Updated:
    Resolved: