Details

    • Type: Improvement Improvement
    • Status: Resolved Resolved
    • Priority: Critical Critical
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: JRuby 1.7.0.pre1
    • Component/s: Extensions, OpenSSL
    • Labels:
      None
    • Environment:
      N/A
    • Number of attachments :
      0

      Description

      Merge JRuby-OSSL to JRuby.

      • no BC jars inclusion.
      • works without warnings as to the extent possible.
      • warns when user tries to use some features which depends BC jars.
      • no warnings after installing bouncy-castle-java gem.

      Discussion at jruby-user ML:

        Activity

        Hide
        Hiroshi Nakamura added a comment -

        Here's the merge policy.

        • Do not add BC jars in JRuby distribution
        • Should detect BC jars when rubygems is loaded and bouncy-castle-java is installed as a gem
        • Do not require rubygems automatically: even if bouncy-castle-java gem is installed
          % jruby -S gem install bouncy-castle-java
          % jruby -ropenssl -e ‘p OpenSSL::SSL’ => Error
          % jruby -rubygems -ropenssl -e ‘p OpenSSL::SSL’ => OK
          

        Done almost in ossl branch. I'll merge it before 1.6.

        Show
        Hiroshi Nakamura added a comment - Here's the merge policy. Do not add BC jars in JRuby distribution Should detect BC jars when rubygems is loaded and bouncy-castle-java is installed as a gem Do not require rubygems automatically: even if bouncy-castle-java gem is installed % jruby -S gem install bouncy-castle-java % jruby -ropenssl -e ‘p OpenSSL::SSL’ => Error % jruby -rubygems -ropenssl -e ‘p OpenSSL::SSL’ => OK Done almost in ossl branch. I'll merge it before 1.6.
        Hide
        Charles Oliver Nutter added a comment -

        So if I understand right, rubygems must be loaded and bouncy-castle-java gem must be installed for OpenSSL::SSL to work properly?

        Show
        Charles Oliver Nutter added a comment - So if I understand right, rubygems must be loaded and bouncy-castle-java gem must be installed for OpenSSL::SSL to work properly?
        Hide
        Duncan Mak added a comment -

        I checked out the ossl branch. It looks like a lot of work is already in place. What's missing?

        Show
        Duncan Mak added a comment - I checked out the ossl branch. It looks like a lot of work is already in place. What's missing?
        Hide
        Hiroshi Nakamura added a comment -

        Charles began the work.

        Show
        Hiroshi Nakamura added a comment - Charles began the work.
        Hide
        Hiroshi Nakamura added a comment -

        Charles's branch: https://github.com/headius/jruby/tree/builtin_ssl
        Squashed merge commit (for easily reversion): https://github.com/jruby/jruby/commit/82f049beaca8f0f69e191c7bc2da0c32879c7ddb

        I'm clearing me from assignee because the merge is already happened. Possibly it's OK to close.

        Show
        Hiroshi Nakamura added a comment - Charles's branch: https://github.com/headius/jruby/tree/builtin_ssl Squashed merge commit (for easily reversion): https://github.com/jruby/jruby/commit/82f049beaca8f0f69e191c7bc2da0c32879c7ddb I'm clearing me from assignee because the merge is already happened. Possibly it's OK to close.
        Hide
        Charles Oliver Nutter added a comment -

        I merged everything to master, and this will go out with 1.7. Any additional issues should be filed separately.

        Show
        Charles Oliver Nutter added a comment - I merged everything to master, and this will go out with 1.7. Any additional issues should be filed separately.

          People

          • Assignee:
            Charles Oliver Nutter
            Reporter:
            Hiroshi Nakamura
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: