JRuby

Too many open files when using imap over ssl

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Duplicate
  • Affects Version/s: JRuby 1.5.1
  • Fix Version/s: None
  • Component/s: Ruby 1.8.7
  • Labels:
    None
  • Environment:
  • Testcase included:
    yes
  • Number of attachments :
    1

Description

When connecting to imap over ssl, jruby eventually throws an error

OpenSSL::SSL::SSLError: Too many open files
from /Users/karl/.rvm/rubies/jruby-1.5.1/lib/ruby/1.8/net/imap.rb:904:in `initialize'
from (irb):4:in `new'
from (irb):4

The following code snippet reproduces the problem:

require 'net/imap'
10000.times.each do |i|
puts "connection #

{i}

"
imap = Net::IMAP.new('imap.gmail.com', 993, true)
imap.disconnect
end

This problem does not occur on MRI or REE.

thx

Issue Links

duplicates

Bug - A problem which impairs or prevents the functions of the product. JRUBY-5018 SSLSocket holds selectors, keys, preventing quick cleanup of resources when dereferenced

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Antoine Toulme added a comment -

I modified the script as follows:

10000.times.each do |i|
puts "connection #

{i}"
imap = Net::IMAP.new('imap.gmail.com', 993, true)
imap.disconnect
`lsof > imap-#{i}

.txt` if (i % 1000) == 0
end

Attaching the output.

Show
Antoine Toulme added a comment - I modified the script as follows: 10000.times.each do |i| puts "connection # {i}" imap = Net::IMAP.new('imap.gmail.com', 993, true) imap.disconnect `lsof > imap-#{i} .txt` if (i % 1000) == 0 end Attaching the output.
Hide
Permalink
Antoine Toulme added a comment -

Here is an explanation of the problem:

require 'net/imap'
imap = Net::IMAP.new('imap.gmail.com', 993, true)
imap.disconnect
imap.disconnected?

The last line returns false. It looks like the disconnect doesn't happen.

Show
Antoine Toulme added a comment - Here is an explanation of the problem: require 'net/imap' imap = Net::IMAP.new('imap.gmail.com', 993, true) imap.disconnect imap.disconnected? The last line returns false. It looks like the disconnect doesn't happen.
Hide
Permalink
Antoine Toulme added a comment -

I took a look at the code of jruby-openssl and it looks like the SocketChannel c is never closed:
http://github.com/jruby/jruby-ossl/blob/master/src/java/org/jruby/ext/openssl/SSLSocket.java

I would recommend closing it when closing the connection. I'll give it a go.

Show
Antoine Toulme added a comment - I took a look at the code of jruby-openssl and it looks like the SocketChannel c is never closed: http://github.com/jruby/jruby-ossl/blob/master/src/java/org/jruby/ext/openssl/SSLSocket.java I would recommend closing it when closing the connection. I'll give it a go.
Hide
Permalink
Charles Oliver Nutter added a comment -

Thanks for the analysis, Antoine...I think we were investigating this bug at the same time

I filed JRUBY-5018 for my analysis and fix. Have a look there and see if you agree with my assessment and fix. There's also a patched jruby-openssl-0.7.2.dev.gem you can use to test whether your issues are fixed.

Show
Charles Oliver Nutter added a comment - Thanks for the analysis, Antoine...I think we were investigating this bug at the same time I filed JRUBY-5018 for my analysis and fix. Have a look there and see if you agree with my assessment and fix. There's also a patched jruby-openssl-0.7.2.dev.gem you can use to test whether your issues are fixed.
Hide
Permalink
Antoine Toulme added a comment -

Charlie, does your fix fixes the disconnected? call ? Right now it returns false. I guess I could try tonight.

Show
Antoine Toulme added a comment - Charlie, does your fix fixes the disconnected? call ? Right now it returns false. I guess I could try tonight.
Hide
Permalink
Hiroshi Nakamura added a comment -

Just a note: See JRUBY-5019 for disconnected? issue.

Show
Hiroshi Nakamura added a comment - Just a note: See JRUBY-5019 for disconnected? issue.

People

  • Assignee:
    Charles Oliver Nutter
    Reporter:
    Karl Baum
Vote (2)
Watch (2)

Dates

  • Created:
    Updated:
    Resolved: