JRuby

[19] Time.new can accept parameters

Details

  • Number of attachments :
    0

Description

Time.new can now accept parameters in which I suspect is the same as Time.local now (haven't checked).

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Hiro Asari added a comment -

I pushed an attempt to the master

Time.local already takes variable number of parameters, but its behavior changed. The year was assumed to be in 1969-2038 range in 1.8.x, but that's no longer the case.

$ ruby -v -e 'p Time.local(1,2,3,4,5,6,7,8)'
ruby 1.8.7 (2009-06-12 patchlevel 174) [universal-darwin10.0]
-e:1: warning: 2 digits year is used
Sat Feb 03 04:05:06 -0500 2001
$ ruby1.9 -v -e 'p Time.local(1,2,3,4,5,6,7,8)'
ruby 1.9.3dev (2010-08-27 trunk 29108) [x86_64-darwin10.4.0]
0001-02-03 04:05:06 -0500

Also, with MRI, it is possible to create an instance of Time with no time zone:

$ ruby1.9 -v -e 'p Time.new(1,2,3,4,5,6,0).zone'
ruby 1.9.3dev (2010-08-31 trunk 29154) [x86_64-darwin10.4.0]
nil
$ ruby1.9 -v -e 'p Time.new(1,2,3,4,5,6,"+00:00").zone'
ruby 1.9.3dev (2010-08-31 trunk 29154) [x86_64-darwin10.4.0]
nil

but I don't think this is possible with joda-time. (At least, I couldn't find a way to do it.)

Show
Hiro Asari added a comment - I pushed an attempt to the master Time.local already takes variable number of parameters, but its behavior changed. The year was assumed to be in 1969-2038 range in 1.8.x, but that's no longer the case. $ ruby -v -e 'p Time.local(1,2,3,4,5,6,7,8)' ruby 1.8.7 (2009-06-12 patchlevel 174) [universal-darwin10.0] -e:1: warning: 2 digits year is used Sat Feb 03 04:05:06 -0500 2001 $ ruby1.9 -v -e 'p Time.local(1,2,3,4,5,6,7,8)' ruby 1.9.3dev (2010-08-27 trunk 29108) [x86_64-darwin10.4.0] 0001-02-03 04:05:06 -0500 Also, with MRI, it is possible to create an instance of Time with no time zone: $ ruby1.9 -v -e 'p Time.new(1,2,3,4,5,6,0).zone' ruby 1.9.3dev (2010-08-31 trunk 29154) [x86_64-darwin10.4.0] nil $ ruby1.9 -v -e 'p Time.new(1,2,3,4,5,6,"+00:00").zone' ruby 1.9.3dev (2010-08-31 trunk 29154) [x86_64-darwin10.4.0] nil but I don't think this is possible with joda-time. (At least, I couldn't find a way to do it.)
Hide
Permalink
Charles Oliver Nutter added a comment -

commit dcf1146839aaf05ecd7ce7da940e39ade77addef
Author: Charles Oliver Nutter <headius@headius.com>
Date: Fri Oct 22 13:41:08 2010 -0500

Fix for JRUBY-5008: [19] Time.new can accept parameters

Show
Charles Oliver Nutter added a comment - commit dcf1146839aaf05ecd7ce7da940e39ade77addef Author: Charles Oliver Nutter <headius@headius.com> Date: Fri Oct 22 13:41:08 2010 -0500 Fix for JRUBY-5008 : [19] Time.new can accept parameters
Hide
Permalink
Guilherme Garnier added a comment -

Is this really fixed in JRuby 1.6RC1? I'm getting the same error in this version as in JRuby 1.5.5:

D:\>jruby -version
jruby 1.6.0.RC1 (ruby 1.8.7 patchlevel 330) (2011-01-10 769f847) (Java HotSpot(TM) Client VM 1.6.0_16) [Windows XP-x86-java]
-e:1:in `(root)': undefined local variable or method `rsion' for main:Object (NameError)

D:\>jirb
irb(main):001:0> t = Time.new
=> Tue Feb 08 08:14:44 -0200 2011
irb(main):002:0> t = Time.new('2011-01-01')
ArgumentError: wrong number of arguments (1 for 0)
from (irb):2:in `evaluate'
from org/jruby/RubyKernel.java:1091:in `eval'
from D:/jruby-1.6.0.RC1/lib/ruby/1.8/irb.rb:158:in `eval_input'
from D:/jruby-1.6.0.RC1/lib/ruby/1.8/irb.rb:271:in `signal_status'
from D:/jruby-1.6.0.RC1/lib/ruby/1.8/irb.rb:155:in `eval_input'
from org/jruby/RubyKernel.java:1421:in `loop'
from org/jruby/RubyKernel.java:1194:in `rbCatch'
from D:/jruby-1.6.0.RC1/lib/ruby/1.8/irb.rb:154:in `eval_input'
from D:/jruby-1.6.0.RC1/lib/ruby/1.8/irb.rb:71:in `start'
from org/jruby/RubyKernel.java:1194:in `rbCatch'
from D:/jruby-1.6.0.RC1/lib/ruby/1.8/irb.rb:70:in `start'

I've tested this in Windows XP and Ubuntu 10.10, and had the same problem in both.

Show
Guilherme Garnier added a comment - Is this really fixed in JRuby 1.6RC1? I'm getting the same error in this version as in JRuby 1.5.5: D:\>jruby -version jruby 1.6.0.RC1 (ruby 1.8.7 patchlevel 330) (2011-01-10 769f847) (Java HotSpot(TM) Client VM 1.6.0_16) [Windows XP-x86-java] -e:1:in `(root)': undefined local variable or method `rsion' for main:Object (NameError) D:\>jirb irb(main):001:0> t = Time.new => Tue Feb 08 08:14:44 -0200 2011 irb(main):002:0> t = Time.new('2011-01-01') ArgumentError: wrong number of arguments (1 for 0) from (irb):2:in `evaluate' from org/jruby/RubyKernel.java:1091:in `eval' from D:/jruby-1.6.0.RC1/lib/ruby/1.8/irb.rb:158:in `eval_input' from D:/jruby-1.6.0.RC1/lib/ruby/1.8/irb.rb:271:in `signal_status' from D:/jruby-1.6.0.RC1/lib/ruby/1.8/irb.rb:155:in `eval_input' from org/jruby/RubyKernel.java:1421:in `loop' from org/jruby/RubyKernel.java:1194:in `rbCatch' from D:/jruby-1.6.0.RC1/lib/ruby/1.8/irb.rb:154:in `eval_input' from D:/jruby-1.6.0.RC1/lib/ruby/1.8/irb.rb:71:in `start' from org/jruby/RubyKernel.java:1194:in `rbCatch' from D:/jruby-1.6.0.RC1/lib/ruby/1.8/irb.rb:70:in `start' I've tested this in Windows XP and Ubuntu 10.10, and had the same problem in both.
Hide
Permalink
Thomas E Enebo added a comment -

Ruby 1.8.7 does not accept a single string parameter like you used above. The string version is only for --1.9 support in JRuby. There was a mention earlier in the bug about year shifting from 2 digit based on recent history to 4 digit, but I am unsure if that was addressed in this issue. If that is still outstanding it should be opened up as a new issue since they were both different issues.

Show
Thomas E Enebo added a comment - Ruby 1.8.7 does not accept a single string parameter like you used above. The string version is only for --1.9 support in JRuby. There was a mention earlier in the bug about year shifting from 2 digit based on recent history to 4 digit, but I am unsure if that was addressed in this issue. If that is still outstanding it should be opened up as a new issue since they were both different issues.

People

  • Assignee:
    Charles Oliver Nutter
    Reporter:
    Thomas E Enebo
Vote (0)
Watch (2)

Dates

  • Created:
    Updated:
    Resolved: