JRuby

JSR-223 ScriptEngine ignores global bindings

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: JRuby 1.5.1
  • Fix Version/s: JRuby 1.5.3
  • Component/s: Embedding
  • Labels:
    None
  • Number of attachments :
    1

Description

Global variables defined in the script engine's global bindings are not accessible. It doesn't matter if the bindings are set with scriptEngineManager.setBindings(globalBindings) or scriptEngine.setBindings(globalBindings, ScriptContext.GLOBAL_SCOPE). In either case, the bindings seem to be ignored.

I'm attaching an executable Java class that illustrates this problem.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Yoko Harada added a comment -

Thanks for reporting this. I just want to make sure since the key-value pair was set to the bindings of GLOBAL_SCOPE. My understanding is that all eval() methods should see bindings of ENGINE_SCOPE unless GLOBAL_SCOPE of bindings are given explicitly. In the provided code, bindings are implicitly referenced, so just ENGINE_SCOPE should be referenced. Is my understanding wrong? Does the GLOBAL_SCOPE key-value pair work while evaluating in other languages?

Show
Yoko Harada added a comment - Thanks for reporting this. I just want to make sure since the key-value pair was set to the bindings of GLOBAL_SCOPE. My understanding is that all eval() methods should see bindings of ENGINE_SCOPE unless GLOBAL_SCOPE of bindings are given explicitly. In the provided code, bindings are implicitly referenced, so just ENGINE_SCOPE should be referenced. Is my understanding wrong? Does the GLOBAL_SCOPE key-value pair work while evaluating in other languages?
Hide
Permalink
Michael S. Allman added a comment -

Yoko,

I believe the answer to your questions comes from sections SCR.4.3.4.1.2 and SCR.4.3.1 of the JSR-223 spec. From the former, I quote:

<quote>
In the eval methods taking a single argument, the default ScriptContext of the ScriptEngine is used during execution of the script.
</quote>

There are one engine and one global bindings associated with each ScriptContext.

From the latter section I quote:

<quote>
The method getAttribute(String) returns getAttribute(String, int) for the lowest scope in which it returns a non-null value.
</quote>

Finally, to answer your last question, I can tell you from experience that Rhino (the JavaScript implementation) does indeed delegate lookups for bound properties from the engine to global scope as necessary, even with the single-argument eval() method.

Cheers.

Show
Michael S. Allman added a comment - Yoko, I believe the answer to your questions comes from sections SCR.4.3.4.1.2 and SCR.4.3.1 of the JSR-223 spec. From the former, I quote: <quote> In the eval methods taking a single argument, the default ScriptContext of the ScriptEngine is used during execution of the script. </quote> There are one engine and one global bindings associated with each ScriptContext. From the latter section I quote: <quote> The method getAttribute(String) returns getAttribute(String, int) for the lowest scope in which it returns a non-null value. </quote> Finally, to answer your last question, I can tell you from experience that Rhino (the JavaScript implementation) does indeed delegate lookups for bound properties from the engine to global scope as necessary, even with the single-argument eval() method. Cheers.
Hide
Permalink
Yoko Harada added a comment -

I fixed this in rev 2d90a9ad30bec0699fffd8c55009ddd55fd375b6 for jruby-1_5 branch and 780f1dda3938773ad5cfe2ab4c8cf878a5d2f051 for master branch. So, upcoming JRuby 1.5.3 should not have this issue.
Thanks for explaining about this.

Show
Yoko Harada added a comment - I fixed this in rev 2d90a9ad30bec0699fffd8c55009ddd55fd375b6 for jruby-1_5 branch and 780f1dda3938773ad5cfe2ab4c8cf878a5d2f051 for master branch. So, upcoming JRuby 1.5.3 should not have this issue. Thanks for explaining about this.
Hide
Permalink
Yoko Harada added a comment -

Fixed.

Show
Yoko Harada added a comment - Fixed.
Hide
Permalink
Michael S. Allman added a comment -

Awesome, Yoko. Thanks so much.

Show
Michael S. Allman added a comment - Awesome, Yoko. Thanks so much.

People

  • Assignee:
    Yoko Harada
    Reporter:
    Michael S. Allman
Vote (0)
Watch (2)

Dates

  • Created:
    Updated:
    Resolved: