[windows] File.size is completely broken on Windows

Details

Type: Bug
Status: Resolved
Priority: Major
Resolution: Fixed
Affects Version/s: JRuby 1.5
Fix Version/s: JRuby 1.7.4
Component/s: Core Classes/Modules, Ruby 1.9.2, RubySpec, Windows
Labels:
None
Environment:
Windows

Testcase included:
yes
Number of attachments :
0

Description

jruby --1.9 -ve "p File.new('README').size"
jruby 1.6.0.dev (ruby 1.9.2dev trunk -1) (2010-05-24 6be8758) (Java HotSpot(TM) Client VM 1.6.0_20) [x86-java]
-e:1:in `size': No such file or directory - -1 (Errno::ENOENT)
        from -e:1

This also leads to a bunch of RubySpec failures in 1.9 mode. Will fix.

mspec ci -tj -T --1.9 core\file\size_spec.rb
jruby 1.6.0.dev (ruby 1.9.2dev trunk -1) (2010-05-24 6be8758) (Java HotSpot(TM) Client VM 1.6.0_20) [x86-java]
.........EEEEE

1)
File#size returns the file's size as a Fixnum ERROR
Errno::ENOENT: No such file or directory - -1
D:/work/jruby-dev/rubyspec.git/core/file/size_spec.rb:56:in `size'
D:/work/jruby-dev/rubyspec.git/core/file/size_spec.rb:56
D:/work/jruby-dev/rubyspec.git/core/file/size_spec.rb:37
D:/work/jruby-dev/rubyspec.git/core/file/size_spec.rb:36
D:/work/jruby-dev/rubyspec.git/core/file/size_spec.rb:56:in `load'
D:/work/jruby-dev/mspec.git/bin/mspec-ci:8

2)
File#size returns the file's size in bytes ERROR
Errno::ENOENT: No such file or directory - -1
D:/work/jruby-dev/rubyspec.git/core/file/size_spec.rb:60:in `size'
D:/work/jruby-dev/rubyspec.git/core/file/size_spec.rb:60
D:/work/jruby-dev/rubyspec.git/core/file/size_spec.rb:37
D:/work/jruby-dev/rubyspec.git/core/file/size_spec.rb:36
D:/work/jruby-dev/rubyspec.git/core/file/size_spec.rb:56:in `load'
D:/work/jruby-dev/mspec.git/bin/mspec-ci:8

3)
File#size returns the cached size of the file if subsequently deleted ERROR
Errno::EACCES: Permission denied - D:/work/jruby-dev/rubyspec.git/rubyspec_temp/12-i_exist
D:/work/jruby-dev/rubyspec.git/core/file/size_spec.rb:64
D:/work/jruby-dev/rubyspec.git/core/file/size_spec.rb:37
D:/work/jruby-dev/rubyspec.git/core/file/size_spec.rb:36
D:/work/jruby-dev/rubyspec.git/core/file/size_spec.rb:56:in `load'
D:/work/jruby-dev/mspec.git/bin/mspec-ci:8

4)
File#size returns the file's current size even if modified ERROR
Errno::ENOENT: No such file or directory - -1
D:/work/jruby-dev/rubyspec.git/core/file/size_spec.rb:70:in `size'
D:/work/jruby-dev/rubyspec.git/core/file/size_spec.rb:70
D:/work/jruby-dev/rubyspec.git/core/file/size_spec.rb:37
D:/work/jruby-dev/rubyspec.git/core/file/size_spec.rb:36
D:/work/jruby-dev/rubyspec.git/core/file/size_spec.rb:56:in `load'
D:/work/jruby-dev/mspec.git/bin/mspec-ci:8

5)
File#size returns 0 for an empty file ERROR
Errno::ENOENT: No such file or directory - -1
D:/work/jruby-dev/rubyspec.git/core/file/size_spec.rb:76:in `size'
D:/work/jruby-dev/rubyspec.git/core/file/size_spec.rb:76
D:/work/jruby-dev/rubyspec.git/core/file/size_spec.rb:37
D:/work/jruby-dev/rubyspec.git/core/file/size_spec.rb:36
D:/work/jruby-dev/rubyspec.git/core/file/size_spec.rb:56:in `load'
D:/work/jruby-dev/mspec.git/bin/mspec-ci:8

6)
An exception occurred during: after :each
File#size returns 0 for an empty file ERROR
Errno::EACCES: Permission denied - D:/work/jruby-dev/rubyspec.git/rubyspec_temp/14-i_exist
D:/work/jruby-dev/rubyspec.git/core/file/size_spec.rb:48
D:/work/jruby-dev/rubyspec.git/core/file/size_spec.rb:37
D:/work/jruby-dev/rubyspec.git/core/file/size_spec.rb:36
D:/work/jruby-dev/rubyspec.git/core/file/size_spec.rb:56:in `load'
D:/work/jruby-dev/mspec.git/bin/mspec-ci:8

Finished in 0.104000 seconds

1 file, 14 examples, 9 expectations, 0 failures, 6 errors

Issue Links

relates to

JRUBY-4149 [windows] JRuby reports wrong file sizes when native support is enabled

Activity

Ascending order - Click to sort in descending order

Hide

Permalink

Vladimir Sizikov added a comment - 24/May/10 8:35 AM

We need a functioning jnr-posix's fstat() on Windows, since that's the reason why File.size fails. See also ~~JRUBY-4149~~.

Show

Vladimir Sizikov added a comment - 24/May/10 8:35 AM We need a functioning jnr-posix's fstat() on Windows, since that's the reason why File.size fails. See also JRUBY-4149 .

Vladimir Sizikov made changes - 24/May/10 8:36 AM

Field	Original Value	New Value
Link		This issue relates to ~~JRUBY-4149~~ [ ~~JRUBY-4149~~ ]

Hide

Permalink

Roger Pack added a comment - 13/Jan/11 12:14 PM

looks like this is still the case.

C:\dev\ruby\downloads\jruby>bin\jruby --1.9 -ve "p File.new('README').size"
jruby 1.6.0.RC1 (ruby 1.9.2 patchlevel 136) (2011-01-13 75ced7c) (Java HotSpot(TM) Client VM 1.6.0_18) [Windows 7-x86-java]
org/jruby/RubyFile.java:1751:in `size': No such file or directory - -1 (Errno::ENOENT)
from -e:1:in `(root)'

Show

Roger Pack added a comment - 13/Jan/11 12:14 PM looks like this is still the case. C:\dev\ruby\downloads\jruby>bin\jruby --1.9 -ve "p File.new('README').size" jruby 1.6.0.RC1 (ruby 1.9.2 patchlevel 136) (2011-01-13 75ced7c) (Java HotSpot(TM) Client VM 1.6.0_18) [Windows 7-x86-java] org/jruby/RubyFile.java:1751:in `size': No such file or directory - -1 (Errno::ENOENT) from -e:1:in `(root)'

Hide

Permalink

Doug Hathaway added a comment - 19/Sep/11 2:56 PM

Confirmed still broken in 1.6.4

$ jruby --1.9 -ve "p File.new('README').size"
jruby 1.6.4 (ruby-1.9.2-p136) (2011-08-23 17ea768) (Java HotSpot(TM) 64-Bit Server VM 1.6.0_25) [Windows 7-amd64-java]
Errno::ENOENT: No such file or directory - -1
size at org/jruby/RubyFile.java:1816
(root) at -e:1

Show

Doug Hathaway added a comment - 19/Sep/11 2:56 PM Confirmed still broken in 1.6.4 $ jruby --1.9 -ve "p File.new('README').size" jruby 1.6.4 (ruby-1.9.2-p136) (2011-08-23 17ea768) (Java HotSpot(TM) 64-Bit Server VM 1.6.0_25) [Windows 7-amd64-java] Errno::ENOENT: No such file or directory - -1 size at org/jruby/RubyFile.java:1816 (root) at -e:1

Hide

Permalink

Charles Oliver Nutter added a comment - 06/Oct/12 1:12 PM

Optimistically calling this fixed, since we have specs running on Windows now (right?) and have done several rounds of fixes and improvements to native support since this bug was last updated.

Show

Charles Oliver Nutter added a comment - 06/Oct/12 1:12 PM Optimistically calling this fixed, since we have specs running on Windows now (right?) and have done several rounds of fixes and improvements to native support since this bug was last updated.

Charles Oliver Nutter made changes - 06/Oct/12 1:12 PM

Status	Open [ 1 ]	Resolved [ 5 ]
Assignee	Vladimir Sizikov [ vvs ]	Charles Oliver Nutter [ headius ]
Resolution		Fixed [ 1 ]

Hide

Permalink

a bc added a comment - 22/Mar/13 8:56 PM

hit this issue on latest Jruby1.7.3 and rails 3.2.11 and windows7.
it's a basic function, should be used by many libraries/applications.

Show

a bc added a comment - 22/Mar/13 8:56 PM hit this issue on latest Jruby1.7.3 and rails 3.2.11 and windows7. it's a basic function, should be used by many libraries/applications.

Hide

Permalink

Thomas E Enebo added a comment - 25/Mar/13 10:02 AM

Re-opening to make sure we reexamine this. I did not see any actual confirmation originally that this was fixed.

Show

Thomas E Enebo added a comment - 25/Mar/13 10:02 AM Re-opening to make sure we reexamine this. I did not see any actual confirmation originally that this was fixed.

Thomas E Enebo made changes - 25/Mar/13 10:02 AM

Resolution	Fixed [ 1 ]
Status	Resolved [ 5 ]	Reopened [ 4 ]

Hide

Permalink

Thomas E Enebo added a comment - 25/Apr/13 2:08 PM

This should be fixed in commit 27f00a9. fstat() as implemented in jnr-posix was calling the unix fd extraction method. On windows we needed to get the HANDLE out of FileDescriptor then open via _osf_openHandle(HANDLE) + _close when done. Seemed to work first try.

Please try this out and reopen if you find this is not working. My only big concern (and this concern overlaps into stat and lstat) is that we seem to be using the 32 bit stat struct. Seems like Windows has like 6 types of stat structs now

Show

Thomas E Enebo added a comment - 25/Apr/13 2:08 PM This should be fixed in commit 27f00a9. fstat() as implemented in jnr-posix was calling the unix fd extraction method. On windows we needed to get the HANDLE out of FileDescriptor then open via _osf_openHandle(HANDLE) + _close when done. Seemed to work first try. Please try this out and reopen if you find this is not working. My only big concern (and this concern overlaps into stat and lstat) is that we seem to be using the 32 bit stat struct. Seems like Windows has like 6 types of stat structs now

Hide

Permalink

Thomas E Enebo added a comment - 25/Apr/13 2:09 PM

See last comment on what was changed and please test to confirm for your Windows variant...

Fixed in commit 27f00a9

Show

Thomas E Enebo added a comment - 25/Apr/13 2:09 PM See last comment on what was changed and please test to confirm for your Windows variant... Fixed in commit 27f00a9

Thomas E Enebo made changes - 25/Apr/13 2:09 PM

Status	Reopened [ 4 ]	Resolved [ 5 ]
Assignee	Charles Oliver Nutter [ headius ]	Thomas E Enebo [ enebo ]
Fix Version/s		JRuby 1.7.4 [ 19106 ]
Resolution		Fixed [ 1 ]

People

Assignee:

Thomas E Enebo

Reporter:

Vladimir Sizikov

Vote (2)

Watch (4)

Dates

Created:

24/May/10 8:34 AM

Updated:

25/Apr/13 2:09 PM

Resolved:

25/Apr/13 2:09 PM