JRuby

Digest::Class.digest should accept a variable number of arguments

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: JRuby 1.5
  • Fix Version/s: JRuby 1.6RC1
  • Component/s: Standard Library
  • Labels:
    None
  • Environment:
    OS X 10.5.6, rvm + jruby 1.5.0
  • Number of attachments :
    1

Description

When trying to use a Digest::Class extension (specifically Ruby 1.9's pure ruby implementation of Digest::HMAC) we get an argument error because Digest::HMAC.digest throws an ArgumentError.

http://gist.github.com/406352

The reason is that Digest::Class.digest should accept a variable number of arguments that get passed to the Digest::Class's initialize (see http://ruby-doc.org/stdlib/libdoc/digest/rdoc/classes/Digest/Class.html#M000450)

I believe the issue is L362 here: http://gist.github.com/406400

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
David Calavera added a comment -

This tiny patch solves the problem.

On the other hand, I've seen that the ruby core has a test file for Digest that we don't include: test/digest/test_digest_extend.rb

I don't want to send a patch to include it and I don't know how the external tests have been syncronized right now, by hand I suspect. We could use the same way the stdlib is syncronizing now with the cloned repositories.

Show
David Calavera added a comment - This tiny patch solves the problem. On the other hand, I've seen that the ruby core has a test file for Digest that we don't include: test/digest/test_digest_extend.rb I don't want to send a patch to include it and I don't know how the external tests have been syncronized right now, by hand I suspect. We could use the same way the stdlib is syncronizing now with the cloned repositories.
Hide
Permalink
Aaron Quint added a comment -

Thanks David!

Show
Aaron Quint added a comment - Thanks David!
Hide
Permalink
David Calavera added a comment -

pushed in 63d2150

Show
David Calavera added a comment - pushed in 63d2150
Hide
Permalink
Dennis Rognius added a comment -

what is the release status for this? is there any minor release in 1.5 that include this fix?

Show
Dennis Rognius added a comment - what is the release status for this? is there any minor release in 1.5 that include this fix?
Hide
Permalink
Hiro Asari added a comment -

David's patch has not been applied in the 1.5 branch. Making this point clear by assigning the "Fix Version".

Show
Hiro Asari added a comment - David's patch has not been applied in the 1.5 branch. Making this point clear by assigning the "Fix Version".
Hide
Permalink
Hiroshi Nakamura added a comment -

David's fix is [master 63d2150ff4d9c6f47bf189ff68732b0a72a9232a]. This original bug causes OAuth gem raising exception on JRuby 1.5.6

0% jruby15 -rubygems -e 'require "oauth"; p Digest::HMAC.digest("", "", Digest::SHA1)'
-e:1: wrong # of arguments(3 for 2) (ArgumentError)
1% jruby -rubygems -e 'require "oauth"; p Digest::HMAC.digest("", "", Digest::SHA1)' 
"\373\333\035\e\030\252l\b2K}d\267\037\267cpi\016\035"

I heard that this is a work around JRuby users using: https://gist.github.com/738940

David, would you please apply it to jruby-1_5 as well?

Show
Hiroshi Nakamura added a comment - David's fix is [master 63d2150ff4d9c6f47bf189ff68732b0a72a9232a] . This original bug causes OAuth gem raising exception on JRuby 1.5.6 0% jruby15 -rubygems -e 'require "oauth"; p Digest::HMAC.digest("", "", Digest::SHA1)' -e:1: wrong # of arguments(3 for 2) (ArgumentError) 1% jruby -rubygems -e 'require "oauth"; p Digest::HMAC.digest("", "", Digest::SHA1)' "\373\333\035\e\030\252l\b2K}d\267\037\267cpi\016\035" I heard that this is a work around JRuby users using: https://gist.github.com/738940 David, would you please apply it to jruby-1_5 as well?
Hide
Permalink
David Calavera added a comment -

Applied to jruby-1_5 branch

Show
David Calavera added a comment - Applied to jruby-1_5 branch

People

  • Assignee:
    David Calavera
    Reporter:
    Aaron Quint
Vote (0)
Watch (5)

Dates

  • Created:
    Updated:
    Resolved: