JRuby

Ruby#tearDown method causes system exit, but should just raise exception for embedding API

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: JRuby 1.5
  • Fix Version/s: None
  • Component/s: Core Classes/Modules
  • Labels:
    None
  • Patch Submitted:
    Yes
  • Number of attachments :
    1

Description

Ruby#tearDown() method causes system exit when error occurs while evaluating. However, embedding API wants tearDown() method to just raise exception and not to exit JVM. embedding API want a change to manage exception when error is raised.

Attached patch controls system exit. This patch doesn't affect regular script evaluation.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Charles Oliver Nutter added a comment -

Yoko: The patch looks fine to me, so go ahead. But do make sure to keep a no-argument version of teardown() for existing code that uses that form.

Show
Charles Oliver Nutter added a comment - Yoko: The patch looks fine to me, so go ahead. But do make sure to keep a no-argument version of teardown() for existing code that uses that form.
Hide
Permalink
Yoko Harada added a comment -

Done in rev b1966c5. "ant test" passed after the patch has been applied, so I think this change won't affect existing code.

Show
Yoko Harada added a comment - Done in rev b1966c5. "ant test" passed after the patch has been applied, so I think this change won't affect existing code.
Hide
Permalink
Yoko Harada added a comment -

Resolved. Thanks.

Show
Yoko Harada added a comment - Resolved. Thanks.

People

Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved:
Atlassian JIRA (v4.4.3#663-r165197) | Report a problem
Powered by a free Atlassian JIRA open source license for Codehaus. Try JIRA - bug tracking software for your team.