JRuby

[1.9] read_nonblock and read_partial should extend EAGAIN and EWOULDBLOCK with IO::WaitReadable

Details

  • Number of attachments :
    0

Description

From JRUBY-4504:

"In 1.9, net/protocol (used by net/http, used by Gem's remote_fetcher) uses read_nonblock to fetch data. read_nonblock is supposed to raise EAGAIN when there's no data available, which Vladimir recently fixed in JRuby. However in 1.9, EAGAIN raised from read_nonblock is also supposed to .extend IO::WaitReadable, which is what net/protocol expects to rescue for retries. Since we didn't do that, the EAGAIN went all the way out, sources failed to read properly, and gems would not install.

"I pushed a fix in a1f900f for read_nonblock, but there should be similar fixes for read_partial and for EWOULDBLOCK. I'll file a separate bug for those, and for specs to be added to RubySpec."

This is that bug.

Issue Links

is related to

Bug - A problem which impairs or prevents the functions of the product. JRUBY-4747 read_nonblock error with couchrest

  • Blocker - Blocks development and/or testing work, production could not run
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Activity

Hide
Permalink
Charles Oliver Nutter added a comment -

This is fixed at least as of 1.6.6.

read_nonblock has raised the appropriate EAGAIN + WaitReadable for some time.

readpartial does not actually raise that exception; it's supposed to retry. But that's a different bug.

Show
Charles Oliver Nutter added a comment - This is fixed at least as of 1.6.6. read_nonblock has raised the appropriate EAGAIN + WaitReadable for some time. readpartial does not actually raise that exception; it's supposed to retry. But that's a different bug.

People

  • Assignee:
    Charles Oliver Nutter
    Reporter:
    Charles Oliver Nutter
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: