JRuby

[windows] Writing to a pipe with closed source raises wrong exception

Details

  • Testcase included:
    yes
  • Number of attachments :
    1

Description

ruby -e "a,b=IO.pipe;a.close;b.puts('abc');b.close"

On non-Windows, MRI and JRuby reliably raise Errno::EPIPE, which is a proper behavior.

MRI 1.8.6 raises Errno::EINVAL (which seems to be wrong). On MRI 1.9+, MRI properly raises Errno::EPIPE.

JRuby on Windows always raises IOError. It seems to me that the proper behavior for JRuby on Windows should be raising Errno::EPIPE, to be in sync with other platforms.

See also: http://redmine.ruby-lang.org/issues/show/2559

I'm also attaching the test case.

  1. File
    test_write.rb
    08/Jan/10 7:32 AM
    0.3 kB
    Vladimir Sizikov

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Luca Simone added a comment -

Possible fix:
https://github.com/jruby/jruby/pull/24

Show
Luca Simone added a comment - Possible fix: https://github.com/jruby/jruby/pull/24
Hide
Permalink
Charles Oliver Nutter added a comment -

I pushed your change in the commit below...minus the test file. If you'd like bonus points, add this test case to RubySpec, so all impls can enjoy it

commit 24af14859c6adb14c52be3d5b4a9c6c2c1d12dee
Author: Charles Oliver Nutter <headius@headius.com>
Date: Wed Feb 16 16:25:44 2011 -0600

Fix JRUBY-4433: [windows] Writing to a pipe with closed source raises wrong exception

  • Use the IOException's message (different on Windows) to know what to raise.
  • Patch from Luca Simone.
Show
Charles Oliver Nutter added a comment - I pushed your change in the commit below...minus the test file. If you'd like bonus points, add this test case to RubySpec, so all impls can enjoy it commit 24af14859c6adb14c52be3d5b4a9c6c2c1d12dee Author: Charles Oliver Nutter <headius@headius.com> Date: Wed Feb 16 16:25:44 2011 -0600 Fix JRUBY-4433 : [windows] Writing to a pipe with closed source raises wrong exception Use the IOException's message (different on Windows) to know what to raise. Patch from Luca Simone.

People

  • Assignee:
    Charles Oliver Nutter
    Reporter:
    Vladimir Sizikov
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: